Issue metadata
Sign in to add a comment
|
Layout Test webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html is flaky |
||||||||||||||||||||||
Issue descriptionThe following layout test is flaky on Linux webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html Probable cause: A failure log is: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/5297 The test failed with a text diff. The output was: This is a testharness.js-based test. PASS # AUDIT TASK RUNNER STARTED. PASS > [test] Validate Reduction Value of DynamicsCompressor after Disabling FAIL X compressor.reduction is not equal to 0. Got -7.798898696899414. assert_true: expected true got false FAIL < [test] 1 out of 1 assertions were failed. assert_true: expected true got false FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed. assert_true: expected true got false Harness: the test ran to completion.
,
Jun 9 2017
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef9c9e4f70cdc70130e9ab02e36637d1ce41a343 commit ef9c9e4f70cdc70130e9ab02e36637d1ce41a343 Author: tzik <tzik@chromium.org> Date: Fri Jun 09 04:37:08 2017 Mark webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html flaky This layout test is flaky. Samples of failure logs are: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/5297 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/22798 TBR=tzik@chromium.org NOTRY=true Bug: 731518 Change-Id: I08cb98c6d1b4e1179ba84b599136848283369517 Reviewed-on: https://chromium-review.googlesource.com/527740 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#478202} [modify] https://crrev.com/ef9c9e4f70cdc70130e9ab02e36637d1ce41a343/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 9 2017
hongchan: Can you take a look at this since you wrote that test. I'm really surprised it is suddenly flaky. We haven't changed the DynamicsCompressor so I don't see how it can be flaky now suddenly.
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d675ad14edf0a2dbece7eb4af227df353170c0bd commit d675ad14edf0a2dbece7eb4af227df353170c0bd Author: tzik <tzik@chromium.org> Date: Mon Jun 12 04:15:20 2017 Mark webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html flaky on Mac This layout test has been marked as flaky on Windows and Linux, but looks flaky also on Mac. A failure log is: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/47093 TBR=tzik@chromium.org NOTRY=true Bug: 731518 Change-Id: I9e37d6f69e0146a192a31ce46b14b1219de52395 Reviewed-on: https://chromium-review.googlesource.com/530885 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#478552} [modify] https://crrev.com/d675ad14edf0a2dbece7eb4af227df353170c0bd/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 13 2017
Removing sheriff tracking since these have workarounds in place.
,
Jun 23 2017
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/125fa22c1806d4f02e210b31b71e44743099105b commit 125fa22c1806d4f02e210b31b71e44743099105b Author: Hongchan Choi <hongchan@chromium.org> Date: Thu Mar 08 20:57:26 2018 Update TestExepctations for flaky compressor test We missed this line when we add the tail processing change. Let's add it back in. Bug: 731518 Change-Id: Id90cade41f311309ef60f049094478de0ad4c19e Reviewed-on: https://chromium-review.googlesource.com/956318 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541883} [modify] https://crrev.com/125fa22c1806d4f02e210b31b71e44743099105b/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45a0c949c2a456761ffa3011f7058c3d8b7a2d96 commit 45a0c949c2a456761ffa3011f7058c3d8b7a2d96 Author: Raymond Toy <rtoy@chromium.org> Date: Sat Mar 17 00:21:33 2018 Implement tail processing for AudioNodes Enable tail processing by calling the necessary routines. A continuation of https://chromium-review.googlesource.com/c/chromium/src/+/949762 where tail processing is actually running. Keep nodes alive when there are no input connections so that the node has time to flush out any internal memory. When the output of the node is going to be disabled (because there are no inputs), place the node on a list, without disabling the output. The list is processed every rendering quantum to see if the tail time of node has passed. If the tail time has not passed, nothing is done; otherwise, the output is disabled, and the node is removed from the list. This allows the node to be collected, if possible. Bug:357843, 731518 Test:AudioNode/tail-processing.html,DynamicsCompressor/dynamicscompressor-clear-internal-state.html Change-Id: I5ba37015787fbbb2342eacb57b4851b99a36b3c5 Reviewed-on: https://chromium-review.googlesource.com/661165 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543881} [modify] https://crrev.com/45a0c949c2a456761ffa3011f7058c3d8b7a2d96/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/45a0c949c2a456761ffa3011f7058c3d8b7a2d96/third_party/WebKit/LayoutTests/webaudio/AudioNode/tail-processing.html [modify] https://crrev.com/45a0c949c2a456761ffa3011f7058c3d8b7a2d96/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html [modify] https://crrev.com/45a0c949c2a456761ffa3011f7058c3d8b7a2d96/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp [modify] https://crrev.com/45a0c949c2a456761ffa3011f7058c3d8b7a2d96/third_party/WebKit/Source/modules/webaudio/AudioNode.h [modify] https://crrev.com/45a0c949c2a456761ffa3011f7058c3d8b7a2d96/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp [modify] https://crrev.com/45a0c949c2a456761ffa3011f7058c3d8b7a2d96/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h [modify] https://crrev.com/45a0c949c2a456761ffa3011f7058c3d8b7a2d96/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tzik@chromium.org
, Jun 9 2017Status: Assigned (was: Untriaged)