Add UMA stats for tracking ENOSPC migration failures |
|||||||
Issue descriptionWe don't yet have a good understanding of why we nee ENOSPC failures during the ecryptfs->ext4crypto migration. We should be able to clarify the situation by adding some new UMA stats that are reported when we encounter the error. Proposed stats: Current Xattr Size (only when ENOSPC happens during an attempt to write xattrs) Current Free Disk Space Free Disk Space At Migration Start
,
Jun 9 2017
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/68d535cd99710537905c7590951cba2be9928914 commit 68d535cd99710537905c7590951cba2be9928914 Author: Dan Spaid <dspaid@google.com> Date: Mon Jun 12 13:47:40 2017 cryptohome: Record free space and xattr size When the ecryptfs->ext4crypto fails with an ENOSPC record UMA stats including the initial free space when the migration started as well as the free space at time of failure. If the error occurs during an attempt to set an xattr, also record the total xattr size of the existing attributes on the file in addition to the xattr that was not successfully set. TEST=cros_workon_make --board=samus --test cryptohome BUG= chromium:731505 Change-Id: Iac282ca83109dff7b81680aa04f01df8e62dc4a5 Reviewed-on: https://chromium-review.googlesource.com/527742 Commit-Ready: Dan Spaid <dspaid@chromium.org> Tested-by: Dan Spaid <dspaid@chromium.org> Reviewed-by: Dan Spaid <dspaid@chromium.org> [modify] https://crrev.com/68d535cd99710537905c7590951cba2be9928914/cryptohome/dircrypto_data_migrator/migration_helper.cc [modify] https://crrev.com/68d535cd99710537905c7590951cba2be9928914/cryptohome/cryptohome_metrics.cc [modify] https://crrev.com/68d535cd99710537905c7590951cba2be9928914/cryptohome/cryptohome_metrics.h [modify] https://crrev.com/68d535cd99710537905c7590951cba2be9928914/cryptohome/dircrypto_data_migrator/migration_helper.h
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/68d535cd99710537905c7590951cba2be9928914 commit 68d535cd99710537905c7590951cba2be9928914 Author: Dan Spaid <dspaid@google.com> Date: Mon Jun 12 13:47:40 2017 cryptohome: Record free space and xattr size When the ecryptfs->ext4crypto fails with an ENOSPC record UMA stats including the initial free space when the migration started as well as the free space at time of failure. If the error occurs during an attempt to set an xattr, also record the total xattr size of the existing attributes on the file in addition to the xattr that was not successfully set. TEST=cros_workon_make --board=samus --test cryptohome BUG= chromium:731505 Change-Id: Iac282ca83109dff7b81680aa04f01df8e62dc4a5 Reviewed-on: https://chromium-review.googlesource.com/527742 Commit-Ready: Dan Spaid <dspaid@chromium.org> Tested-by: Dan Spaid <dspaid@chromium.org> Reviewed-by: Dan Spaid <dspaid@chromium.org> [modify] https://crrev.com/68d535cd99710537905c7590951cba2be9928914/cryptohome/dircrypto_data_migrator/migration_helper.cc [modify] https://crrev.com/68d535cd99710537905c7590951cba2be9928914/cryptohome/cryptohome_metrics.cc [modify] https://crrev.com/68d535cd99710537905c7590951cba2be9928914/cryptohome/cryptohome_metrics.h [modify] https://crrev.com/68d535cd99710537905c7590951cba2be9928914/cryptohome/dircrypto_data_migrator/migration_helper.h
,
Jun 14 2017
,
Jun 14 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 19 2017
,
Jun 23 2017
We think we have a good handle on this issue, so we no longer need to merge to M60.
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dspaid@chromium.org
, Jun 9 2017