New issue
Advanced search Search tips

Issue 731504 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Setup dedicated SoM Dispatch Builder

Project Member Reported by dgarr...@chromium.org, Jun 9 2017

Issue description

We want to move SoM dispatch out of our master builders into a dedicated location.

A builder which runs repeatedly is a very reasonable solution, so....

Create a special purpose build config that runs the SoM script, then add it as a repeating builder.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/aa2eb866f9643ac98815d04f676252ebcbdb8604

commit aa2eb866f9643ac98815d04f676252ebcbdb8604
Author: Don Garrett <dgarrett@google.com>
Date: Thu Jul 27 05:41:56 2017

chromite: Add som-dispatcher build config.

Add everything needed to create a new builder to generate all SoM
alerts from a single location. This includes new build config, builder
class, and active stage.

This stage constains code only trivially modified from the Report
stage. This will need further modification to handle all builds.

After this is in place and working, we'll remove SoM dispatch code
from the ReportStage, and stop running it on our build masters.

BUG= chromium:731504 
TEST=None (yet)

Change-Id: Ieb5c58b52f59263e09dc57136109d9e8f4694980
Reviewed-on: https://chromium-review.googlesource.com/536335
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>

[modify] https://crrev.com/aa2eb866f9643ac98815d04f676252ebcbdb8604/cbuildbot/chromeos_config.py
[modify] https://crrev.com/aa2eb866f9643ac98815d04f676252ebcbdb8604/lib/config_lib.py
[add] https://crrev.com/aa2eb866f9643ac98815d04f676252ebcbdb8604/cbuildbot/builders/alert_builders.py
[modify] https://crrev.com/aa2eb866f9643ac98815d04f676252ebcbdb8604/cbuildbot/config_dump.json
[add] https://crrev.com/aa2eb866f9643ac98815d04f676252ebcbdb8604/cbuildbot/stages/alert_stages.py
[modify] https://crrev.com/aa2eb866f9643ac98815d04f676252ebcbdb8604/lib/constants.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/69ddfe772d789accc021a622ca6412951ac140be

commit 69ddfe772d789accc021a622ca6412951ac140be
Author: Don Garrett <dgarrett@google.com>
Date: Mon Jul 31 00:39:46 2017

SomDispatcher: Allow failures to fail build.

Also stop creating a chroot, since we don't need it for this build.

BUG= chromium:731504 
TEST=run_tests

Change-Id: I9ad5a8652e8c89993ec7b07fbf90e0fb26f0f6b1
Reviewed-on: https://chromium-review.googlesource.com/590572
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/69ddfe772d789accc021a622ca6412951ac140be/cbuildbot/stages/alert_stages.py
[modify] https://crrev.com/69ddfe772d789accc021a622ca6412951ac140be/cbuildbot/builders/alert_builders.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/71d342743ff6d60a5afb8d4f920ce530f9f806df

commit 71d342743ff6d60a5afb8d4f920ce530f9f806df
Author: Don Garrett <dgarrett@google.com>
Date: Mon Jul 31 00:39:47 2017

chromeos_config: Add som-dispatcher to internal waterfall.

Define a new builder for the ChromeOS internal waterfall. This is
expected to allocate a build column for it, but not to setup a
scheduler (yet). Will require a waterfall restart to take effect.

BUG= chromium:731504 
TEST=chromeos_config_unittest

Change-Id: I6b596e1634cb9c94504e3e4666257092e0c8177d
Reviewed-on: https://chromium-review.googlesource.com/592450
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/71d342743ff6d60a5afb8d4f920ce530f9f806df/cbuildbot/config_dump.json
[modify] https://crrev.com/71d342743ff6d60a5afb8d4f920ce530f9f806df/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/71d342743ff6d60a5afb8d4f920ce530f9f806df/cbuildbot/chromeos_config.py

This builder now exists, but has no build scheduler. I've just manually triggered a build for it. If it works, and we are satisfied with the results, I'll enable a scheduler to run the builds automatically.

https://uberchromegw.corp.google.com/i/chromeos/builders/som-dispatcher
Status: Fixed (was: Started)
This builder is being scheduled and completing runs about every 25 minutes.

https://luci-scheduler.appspot.com/jobs/chromiumos-chromite/som-dispatcher

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a16878e9f167bccc273e398f4d6997136cf75471

commit a16878e9f167bccc273e398f4d6997136cf75471
Author: Don Garrett <dgarrett@google.com>
Date: Wed Aug 09 18:48:03 2017

report_stages: Remove Sheriff-O-Matic dispatching.

Now that we have the som-dispatcher builder, we no longer need to run
this process during the report stages of normal builders.

BUG= chromium:731504 
TEST=run_tests

Change-Id: I2e38cf84edd1938945260534ac670f3eaaa81e5b
Reviewed-on: https://chromium-review.googlesource.com/598438
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>

[modify] https://crrev.com/a16878e9f167bccc273e398f4d6997136cf75471/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/a16878e9f167bccc273e398f4d6997136cf75471/cbuildbot/stages/report_stages.py

Sign in to add a comment