New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 731496 link

Starred by 1 user
Status: Fixed
Owner:
mar...@chromium.org
Closed: Jun 2017
Cc:
█ kbr@chromium.org
d...@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Feature



Sign in to add a comment

Add 'host_hw_model' dimensions, specifically for macs

Project Member Reported by mar...@chromium.org, Jun 9 2017 
In the case of Macs, it should look like MacBookPro11,3 or MacMini7,1.
For PCs, I don't think there's much value.
For things like RPis, it would be nice to have but this is not something needed so it is out of the scope of this bug.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/9727759af4def9f652d6a08cff42d17584d19e4b

commit 9727759af4def9f652d6a08cff42d17584d19e4b
Author: maruel <maruel@chromium.org>
Date: Fri Jun 09 20:49:56 2017

Promote 'model' from state to dimension for Macs.

- The new dimension 'model' permits selecting bots based on hardware.
- Fix a problem with xcode version detection where the bot would be quarantined
  when XCode is not installed due to an empty dimension value. We never hit it
  yet just because XCode is installed everywhere.

R=kbr@chromium.org
BUG= 731496 

Review-Url: https://codereview.chromium.org/2933593002

[modify] https://crrev.com/9727759af4def9f652d6a08cff42d17584d19e4b/appengine/swarming/swarming_bot/api/os_utilities.py
[modify] https://crrev.com/9727759af4def9f652d6a08cff42d17584d19e4b/appengine/swarming/swarming_bot/api/os_utilities_test.py

Comment 2 by mar...@chromium.org, Jun 12 2017

Owner: mar...@chromium.org
Status: Fixed (was: Available)
Use 'mac_model'.
►

Sign in to add a comment