New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731495 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

CHECK failure: args[0]->IsString() in runtime-strings.cc

Project Member Reported by ClusterFuzz, Jun 9 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6566246584942592

Fuzzer: inferno_js_fuzzer
Job Type: linux_asan_d8_v8_mipsel_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  args[0]->IsString() in runtime-strings.cc
  v8::internal::__RT_impl_Runtime_StringAdd
  v8::internal::Runtime_StringAdd
  
Sanitizer: address (ASAN)

Regressed: V8: 45785:45786

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6566246584942592


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: jarin@chromium.org
Owner: rmcilroy@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 9 2017

Labels: M-60
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 9 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 9 2017

Labels: Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fc826e3735b2e1455d0f5c4df01ec3a3e68ad14b

commit fc826e3735b2e1455d0f5c4df01ec3a3e68ad14b
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Fri Jun 09 15:10:56 2017

[TurboFan] Fix typing of INTERNALIZED_STRING_TYPE for new EmptyString type.

Add kInternalizedNonEmptySeqString and make kInternalizedString = 
kEmptyString | kInternalizedNonEmptySeqString.

BUG= chromium:731495 

Change-Id: I60a6f37242423407ad97188b3f4bd48ae6989ad2
Reviewed-on: https://chromium-review.googlesource.com/528275
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45821}
[modify] https://crrev.com/fc826e3735b2e1455d0f5c4df01ec3a3e68ad14b/src/compiler/types.h
[add] https://crrev.com/fc826e3735b2e1455d0f5c4df01ec3a3e68ad14b/test/mjsunit/compiler/regress-731495.js

Status: Fixed (was: Assigned)
Project Member

Comment 9 by ClusterFuzz, Jun 10 2017

ClusterFuzz has detected this issue as fixed in range 45820:45821.

Detailed report: https://clusterfuzz.com/testcase?key=6566246584942592

Fuzzer: inferno_js_fuzzer
Job Type: linux_asan_d8_v8_mipsel_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  args[0]->IsString() in runtime-strings.cc
  v8::internal::__RT_impl_Runtime_StringAdd
  v8::internal::Runtime_StringAdd
  
Sanitizer: address (ASAN)

Regressed: V8: 45785:45786
Fixed: V8: 45820:45821

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6566246584942592


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 10 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable Merge-Request-60
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 12 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Approving merge to M60. Security bug marked as RB-Stable. 
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 15 2017

Cc: awhalley@chromium.org abdulsyed@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -M-60 -Merge-Approved-60 M-61
The CL which introduced the bug was never in the m60 branch, so no need to merge.
Labels: -ReleaseBlock-Stable
Project Member

Comment 17 by sheriffbot@chromium.org, Sep 16 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment