New issue
Advanced search Search tips

Issue 731490 link

Starred by 2 users
Status: Untriaged
Owner: ----
Cc:
nverne@chromium.org
kinuko@chromium.org
joelhockey@chromium.org
slangley@chromium.org
haraken@chromium.org
dcheng@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 712963


Sign in to add a comment

Clean up core/ and modules/ post-web/ removal

Project Member Reported by sashab@chromium.org, Jun 9 2017 
Now that many files have been moved out of web/ to core/ and modules/, refactor these classes to be simpler and remove many intermediary classes that are no longer necessary.

Later, this bug will have a proper design and approach. For now, only small refactors/cleanups are happening, with  bug 712963  as higher priority.

Comment 1 by sashab@chromium.org, Jun 9 2017

Cc: dcheng@chromium.org kinuko@chromium.org haraken@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d835a9885eef04f8d7560e07c2ce9fa3d61bb16f

commit d835a9885eef04f8d7560e07c2ce9fa3d61bb16f
Author: Sasha Bermeister <sashab@chromium.org>
Date: Wed Jun 14 04:59:34 2017

Merge PopupMenu with PopupMenuImpl

The PopupMenu parent class is an artifact left over from when PopupMenu
was in platform/ and PopupMenuImpl was in core/. Now that they are both
in core/, there's no need to have these as two separate classes.

Bug: 731490
Change-Id: I673e4f18b67b03e3f04c29517219ddda500d2680
Reviewed-on: https://chromium-review.googlesource.com/527721
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479287}
[modify] https://crrev.com/d835a9885eef04f8d7560e07c2ce9fa3d61bb16f/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-crash-on-style-update.html
[modify] https://crrev.com/d835a9885eef04f8d7560e07c2ce9fa3d61bb16f/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/d835a9885eef04f8d7560e07c2ce9fa3d61bb16f/third_party/WebKit/Source/core/page/BUILD.gn
[modify] https://crrev.com/d835a9885eef04f8d7560e07c2ce9fa3d61bb16f/third_party/WebKit/Source/core/page/ExternalPopupMenu.cpp
[modify] https://crrev.com/d835a9885eef04f8d7560e07c2ce9fa3d61bb16f/third_party/WebKit/Source/core/page/ExternalPopupMenu.h
[rename] https://crrev.com/d835a9885eef04f8d7560e07c2ce9fa3d61bb16f/third_party/WebKit/Source/core/page/PopupMenu.cpp
[modify] https://crrev.com/d835a9885eef04f8d7560e07c2ce9fa3d61bb16f/third_party/WebKit/Source/core/page/PopupMenu.h
[delete] https://crrev.com/4019e47f8183a29031ec1a10550b5850ded0ba75/third_party/WebKit/Source/core/page/PopupMenuImpl.h
[modify] https://crrev.com/d835a9885eef04f8d7560e07c2ce9fa3d61bb16f/third_party/WebKit/Source/web/ChromeClientImpl.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9848df898526e51f20e95deddd426575b758418

commit f9848df898526e51f20e95deddd426575b758418
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Jun 14 06:20:26 2017

Revert "Merge PopupMenu with PopupMenuImpl"

This reverts commit d835a9885eef04f8d7560e07c2ce9fa3d61bb16f.

Reason for revert: ExternalPopupMenu should not inherit from PopupMenuImpl conceptually.

Original change's description:
> Merge PopupMenu with PopupMenuImpl
> 
> The PopupMenu parent class is an artifact left over from when PopupMenu
> was in platform/ and PopupMenuImpl was in core/. Now that they are both
> in core/, there's no need to have these as two separate classes.
> 
> Bug: 731490
> Change-Id: I673e4f18b67b03e3f04c29517219ddda500d2680
> Reviewed-on: https://chromium-review.googlesource.com/527721
> Commit-Queue: Sasha Morrissey <sashab@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#479287}

TBR=dcheng@chromium.org,kinuko@chromium.org,haraken@chromium.org,sashab@chromium.org,slangley@chromium.org

Change-Id: I5705d68feae232819be90c18e2b7cd7057b46b5b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 731490
Reviewed-on: https://chromium-review.googlesource.com/535238
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479302}
[modify] https://crrev.com/f9848df898526e51f20e95deddd426575b758418/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-crash-on-style-update.html
[modify] https://crrev.com/f9848df898526e51f20e95deddd426575b758418/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/f9848df898526e51f20e95deddd426575b758418/third_party/WebKit/Source/core/page/BUILD.gn
[modify] https://crrev.com/f9848df898526e51f20e95deddd426575b758418/third_party/WebKit/Source/core/page/ExternalPopupMenu.cpp
[modify] https://crrev.com/f9848df898526e51f20e95deddd426575b758418/third_party/WebKit/Source/core/page/ExternalPopupMenu.h
[modify] https://crrev.com/f9848df898526e51f20e95deddd426575b758418/third_party/WebKit/Source/core/page/PopupMenu.h
[rename] https://crrev.com/f9848df898526e51f20e95deddd426575b758418/third_party/WebKit/Source/core/page/PopupMenuImpl.cpp
[add] https://crrev.com/f9848df898526e51f20e95deddd426575b758418/third_party/WebKit/Source/core/page/PopupMenuImpl.h
[modify] https://crrev.com/f9848df898526e51f20e95deddd426575b758418/third_party/WebKit/Source/web/ChromeClientImpl.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b52f16be8c5dfc01e33afae295b5ed78c9764262

commit b52f16be8c5dfc01e33afae295b5ed78c9764262
Author: Sasha Bermeister <sashab@chromium.org>
Date: Wed Jun 14 07:22:07 2017

Merged NavigatorContentUtilsClient and NavigatorContentUtilsClientImpl

The NavigatorContentUtilsClientImpl class is an artifact left over from
when NavigatorContentUtilsClient was in modules/ and
NavigatorContentUtilsClientImpl was in web/. Now that they are both in
modules/, there's no need to have these as two separate classes.

Bug: 731490
Change-Id: I63d18671e6ebfadd8fefe8c52617918474f5cbc0
Reviewed-on: https://chromium-review.googlesource.com/535195
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479315}
[modify] https://crrev.com/b52f16be8c5dfc01e33afae295b5ed78c9764262/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/b52f16be8c5dfc01e33afae295b5ed78c9764262/third_party/WebKit/Source/modules/navigatorcontentutils/BUILD.gn
[add] https://crrev.com/b52f16be8c5dfc01e33afae295b5ed78c9764262/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.cpp
[modify] https://crrev.com/b52f16be8c5dfc01e33afae295b5ed78c9764262/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h
[delete] https://crrev.com/4c9217a8f484ed4624f4ab103a2a8cdf8d8a515e/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClientImpl.cpp
[delete] https://crrev.com/4c9217a8f484ed4624f4ab103a2a8cdf8d8a515e/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClientImpl.h
[modify] https://crrev.com/b52f16be8c5dfc01e33afae295b5ed78c9764262/third_party/WebKit/Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a51ca1da61d7725ce337d32717b89508d121378

commit 2a51ca1da61d7725ce337d32717b89508d121378
Author: Sasha Bermeister <sashab@chromium.org>
Date: Thu Jun 15 09:41:11 2017

Move PopupMenuImpl to core/html/forms and rename to InternalPopup

Move PopupMenu and PopupMenuImpl to core/html/forms and rename
PopupMenuImpl to InternalPopup.

Bug: 731490
Change-Id: I551a5448ce0f782967c32e5564566cdb871a5a3d
Reviewed-on: https://chromium-review.googlesource.com/535197
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479650}
[modify] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-crash-on-style-update.html
[modify] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[rename] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/Source/core/html/forms/ExternalPopupMenu.cpp
[rename] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/Source/core/html/forms/ExternalPopupMenu.h
[rename] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/Source/core/html/forms/InternalPopupMenu.cpp
[rename] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/Source/core/html/forms/InternalPopupMenu.h
[rename] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/Source/core/html/forms/PopupMenu.h
[modify] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/Source/core/page/BUILD.gn
[modify] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/2a51ca1da61d7725ce337d32717b89508d121378/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a337add9b896c93a27327190657497381f8085c2

commit a337add9b896c93a27327190657497381f8085c2
Author: Stuart Langley <slangley@chromium.org>
Date: Thu Jul 13 08:46:30 2017

Replace references to WebPluginContainerBase with WebPluginContainerImpl.

This is part of the process to remove the temporary WebPluginContainerBase.

Bug: 731490
Change-Id: Ie709b7305b0525f4df9ebb35dbac46901859df75
Reviewed-on: https://chromium-review.googlesource.com/569658
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486322}
[modify] https://crrev.com/a337add9b896c93a27327190657497381f8085c2/third_party/WebKit/Source/core/exported/WebHelperPluginImpl.cpp
[modify] https://crrev.com/a337add9b896c93a27327190657497381f8085c2/third_party/WebKit/Source/core/exported/WebHelperPluginImpl.h
[modify] https://crrev.com/a337add9b896c93a27327190657497381f8085c2/third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp
[modify] https://crrev.com/a337add9b896c93a27327190657497381f8085c2/third_party/WebKit/Source/core/page/ContextMenuClient.cpp
[modify] https://crrev.com/a337add9b896c93a27327190657497381f8085c2/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/a337add9b896c93a27327190657497381f8085c2/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d

commit a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d
Author: Stuart Langley <slangley@chromium.org>
Date: Thu Jul 13 11:44:12 2017

Replace references to WebPluginContainerBase with WebPluginContainerImpl.

Also, renames the method GetWebPluginContainerBase() to GetWebPluginContaner()
to remove ingrained references to the implementation type.

Bug: 731490
Change-Id: I89f2ae0626c0e89d25b5e0fe6997309296c73606
Reviewed-on: https://chromium-review.googlesource.com/569899
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486347}
[modify] https://crrev.com/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.cpp
[modify] https://crrev.com/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d/third_party/WebKit/Source/core/exported/WebNode.cpp
[modify] https://crrev.com/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.h
[modify] https://crrev.com/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d/third_party/WebKit/Source/core/exported/WebPluginDocument.cpp
[modify] https://crrev.com/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d/third_party/WebKit/Source/core/plugins/PluginView.h
[modify] https://crrev.com/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/a7e76a932c9fbe1c954f39e74a8c67ca83a5fe0d/third_party/WebKit/Source/web/WebViewImpl.cpp
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af

commit b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af
Author: Stuart Langley <slangley@chromium.org>
Date: Thu Jul 27 01:10:13 2017

Remove references to WebRemoteFrameBase.

This CL removes the usage of WebRemoteFrameBase, a follow-up CL will
delete it entirely.

Bug: 731490
Change-Id: Ia505bc7ba97013fcff3a73d49b86c35bcba971d2
Reviewed-on: https://chromium-review.googlesource.com/584693
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489824}
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/core/exported/WebFrame.cpp
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/core/frame/BUILD.gn
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/core/frame/FrameTestHelpers.h
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h
[delete] https://crrev.com/3b52cb6a2e29e9b1b9eb14d86535893f71edb43c/third_party/WebKit/Source/core/frame/WebRemoteFrameBase.cpp
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/core/frame/WebRemoteFrameBase.h
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/core/page/ChromeClientImpl.h
[modify] https://crrev.com/b6ad4300969ae4b8a6d2991c3869c6aa56c8a1af/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9f5336c0d4451359a71c7274b9f2d01b6ff1237

commit e9f5336c0d4451359a71c7274b9f2d01b6ff1237
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Jul 31 02:10:43 2017

Start removing WebLocalFrameBase in favour of WebLocalFrameImpl.

I'm starting with the simplest of changes, which includes.
- just changing the header file over and transitively including WebLocalFrameBase
  temporarily.
- places where WebLocalFrameBase was being used as a local variable.

I'll split this into multiple CL's to help it go through the CQ.

Bug: 731490
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I40a62619be3ef4034c048f8d17e52404eccd74ab
Reviewed-on: https://chromium-review.googlesource.com/590591
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490696}
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/bindings/core/v8/ActivityLoggerTest.cpp
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/core/animation/AnimationSimTest.cpp
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/core/events/WebInputEventConversionTest.cpp
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/core/page/ViewportTest.cpp
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/core/paint/LinkHighlightImpl.cpp
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/core/paint/LinkHighlightImplTest.cpp
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/core/scheduler/ActiveConnectionThrottlingTest.cpp
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/core/scheduler/FrameThrottlingTest.cpp
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/core/testing/sim/SimCompositor.cpp
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
[modify] https://crrev.com/e9f5336c0d4451359a71c7274b9f2d01b6ff1237/third_party/WebKit/Source/core/workers/Worker.cpp

Comment 12 by slangley@chromium.org, Aug 2 2017

Owner: slangley@chromium.org
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aeb8cb25eb41bef8a80e03be0b05bd5a8050384

commit 4aeb8cb25eb41bef8a80e03be0b05bd5a8050384
Author: Stuart Langley <slangley@chromium.org>
Date: Fri Aug 04 00:52:05 2017

Do not allow new depdencies from modules/ to core/exported and friends.

Until we resolve the control layer we do not want new users of the classes
defined in core/exported or Web(Local|Remote)FrameImpl. To use one of these
classes they need to be moved out of exported or split into controller.

Bug: 731490
Change-Id: Iaae52859aded432364cc6a5461ba04e267e4dd1e
Reviewed-on: https://chromium-review.googlesource.com/597572
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491894}
[modify] https://crrev.com/4aeb8cb25eb41bef8a80e03be0b05bd5a8050384/third_party/WebKit/Source/modules/DEPS
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4ee907393c9a8ebec5f02c9af8f486e5a12b0a5

commit d4ee907393c9a8ebec5f02c9af8f486e5a12b0a5
Author: Stuart Langley <slangley@chromium.org>
Date: Fri Aug 04 03:30:37 2017

Merge IndexedDBClient and IndexedDBClientImpl.

IndexedDBClientImpl is no longer required now that the web/ layer has been
removed and it's contents moved to modules/ and core/.

Bug: 731490
Change-Id: Ia5720f6326e742b606002ddddcafb5cd5a24e460
Reviewed-on: https://chromium-review.googlesource.com/597570
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491930}
[modify] https://crrev.com/d4ee907393c9a8ebec5f02c9af8f486e5a12b0a5/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/d4ee907393c9a8ebec5f02c9af8f486e5a12b0a5/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/d4ee907393c9a8ebec5f02c9af8f486e5a12b0a5/third_party/WebKit/Source/modules/indexeddb/BUILD.gn
[modify] https://crrev.com/d4ee907393c9a8ebec5f02c9af8f486e5a12b0a5/third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.cpp
[modify] https://crrev.com/d4ee907393c9a8ebec5f02c9af8f486e5a12b0a5/third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.h
[delete] https://crrev.com/bbefdd9b78a9485ac2024d0a6189bc79199617d5/third_party/WebKit/Source/modules/indexeddb/IndexedDBClientImpl.cpp
[delete] https://crrev.com/bbefdd9b78a9485ac2024d0a6189bc79199617d5/third_party/WebKit/Source/modules/indexeddb/IndexedDBClientImpl.h
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4213a7a72e73afe82d0850794d543e57b4c00bf4

commit 4213a7a72e73afe82d0850794d543e57b4c00bf4
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Aug 07 03:09:41 2017

Complete replacing all references to WebLocalFrameBase with WebLocalFrameImpl.

This CL changes over all remaing refereces from WebLocalFrameBase to
WebLocalFrameImpl, as part of the process to remove the *Base classes that were
introduced to move files from web/ -> core/. The remaining step is to remove
the WebLocalFrameBase abstraction entirely.

Bug: 731490
Change-Id: I8166a5b7aa89d1c1d567191fb737f030e481d518
Reviewed-on: https://chromium-review.googlesource.com/597367
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492261}
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/editing/TextFinder.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/editing/TextFinder.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/editing/WebSubstringUtil.mm
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/editing/spellcheck/TextCheckerClientImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/editing/spellcheck/TextCheckerClientImpl.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebDocument.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebFrame.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebFrameContentDumper.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebFrameSerializer.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebHelperPluginImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebHelperPluginImpl.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebScopedUserGesture.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebSurroundingText.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/exported/WebUserGestureIndicator.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/frame/BUILD.gn
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/frame/RemoteFrameOwner.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/frame/WebFrameSerializerImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/frame/WebFrameSerializerImpl.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
[delete] https://crrev.com/9604d8b285ec422d4ba9d66f3f8446ccc4deb521/third_party/WebKit/Source/core/frame/WebLocalFrameBase.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/html/forms/ColorChooserUIController.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/html/forms/ExternalPopupMenu.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/layout/LayoutGeometryMapTest.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/page/ChromeClientImpl.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/page/ContextMenuClient.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/page/EditorClient.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/page/PageOverlayTest.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/core/page/scrolling/ScrollMetricsTest.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClientImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletProxyClientImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerProxyClientImpl.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/encryptedmedia/MediaKeysController.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/exported/WebAXObject.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/exported/WebDOMFileSystem.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/exported/WebLeakDetector.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/quota/StorageQuotaClient.cpp
[modify] https://crrev.com/4213a7a72e73afe82d0850794d543e57b4c00bf4/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4655a788bbaba75a2e867266e4c9a7eafd158bf

commit f4655a788bbaba75a2e867266e4c9a7eafd158bf
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Aug 07 05:13:45 2017

Merge UserMediaClient and UserMediaClientImpl.

UserMediaClientImpl was required when there was a web/ layer, now that it has
been removed we can collapse these two into one class.

Bug: 731490
Change-Id: I69dba068e25b9d421f2d994948c60dff21685e5a
Reviewed-on: https://chromium-review.googlesource.com/597528
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492267}
[modify] https://crrev.com/f4655a788bbaba75a2e867266e4c9a7eafd158bf/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/f4655a788bbaba75a2e867266e4c9a7eafd158bf/third_party/WebKit/Source/modules/mediastream/BUILD.gn
[modify] https://crrev.com/f4655a788bbaba75a2e867266e4c9a7eafd158bf/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[rename] https://crrev.com/f4655a788bbaba75a2e867266e4c9a7eafd158bf/third_party/WebKit/Source/modules/mediastream/UserMediaClient.cpp
[modify] https://crrev.com/f4655a788bbaba75a2e867266e4c9a7eafd158bf/third_party/WebKit/Source/modules/mediastream/UserMediaClient.h
[delete] https://crrev.com/e2b3698c962e14be9675d533d179d4a5335cd40e/third_party/WebKit/Source/modules/mediastream/UserMediaClientImpl.h
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3373ef06dbe342b74832f7285bf410cf9978cfe4

commit 3373ef06dbe342b74832f7285bf410cf9978cfe4
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Aug 07 07:23:15 2017

Start replacing usages of WebViewBase with WebViewImpl.

WebViewBase is a temporary abstraction that was introduced to help move
WebViewImpl and it's dependencies from web/ to modules/ and core/.

Now that WebViewImpl is in core we can remove WebViewBase.

Bug: 731490
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7977449b1486827fc626013f91182ab0700da17b
Reviewed-on: https://chromium-review.googlesource.com/602403
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492277}
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/editing/LinkSelectionTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerClientImpl.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerClientImpl.h
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/editing/spellcheck/TextCheckerClientImpl.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/events/WebInputEventConversionTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/exported/WebFrameSerializerSanitizationTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/exported/WebFrameSerializerTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/exported/WebPagePopupImpl.h
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/exported/WebSearchableFormDataTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/frame/BrowserControlsTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/frame/DeferredLoadingTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/frame/FrameSerializerTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/frame/FrameTestHelpers.h
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/frame/FullscreenController.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/frame/FullscreenController.h
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/input/ImeOnFocusTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/input/TouchActionTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/layout/LayoutGeometryMapTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/layout/compositing/CompositorWorkerTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/loader/ProgrammaticScrollTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/page/PageOverlayTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp
[modify] https://crrev.com/3373ef06dbe342b74832f7285bf410cf9978cfe4/third_party/WebKit/Source/core/paint/LinkHighlightImplTest.cpp
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c7449557c06945e52287a2a3647bb6948438145

commit 6c7449557c06945e52287a2a3647bb6948438145
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Aug 08 04:24:33 2017

Replace usage of WebViewBase with WebViewImpl.

WebViewBase is a temporary abstraction that was introduced to help move
WebViewImpl and it's dependencies from web/ to modules/ and core/.

Now that WebViewImpl is in core we can remove WebViewBase.

Bug: 731490
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I545119d3f2959dd9d14dbd02d2881cc6a167b7d2
Reviewed-on: https://chromium-review.googlesource.com/605031
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492530}
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/editing/TextFinder.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/frame/VisualViewportTest.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/html/forms/InternalPopupMenu.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/intersection_observer/IntersectionObserverTest.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/layout/ng/NGInlineLayoutTest.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/loader/DocumentLoaderTest.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/loader/PrerendererClient.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/page/ChromeClientImplTest.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/page/ContextMenuClient.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/page/ContextMenuClient.h
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/page/EditorClient.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/page/EditorClient.h
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/paint/LinkHighlightImpl.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/paint/LinkHighlightImpl.h
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/resize_observer/ResizeObserverTest.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/scheduler/ActiveConnectionThrottlingTest.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/testing/sim/SimCompositor.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/testing/sim/SimCompositor.h
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/testing/sim/SimTest.cpp
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/core/testing/sim/SimTest.h
[modify] https://crrev.com/6c7449557c06945e52287a2a3647bb6948438145/third_party/WebKit/Source/modules/exported/WebStorageEventDispatcherImpl.cpp
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5110b553fe6fa862a41975b042c8d624c787df48

commit 5110b553fe6fa862a41975b042c8d624c787df48
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Aug 08 06:24:26 2017

Remove WebLocalFrameBase.h and all references.

WebLocalFrameBase was a temporary abstraction introduced to facilitate the
moving of classes from web/ to modules/ and core/. Now that this move has
been completed we can remove this abstraction.

Bug: 731490
Change-Id: I9dd9bcfff04295480fcb8a0392af03a3bf2d37b8
Reviewed-on: https://chromium-review.googlesource.com/603189
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492551}
[modify] https://crrev.com/5110b553fe6fa862a41975b042c8d624c787df48/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/5110b553fe6fa862a41975b042c8d624c787df48/third_party/WebKit/Source/core/exported/DEPS
[modify] https://crrev.com/5110b553fe6fa862a41975b042c8d624c787df48/third_party/WebKit/Source/core/frame/BUILD.gn
[delete] https://crrev.com/58680ff44a9e66d7ec0154b2bf8de17fddc69913/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
[modify] https://crrev.com/5110b553fe6fa862a41975b042c8d624c787df48/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/5110b553fe6fa862a41975b042c8d624c787df48/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826

commit eb1f92ff2e35ddedd2ecd563732096c7d4d5c826
Author: Stuart Langley <slangley@chromium.org>
Date: Wed Aug 09 10:06:50 2017

Completely remove WebViewBase.(cpp|h).

WebViewBase.* was introduced as a temporary abstraction for WebViewImpl.* to
assist in moving files from web/ -> core/ and modules/. Now that WebViewImpl.*
is in core we can remove this temporary abstraction.

Bug: 731490
Change-Id: I44d6fd3c66fa65cd8bad59968168822df93480dd
Reviewed-on: https://chromium-review.googlesource.com/607690
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492932}
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/exported/BUILD.gn
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp
[delete] https://crrev.com/cc882ce3cda1beecf3c1ad5129b5d11e43b7ac52/third_party/WebKit/Source/core/exported/WebViewBase.cpp
[delete] https://crrev.com/cc882ce3cda1beecf3c1ad5129b5d11e43b7ac52/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/exported/WebViewImpl.h
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/frame/WebViewFrameWidget.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/frame/WebViewFrameWidget.h
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/html/forms/ExternalPopupMenu.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/html/forms/ExternalPopupMenuTest.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/inspector/DevToolsEmulator.h
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.h
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/core/page/ChromeClientImpl.h
[modify] https://crrev.com/eb1f92ff2e35ddedd2ecd563732096c7d4d5c826/third_party/WebKit/Source/modules/exported/WebAXObject.cpp
Project Member

Comment 22 by bugdroid1@chromium.org, Dec 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8f75673c207f2717d14eb60e6f952a89e7c0d76

commit d8f75673c207f2717d14eb60e6f952a89e7c0d76
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Thu Dec 28 07:28:26 2017

Merge SurroundingText into WebSurroundingText

SurroundingText is exposed to outside Blink using a wrapper class
WebSurroundingText. With SurroundingText already changed into POD
type by crrev.com/c/843227, and there is no other usage of
SurroundingText, such wrapping is no longer necessary.

Hence, this patch merges SurroundingText into WebSurroundingText
to simplify the code base.

Bug:  757719 , 731490
Change-Id: Ia1aef602feee3f0e12da828657f183a1621aaa44
Reviewed-on: https://chromium-review.googlesource.com/841629
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526280}
[modify] https://crrev.com/d8f75673c207f2717d14eb60e6f952a89e7c0d76/third_party/WebKit/Source/core/editing/BUILD.gn
[delete] https://crrev.com/ccf8a33bef7c4736b3bfb98e742debf71fd3cfc4/third_party/WebKit/Source/core/editing/SurroundingText.cpp
[delete] https://crrev.com/ccf8a33bef7c4736b3bfb98e742debf71fd3cfc4/third_party/WebKit/Source/core/editing/SurroundingText.h
[modify] https://crrev.com/d8f75673c207f2717d14eb60e6f952a89e7c0d76/third_party/WebKit/Source/core/editing/SurroundingTextTest.cpp
[modify] https://crrev.com/d8f75673c207f2717d14eb60e6f952a89e7c0d76/third_party/WebKit/Source/core/exported/WebSurroundingText.cpp
[modify] https://crrev.com/d8f75673c207f2717d14eb60e6f952a89e7c0d76/third_party/WebKit/public/web/WebSurroundingText.h

Comment 23 by slangley@chromium.org, Jan 24 2018

Owner: ----

Comment 24 by benhenry@google.com, Jan 11

Status: Available (was: Started)
This issue has been marked as started, but has no owner. Making available.

Comment 25 by benhenry@google.com, Jan 11

Status: Untriaged (was: Available)
Does not have a component.
►

Sign in to add a comment