Problems with mojo*.js files not being included as data_deps for content_shell & Layout Tests |
||||||
Issue descriptionThe Layout Tests on Mac need the *.mojo*js files to run correctly. They appear to not being included as a data_dep by the build files and hence when we swarm the Layout Tests for Mac we don't get them included in the isolate. As a temporary work around fix I landed https://codereview.chromium.org/2926843002/ which does the following and makes things work; ---------------------------------------- diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn index 2f2d607..02f6d47 100644 --- a/content/shell/BUILD.gn +++ b/content/shell/BUILD.gn @@ -500,6 +500,9 @@ "@executable_path/../", ] info_plist_target = ":content_shell_plist" + data_deps = [ + ":content_shell_lib", + ] } } else { executable("content_shell") { ---------------------------------------- However, I'm pretty sure this is not the correct fix.
,
Jun 9 2017
,
Jun 9 2017
I think the problem is that the data dependencies of content_shell_lib normally end up as bundle data in the content_shell_framework and don't propagate out into the enclosing targets like they would on Linux. rockot@, yzshen@, I think this is actually the inverse of the problem we were looking at last week, where the dependencies were getting specified even though they weren't needed, though they have the same cause. And, I think the right fix is likely to make //:webkit_layout_tests depend on the generated mojo JS bindings directly.
,
Jun 9 2017
dpranke@'s suggestion in #3 to make it a {data_,}deps of webkit_layout_tests SGTM. The temporary patch doesn't make conceptual sense from a build-system perspective.
,
Oct 17
,
Oct 17
,
Jan 11
Setting defect without priority to Pri-2. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tansell@chromium.org
, Jun 9 2017Components: Blink>LayoutTests
Labels: Test-Layout