Need better tempdir strategy in recipes |
|||||
Issue descriptionCurrently recipes are started with 'tmp_base' and 'cleanup' paths. These have been kind-of organically added, but it's become clear that what we really want is: * tmp_system - a temp dir on the system drive (i.e. same drive as / or C:\) * tmp_build - a temp dir on the build drive (i.e. same drive as start_dir) These paths may be equal if the recipe is running on the system drive. Both paths will: * be empty when the recipe starts * be removed sometime after the recipe ends
,
Jun 9 2017
Recommend keeping "tmp_base" as-is as the system-side temporary directory ("tmp_system" here).
Let's replace "cleanup" with "tmp_build", which is a build-filesystem temporary directory.
,
Jun 9 2017
why not rename tmp_system? It would make it more obvious what its purpose is on initial inspection.
,
Jun 9 2017
er... `why not rename tmp_base to tmp_system`.
,
Jun 9 2017
Thinking just b/c it's referenced a lot.
,
Jun 9 2017
I'm not worried about changing the references. I've become pretty good at that :)
,
Jun 9 2017
From reading the bug description it is still unclear why system temp is needed. Why?
,
Jun 9 2017
Answering for iannucci@, but apparently some Windows programs have the expectation that the tempdir used and exported be on the same filesystem as the user profile.
,
Jun 9 2017
Yes, there are some tests (like the installer tests) that assume they can do same-volume rename operations, and they must install on the system drive (i.e. C:). This is less of a problem but still applicable on linux. "System" is somewhat reductionist, but I think it should be enough to cover our uses for now.
,
Jun 20 2017
,
Jun 20 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 20 2018
,
Oct 19
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by iannucci@chromium.org
, Jun 9 2017