New issue
Advanced search Search tips

Issue 731487 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Need better tempdir strategy in recipes

Project Member Reported by iannucci@chromium.org, Jun 9 2017

Issue description

Currently recipes are started with 'tmp_base' and 'cleanup' paths. These have been kind-of organically added, but it's become clear that what we really want is:
  * tmp_system - a temp dir on the system drive (i.e. same drive as / or C:\)
  * tmp_build - a temp dir on the build drive (i.e. same drive as start_dir)

These paths may be equal if the recipe is running on the system drive. Both paths will:
  * be empty when the recipe starts
  * be removed sometime after the recipe ends


 
On buildbot we currently rely on https://cs.chromium.org/chromium/build/slave/run_slave.py?q=run_slave.py&sq=package:chromium&dr=C&l=168 to clean up unwanted directories in between builds. To this end, we should:
  * Add <build_root>\b\tmp\* to the list of paths to delete in this function
  * Add C:\tmp\* to the list of paths to delete in this function
  * Change {remote,annotated}_run to set 
    * b\tmp\<new_random_dir> as temp_build
    * C:\tmp\<new_random_dir> as temp_system
    * (on linux/mac we'd use <build_root>b/tmp/<random> for both)

Comment 2 by d...@chromium.org, Jun 9 2017

Recommend keeping "tmp_base" as-is as the system-side temporary directory ("tmp_system"  here).

Let's replace "cleanup" with "tmp_build", which is a build-filesystem temporary directory.
why not rename tmp_system? It would make it more obvious what its purpose is on initial inspection.
er... `why not rename tmp_base to tmp_system`.

Comment 5 by d...@chromium.org, Jun 9 2017

Thinking just b/c it's referenced a lot.
I'm not worried about changing the references. I've become pretty good at that :)

Comment 7 by no...@chromium.org, Jun 9 2017

From reading the bug description it is still unclear why system temp is needed. Why?

Comment 8 by d...@chromium.org, Jun 9 2017

Answering for iannucci@, but apparently some Windows programs have the expectation that the tempdir used and exported be on the same filesystem as the user profile.
Yes, there are some tests (like the installer tests) that assume they can do same-volume rename operations, and they must install on the system drive (i.e. C:). This is less of a problem but still applicable on linux.

"System" is somewhat reductionist, but I think it should be enough to cover our uses for now.
Status: Available (was: Untriaged)
Project Member

Comment 11 by sheriffbot@chromium.org, Jun 20 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by s...@google.com, Jun 20 2018

Status: Available (was: Untriaged)
Cc: iannu...@google.com

Sign in to add a comment