We can copy the pattern from Manage Passwords -- search box in the top-right.

Marking as P3 since the old UI did not have a search box.

 Issue 740978  has been merged into this issue.

Re #1, the Manage Passwords page has a similar UX problem in that a user who hits CTRL+F enters a user-experience that doesn't function as they expect. 

If we're going to go the route where Chrome features (Find In Page) don't work with Chrome features (Settings pages), can we at least trap the CTRL+F keystroke on these pages (as Google Docs does) and use it to focus the Search field? Or, better still, could we have some sort of private API for chrome:// pages where they get the keystrokes directly from the Find-in-Page box and suppress its normal behavior?


I filed  Issue 740978  after encountering users complaining about this on Facebook. Their current workaround is to select all of the text on the page and paste it into Notepad.
 :(

chrome://history and chrome://downloads use virtualized lists just like Settings does, and therefore have similar issue with the "Find in page" feature. Note that both those pages do override Ctrl+f to focus the search box. The only way to actually trigger the native "find in page" features is from main Chrome hamburger menu.

So hijacking ctrl+f sounds reasonable to me, for both passwords and search engines (and any other similar lists).

Based on latest discussions with @bettes, we should add a search box just for search engines, similar to the passwords search box.

@bettes: Attaching screencast of proposed search functionality. Couple of questions

1) What should be the placeholder text in the search box? (in the demo I just reused the "search passwords" text temporarily).
2) When one of the three lists is empty, should there be a special message displayed?
3) Should the "Add" button be hidden when a search query exists?

Deleted: search_engines_search.mp4 366 KB

	search_engines_search.mp4 366 KB View Download

Also one more question. Currently I am searching only the search engine name and keyword. The URL is not being searched. Let me know if that is OK.

Personally I think I would prefer it to search the URL as well. For example, if I have a search engine with keyword "HLTB", name "How Long to Beat?" and URL "howlongtobeat.com/search/%s", what happens if I search for "howlongtobeat.com"?

1) What should be the placeholder text in the search box? (in the demo I just reused the "search passwords" text temporarily).
"Search" or "Search engines" sounds fine

2) When one of the three lists is empty, should there be a special message displayed?
"No results" seems reasonable. Can we also add this to Passwords/Cookies?

3) Should the "Add" button be hidden when a search query exists?
We generally don't hide any UI, just rows while filtering. Let's keep the "Add" button for now.

4) Currently I am searching only the search engine name and keyword. The URL is not being searched. Let me know if that is OK.
Let's include the URL when searching.

5) Should the header be shown if there are no results?
No. We should show the table header per-section. We should keep the "Add" button in-line with the section title.

@tbuckley: Updating new screencast where 1-5 above have been addressed. Let me know if there are any further refinements to be made.

Deleted: search_engines_search.mp4 428 KB

	search_engines_search.mp4 428 KB View Download

LGTM! bettes@, do you see any other changes that are needed?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a24060b665c6ed5981cc5427ac6c5fc155a3ba5a

commit a24060b665c6ed5981cc5427ac6c5fc155a3ba5a
Author: dpapad <dpapad@chromium.org>
Date: Wed Aug 02 03:13:46 2017

Settings WebUI: Allow filtering the search engines list.

Bug:  731467 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I785ddcb08e90910c508bc38e7bb2a524de854949
Reviewed-on: https://chromium-review.googlesource.com/595194
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491244}
[modify] https://crrev.com/a24060b665c6ed5981cc5427ac6c5fc155a3ba5a/chrome/app/settings_strings.grdp
[modify] https://crrev.com/a24060b665c6ed5981cc5427ac6c5fc155a3ba5a/chrome/browser/resources/settings/search_engines_page/search_engines_list.html
[modify] https://crrev.com/a24060b665c6ed5981cc5427ac6c5fc155a3ba5a/chrome/browser/resources/settings/search_engines_page/search_engines_list.js
[modify] https://crrev.com/a24060b665c6ed5981cc5427ac6c5fc155a3ba5a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
[modify] https://crrev.com/a24060b665c6ed5981cc5427ac6c5fc155a3ba5a/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
[modify] https://crrev.com/a24060b665c6ed5981cc5427ac6c5fc155a3ba5a/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/a24060b665c6ed5981cc5427ac6c5fc155a3ba5a/chrome/browser/resources/settings/search_page/search_page.js
[modify] https://crrev.com/a24060b665c6ed5981cc5427ac6c5fc155a3ba5a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/a24060b665c6ed5981cc5427ac6c5fc155a3ba5a/chrome/test/data/webui/settings/search_engines_page_test.js

I don't see the search box in Stable v61.0.3163.79. Can we expect this in Stable v62?

 Issue 522284  has been merged into this issue.