New issue
Advanced search Search tips

Issue 731384 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Task

Blocked on:
issue 794085
issue 812896
issue 823870

Blocking:
issue 790709



Sign in to add a comment

Migrate "win_chromium_dbg_ng" to LUCI

Project Member Reported by luci-mig...@appspot.gserviceaccount.com, Jun 9 2017

Issue description

Migrate builder tryserver.chromium.win:win_chromium_dbg_ng to LUCI.

Buildbot: https://ci.chromium.org/buildbot/tryserver.chromium.win/win_chromium_dbg_ng
LUCI: https://ci.chromium.org/buildbucket/luci.chromium.try/win_chromium_dbg_ng

Migration app will be posting updates on changes of the migration status.
For the latest status, see
https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng

Migration app will close this bug when the builder is entirely migrated from Buildbot to LUCI.
 
Status: Available (was: Untriaged)

Comment 2 by no...@chromium.org, Jun 9 2017

Labels: -Restrict-View-Google

Comment 3 by efoo@chromium.org, Aug 24 2017

Do not manually mark this bug as "Fixed" when builder is working as intended (WAI) on LUCI. Migration is not complete until builder is solely on LUCI.

The LUCI migration app will mark the bug status to "Fixed" automatically when the BuildBot builder equivalent is turned down. 
Project Member

Comment 4 by luci-mig...@appspot.gserviceaccount.com, Sep 21 2017

Description: Show this description

Comment 5 by no...@chromium.org, Dec 6 2017

Labels: SchedulingType-Try
Labels: LUCI-Blocker-TaskForce
Owner: jchin...@chromium.org
Status: Assigned (was: Available)

Comment 8 by efoo@chromium.org, Dec 9 2017

Labels: Pri-1

Comment 9 by efoo@chromium.org, Dec 9 2017

Blocking: 790709
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/56f2ea3cc684c5e58c0f4fe9c986fc9535118249

commit 56f2ea3cc684c5e58c0f4fe9c986fc9535118249
Author: Jao-ke Chin-Lee <jchinlee@google.com>
Date: Fri Dec 15 00:54:58 2017

Comment 11 by efoo@chromium.org, Dec 19 2017

Labels: LUCI-M4-S14

Comment 12 by efoo@chromium.org, Dec 19 2017

Labels: LUCI-Blocker-M4

Comment 13 by efoo@chromium.org, Jan 4 2018

Labels: LUCI-M4-S15

Comment 14 by efoo@chromium.org, Jan 23 2018

Labels: LUCI-M4-S16
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39be8832cf39acdcc5b8dada8799c7bf02eb68a1

commit 39be8832cf39acdcc5b8dada8799c7bf02eb68a1
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Wed Jan 24 19:08:32 2018

Add win_chromium_dbg_ng as 5% experiment to CQ.

This is to gather data for the purpose of LUCI migration
and will be removed after enough has been collected.

Bug:  731384 
Change-Id: I78f90a7c76592c4f0a577a9bcac426cf4ca541fb
Reviewed-on: https://chromium-review.googlesource.com/882611
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531636}
[modify] https://crrev.com/39be8832cf39acdcc5b8dada8799c7bf02eb68a1/infra/config/cq.cfg

Comment 16 by efoo@chromium.org, Jan 25 2018

Labels: luci-blocker-migration

Comment 17 by efoo@chromium.org, Jan 30 2018

Labels: -LUCI-Blocker-M4 LUCI-Blocker-CQSets

Comment 18 by efoo@chromium.org, Jan 30 2018

Labels: -luci-blocker-migration
Project Member

Comment 19 by luci-mig...@appspot.gserviceaccount.com, Feb 1 2018

Labels: MigrationStatus-WAI
Status changed to "LUCI WAI" (correctness 100%, speed 121%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 20 by luci-mig...@appspot.gserviceaccount.com, Feb 1 2018

Labels: -MigrationStatus-WAI
Status changed to "Not enough data to analyze" (correctness 0%, speed 0%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
It looks like at the rate of builds coming in and being phased out, we might not reach 50 builds within a week. I'm going to bump the rate to 20% while keeping an eye on swarming pending times.
Bumping to 30%, still watching.

Comment 23 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-Blocker-CQSets LUCI-Chromium-CQSets
Project Member

Comment 24 by luci-mig...@appspot.gserviceaccount.com, Feb 13 2018

Status changed to "LUCI not WAI" (correctness 98%, speed 111%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng

Comment 25 by efoo@chromium.org, Feb 14 2018

Labels: -LUCI-Blocker-TaskForce
Project Member

Comment 26 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a879629a0d8e9b5875fcec597e949c0cd688955a

commit a879629a0d8e9b5875fcec597e949c0cd688955a
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Thu Feb 15 03:06:36 2018

Lower win_chromium_dbg_ng experiment percentage to 2%.

Bug:  731384 
Change-Id: I1385fbece81e7e68f41c41b66aacfb3795c36af7
Reviewed-on: https://chromium-review.googlesource.com/920842
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536936}
[modify] https://crrev.com/a879629a0d8e9b5875fcec597e949c0cd688955a/infra/config/cq.cfg

Project Member

Comment 27 by luci-mig...@appspot.gserviceaccount.com, Feb 20 2018

Status changed to "Not enough data to analyze" (correctness 0%, speed 0%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Blockedon: 794085
Cc: mar...@chromium.org
maruel@, how feasible would it be to increase the timeout?

Builds keep failing at webkit_layout_tests (see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng/, e.g.
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_chromium_dbg_ng/911
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_chromium_dbg_ng/906
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_chromium_dbg_ng/901)

The timestamps add up such that it makes sense that webkit_layout_tests would still be running at the point the timeout kicks in; some earlier steps are taking longer than expected due to capacity issues, but once win_chromium_dbg_ng is fully migrated those should ease. As such, these failures are blocking migration because the app can't collect enough data.
To be clear (following up on tandrii@'s comment in Foundation meeting), increasing the timeout would be for the purposes of /gathering confidence/; the underlying cause for tests overrunning [also on Buildbot] should still be resolved.
Project Member

Comment 30 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbd3ae7baafbd1ebdaf1636787a63e777b84bfc1

commit dbd3ae7baafbd1ebdaf1636787a63e777b84bfc1
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Wed Feb 21 21:45:02 2018

Revert "Lower win_chromium_dbg_ng experiment percentage to 2%."

This reverts commit a879629a0d8e9b5875fcec597e949c0cd688955a.

Reason for revert:

Not enough builds to provide data to the migration app. Lowering to 2% was optimistic.

Original change's description:
> Lower win_chromium_dbg_ng experiment percentage to 2%.
> 
> Bug:  731384 
> Change-Id: I1385fbece81e7e68f41c41b66aacfb3795c36af7
> Reviewed-on: https://chromium-review.googlesource.com/920842
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536936}

TBR=jchinlee@chromium.org,tandrii@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  731384 
Change-Id: I6eb5d7a5424d742e980db885f799049463b262c0
Reviewed-on: https://chromium-review.googlesource.com/929901
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538219}
[modify] https://crrev.com/dbd3ae7baafbd1ebdaf1636787a63e777b84bfc1/infra/config/cq.cfg

Project Member

Comment 31 by luci-mig...@appspot.gserviceaccount.com, Feb 23 2018

Status changed to "LUCI not WAI" (correctness 98%, speed 120%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 32 by luci-mig...@appspot.gserviceaccount.com, Feb 26 2018

Status changed to "Not enough data to analyze" (correctness 0%, speed 0%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 33 by luci-mig...@appspot.gserviceaccount.com, Feb 26 2018

Status changed to "LUCI not WAI" (correctness 98%, speed 124%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 34 by luci-mig...@appspot.gserviceaccount.com, Feb 27 2018

Status changed to "Not enough data to analyze" (correctness 0%, speed 0%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 35 by luci-mig...@appspot.gserviceaccount.com, Feb 28 2018

Labels: MigrationStatus-WAI
Status changed to "LUCI WAI" (correctness 100%, speed 121%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 36 by luci-mig...@appspot.gserviceaccount.com, Feb 28 2018

Labels: -MigrationStatus-WAI
Status changed to "Not enough data to analyze" (correctness 0%, speed 0%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 37 by luci-mig...@appspot.gserviceaccount.com, Mar 6 2018

Status changed to "Low confidence" (correctness 100%, speed 138%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 38 by luci-mig...@appspot.gserviceaccount.com, Mar 8 2018

Status changed to "No data" (correctness 0%, speed 0%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 39 by luci-mig...@appspot.gserviceaccount.com, Mar 12 2018

Status changed to "Low confidence" (correctness 97%, speed 126%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 40 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3d35fe0dd3e0e84500fc330a2dbba3bffd4b0720

commit 3d35fe0dd3e0e84500fc330a2dbba3bffd4b0720
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Fri Mar 23 19:49:52 2018

[led] Let led see archive_layout_test_retry_summary.py.

Bug:  731384 
Change-Id: I3de30e2c431843193c1546a2be94207baa41597d
Reviewed-on: https://chromium-review.googlesource.com/974122
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/3d35fe0dd3e0e84500fc330a2dbba3bffd4b0720/scripts/slave/chromium/.gitattributes

Comment 41 Deleted

Comment 42 Deleted

Project Member

Comment 43 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8478ca4049b9e6863da8461005b49acc4adb6803

commit 8478ca4049b9e6863da8461005b49acc4adb6803
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Fri Mar 23 21:57:45 2018

Increase hard timeout for win_chromium_dbg_ng due to some long-running tests.

win_chromium_dbg_ng has had 176 tests running over 3 hours in the 1000 builds
between 4670 and 3669. Currently, these show up as infra failures rather than
test failures. Increase the hard timeout to 4 hours, as no build in the above
sample exceeded 4 hours.

BUG= 731384 

Change-Id: Iff6dba2ffb43920aa991cfef7fdc4bb6e5773eb4
Reviewed-on: https://chromium-review.googlesource.com/978673
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545577}
[modify] https://crrev.com/8478ca4049b9e6863da8461005b49acc4adb6803/infra/config/global/cr-buildbucket.cfg

Project Member

Comment 44 by luci-mig...@appspot.gserviceaccount.com, Mar 27 2018

Status changed to "LUCI not WAI" (correctness 94%, speed 124%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 45 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/aa54676f20f7276decdc7b3a56cf322d5c183949

commit aa54676f20f7276decdc7b3a56cf322d5c183949
Author: Jao-ke Chin-Lee <jchinlee@google.com>
Date: Thu Mar 29 19:11:36 2018

Project Member

Comment 46 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/28ef6191d9a49906ba5bb4d4a4c99be8f7065a45

commit 28ef6191d9a49906ba5bb4d4a4c99be8f7065a45
Author: Jao-ke Chin-Lee <jchinlee@google.com>
Date: Thu Mar 29 19:14:31 2018

Project Member

Comment 47 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a69b617f352882dc40f2e25947a71c84625eb2b7

commit a69b617f352882dc40f2e25947a71c84625eb2b7
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Thu Mar 29 20:56:29 2018

Ramp up win_chromium_compile_dbg_ng to 10% on LUCI.

Also delete the experimental CQ builder for gathering win_chromium_dbg_ng data.

BUG= 731547 , 731384 

Change-Id: I93b18ba53bc0a658c659d4e69ea1aaacdd4c12d3
Reviewed-on: https://chromium-review.googlesource.com/986666
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546951}
[modify] https://crrev.com/a69b617f352882dc40f2e25947a71c84625eb2b7/infra/config/branch/cq.cfg

Project Member

Comment 48 by bugdroid1@chromium.org, Mar 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/99b63a95f047561309ba7ccea6ed3e232c232a00

commit 99b63a95f047561309ba7ccea6ed3e232c232a00
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Sat Mar 31 02:53:30 2018

Decommission some win Buildbot machines.

CI builders:
+ Win Builder (dbg): build22-m1
+ Win7 Tests (dbg)(1): vm934-m1

Try builders:
+ win_chromium_compile_dbg_ng: (70) all but vm{[399, 407)}-m4
+ win_chromium_dbg_ng: (5) vm{44, 166, 171, 176, 177}-m4

*vm{[156, 164), [182, 184), [196, 199), [201, 204),
    [227, 229), [231, 234), [235, 252), [318, 339),
    [346, 348), [382, 384), [422, 425), [426, 430)}-m4

BUG=790709,790645, 731547 , 731384 

Change-Id: I3272dd952e6015cffe597e132a6b6fc8555453d6
Reviewed-on: https://chromium-review.googlesource.com/989295
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>

[modify] https://crrev.com/99b63a95f047561309ba7ccea6ed3e232c232a00/masters/master.chromium.win/master_win_cfg.py
[modify] https://crrev.com/99b63a95f047561309ba7ccea6ed3e232c232a00/masters/master.tryserver.chromium.win/slaves.cfg
[modify] https://crrev.com/99b63a95f047561309ba7ccea6ed3e232c232a00/tests/masters_recipes_test.py
[modify] https://crrev.com/99b63a95f047561309ba7ccea6ed3e232c232a00/masters/master.chromium.win/slaves.cfg
[modify] https://crrev.com/99b63a95f047561309ba7ccea6ed3e232c232a00/masters/master.tryserver.chromium.win/master.cfg

Project Member

Comment 49 by bugdroid1@chromium.org, Mar 31 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/346386703dfdeeb334bbe476075a7c4561544c52

commit 346386703dfdeeb334bbe476075a7c4561544c52
Author: Andrii Shyshkalov <tandrii@google.com>
Date: Sat Mar 31 02:58:22 2018

Project Member

Comment 50 by luci-mig...@appspot.gserviceaccount.com, Mar 31 2018

Status changed to "Low confidence" (correctness 97%, speed 116%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Status: Fixed (was: Available)
Project Member

Comment 52 by luci-mig...@appspot.gserviceaccount.com, Apr 6 2018

Status changed to "No data" (correctness 0%, speed 0%)
For the latest status, see https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chromium_dbg_ng
Project Member

Comment 53 by luci-mig...@appspot.gserviceaccount.com, May 10 2018

Labels: MigrationStatus-WAI
Status changed to "Migrated"
Labels: LUCI-Chromium-Manual
Description: Show this description

Sign in to add a comment