New issue
Advanced search Search tips

Issue 731383 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 24
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Task



Sign in to add a comment

Migrate "win_chrome_official" to LUCI (Internal)

Project Member Reported by luci-mig...@appspot.gserviceaccount.com, Jun 9 2017

Issue description

Migrate builder tryserver.chromium.win:win_chrome_official to LUCI.

Buildbot: https://ci.chromium.org/buildbot/tryserver.chromium.win/win_chrome_official
LUCI: https://ci.chromium.org/buildbucket/luci.chromium.try/win_chrome_official

Migration app will be posting updates on changes of the migration status.
For the latest status, see
https://luci-migration.appspot.com/masters/tryserver.chromium.win/builders/win_chrome_official

Migration app will close this bug when the builder is entirely migrated from Buildbot to LUCI.
 
Status: Available (was: Untriaged)

Comment 2 by no...@chromium.org, Jun 9 2017

Labels: -Restrict-View-Google

Comment 3 by efoo@chromium.org, Aug 24 2017

Do not manually mark this bug as "Fixed" when builder is working as intended (WAI) on LUCI. Migration is not complete until builder is solely on LUCI.

The LUCI migration app will mark the bug status to "Fixed" automatically when the BuildBot builder equivalent is turned down. 
Project Member

Comment 4 by luci-mig...@appspot.gserviceaccount.com, Sep 21 2017

Description: Show this description

Comment 5 by no...@chromium.org, Dec 6 2017

Labels: SchedulingType-Try

Comment 6 by efoo@chromium.org, Feb 21 2018

Labels: LUCI-Chromium Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/801017e14269364a104fbe1fbcddf4049bc87830

commit 801017e14269364a104fbe1fbcddf4049bc87830
Author: Ryan Tseng <hinoka@google.com>
Date: Wed Jun 13 00:47:22 2018

Comment 8 by hinoka@chromium.org, Jun 13 2018

Labels: LUCI-Mirror-Purple
checks out src-internal, this probably needs to move to luci.chrome.try

Comment 9 by efoo@chromium.org, Jun 19 2018

Owner: dpranke@chromium.org
Status: Assigned (was: Available)
Assigning to dpranke@ to take a look at the src-internal checkout. Should we move this?
Yes, it'll need to move when we move the chromium.chrome waterfall.
Labels: LUCI-Chromium-Manual
Labels: -LUCI-Chromium -LUCI-Mirror-Purple -LUCI-Chromium-Manual LUCI-ChromeInternal
Moved to LUCI-ChromeInternal milestone and removing Chromium milestone tags. 
Blockedon: 877693
Blockedon: -877693
Summary: Migrate "win_chrome_official" to LUCI (Internal) (was: Migrate "win_chrome_official" to LUCI)
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/760381bd20aa32de4e490d6250e3369773919f5b

commit 760381bd20aa32de4e490d6250e3369773919f5b
Author: Eric Foo <efoo@chromium.org>
Date: Sat Aug 25 00:14:57 2018

Unmirror win_chrome_official to move to internal instead.

Bug:  731383 
Change-Id: Id563bd36de50c7685a524336906fc8542d1c6f51
Reviewed-on: https://chromium-review.googlesource.com/1188451
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586073}
[modify] https://crrev.com/760381bd20aa32de4e490d6250e3369773919f5b/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/760381bd20aa32de4e490d6250e3369773919f5b/infra/config/global/luci-milo.cfg

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 25

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/2fdf38dfa532bad52599ef89e33e1e0f1f1d4201

commit 2fdf38dfa532bad52599ef89e33e1e0f1f1d4201
Author: Eric Foo <efoo@chromium.org>
Date: Sat Aug 25 00:35:58 2018

Owner: mmoss@chromium.org
Move to official.desktop.continuous as per crbug.com/843835. Reassigned to mmoss@ 
Labels: -LUCI-ChromeInternal LUCI-Official
Is this a trybot, and meant to continue to be a trybot? If so, it doesn't really belong on official.desktop.continuous, and I'm not even sure that would work if we wanted it to. If it's not meant to continue as a trybot, then what purpose would it serve that the existing official.desktop.continuous bots don't already?
Labels: LUCI-Official-Manual LUCI-Mig-Ops
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/7789a6cae21728b0ad6f48ec75f1c79e8a29c6ee

commit 7789a6cae21728b0ad6f48ec75f1c79e8a29c6ee
Author: Michael Moss <mmoss@google.com>
Date: Fri Sep 28 23:21:27 2018

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 29

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/064703b591daf1fb2c14d7236e28d428b5221f0b

commit 064703b591daf1fb2c14d7236e28d428b5221f0b
Author: Eric Foo <efoo@chromium.org>
Date: Sat Sep 29 00:43:00 2018

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/33b51e3850f8b73495a307550652368d3c5987b3

commit 33b51e3850f8b73495a307550652368d3c5987b3
Author: Michael Moss <mmoss@google.com>
Date: Fri Oct 05 16:40:06 2018

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/37377c3e485a3167b07937568060815767bad55e

commit 37377c3e485a3167b07937568060815767bad55e
Author: Michael Moss <mmoss@google.com>
Date: Fri Oct 05 20:04:28 2018

Project Member

Comment 27 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55d6d53d9bf6a70b96041664632fce221f21d55d

commit 55d6d53d9bf6a70b96041664632fce221f21d55d
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Fri Oct 05 21:46:25 2018

Roll src-internal 89a5e559a7c9..37377c3e485a (3 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/89a5e559a7c9..37377c3e485a


Created with:
  gclient setdep -r src-internal@37377c3e485a

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:731383 
TBR=mmoss@chromium.org

Change-Id: I679d4bf4d3c61b3d949444d25098d30f18934436
Reviewed-on: https://chromium-review.googlesource.com/c/1265053
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597317}
[modify] https://crrev.com/55d6d53d9bf6a70b96041664632fce221f21d55d/DEPS

Project Member

Comment 28 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/104a27b8ed6d7b1ebed587285bd1bf07eea48d83

commit 104a27b8ed6d7b1ebed587285bd1bf07eea48d83
Author: Michael Moss <mmoss@google.com>
Date: Mon Oct 08 17:19:31 2018

Project Member

Comment 29 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c63d464770c2546973eae5af050e7d553486d229

commit c63d464770c2546973eae5af050e7d553486d229
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Mon Oct 08 18:51:40 2018

Roll src-internal 3c5695530095..104a27b8ed6d (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c5695530095..104a27b8ed6d


Created with:
  gclient setdep -r src-internal@104a27b8ed6d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:731383 
TBR=mmoss@chromium.org

Change-Id: I7f3bb5b4f6c7b3f64bf4a6488cad1f6326a4631d
Reviewed-on: https://chromium-review.googlesource.com/c/1268816
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597631}
[modify] https://crrev.com/c63d464770c2546973eae5af050e7d553486d229/DEPS

Project Member

Comment 31 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/702767e28787da90b47e0d319c08be5e0029fb99

commit 702767e28787da90b47e0d319c08be5e0029fb99
Author: Michael Moss <mmoss@google.com>
Date: Tue Oct 09 00:56:52 2018

Partial revert of e99fbf7f290fb18f50677c997596fa462c1340a6.

This removes usage of the new 'chrome_official_internal' config, since
it's not setting the path properly to the new mb_config.pyl in
src-internal.

BUG= 731383 
R=jbudorick@google.com

Change-Id: I1d3562917f6eaa7198b1637fdde27e7cfc72684e
Reviewed-on: https://chromium-review.googlesource.com/c/1270023
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>

[modify] https://crrev.com/702767e28787da90b47e0d319c08be5e0029fb99/scripts/slave/recipe_modules/chromium_tests/chromium_chrome.py
[modify] https://crrev.com/702767e28787da90b47e0d319c08be5e0029fb99/scripts/slave/recipe_modules/chromium/config.py

Project Member

Comment 32 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e7a1f29bcc3fa11bf2a8cd96de966853715db78

commit 7e7a1f29bcc3fa11bf2a8cd96de966853715db78
Author: Michael Moss <mmoss@chromium.org>
Date: Tue Oct 09 05:02:34 2018

Add tryserver.chrome.win mb config.

BUG= 731383 

Change-Id: I7ea98cb840e0f710db4b03af0948879b03e004bf
Reviewed-on: https://chromium-review.googlesource.com/c/1265935
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597801}
[modify] https://crrev.com/7e7a1f29bcc3fa11bf2a8cd96de966853715db78/tools/mb/mb_config.pyl

Project Member

Comment 33 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/685db90ebb4a438453785e45f0924cc9ad9b1a12

commit 685db90ebb4a438453785e45f0924cc9ad9b1a12
Author: Michael Moss <mmoss@google.com>
Date: Tue Oct 09 18:58:47 2018

Project Member

Comment 34 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a93abe5b8542052e5a9bc0c341cc6c26f0042107

commit a93abe5b8542052e5a9bc0c341cc6c26f0042107
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Tue Oct 09 20:02:50 2018

Roll src-internal eaaab16cdf0a..685db90ebb4a (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eaaab16cdf0a..685db90ebb4a


Created with:
  gclient setdep -r src-internal@685db90ebb4a

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:731383 
TBR=mmoss@chromium.org

Change-Id: Ib0b5548b9645fb96345743b309f43198c73f969d
Reviewed-on: https://chromium-review.googlesource.com/c/1271367
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598054}
[modify] https://crrev.com/a93abe5b8542052e5a9bc0c341cc6c26f0042107/DEPS

Tryjobs work with:

git cl try -B luci.chrome.try -b win_chrome_official

Still trying to figure out why the builder is not showing up in the tryjob selection dialog (https://crrev.com/c/1269113#message-089b514bbd343e1d08e23ca6b28259afa7f066fc)
Project Member

Comment 36 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/f35cbd7c86d61a0afaf7ab380ad21759621e116e

commit f35cbd7c86d61a0afaf7ab380ad21759621e116e
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Oct 10 02:23:40 2018

[buildbucket] Acquire access token lower in the stack

Move access token acquisition call lower in the stack, right before
making an RPC.

Bug:  731383 
Change-Id: Idce1b8faae3a0988f994d54ee7ccfd203da6ab33
Reviewed-on: https://chromium-review.googlesource.com/c/1272221
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/f35cbd7c86d61a0afaf7ab380ad21759621e116e/src/main/resources/static/cr-buildbucket-client.js
[modify] https://crrev.com/f35cbd7c86d61a0afaf7ab380ad21759621e116e/src/main/resources/static/cr-buildbucket-view.js

Project Member

Comment 37 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98ea939cd3624ef62d5cf3b853164bc665a7c9d8

commit 98ea939cd3624ef62d5cf3b853164bc665a7c9d8
Author: Michael Moss <mmoss@chromium.org>
Date: Thu Oct 11 18:29:40 2018

Remove win_chrome_official from tryserver.chromium.win.

This has been migrated to tryserver.chrome.win on LUCI.

BUG= 731383 

Change-Id: Ic74dcc5ec53ce4b44b461a182caf91a8a934f012
Reviewed-on: https://chromium-review.googlesource.com/c/1271580
Reviewed-by: Eric Foo <efoo@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598856}
[modify] https://crrev.com/98ea939cd3624ef62d5cf3b853164bc665a7c9d8/tools/mb/mb_config.pyl

Status: Fixed (was: Assigned)
The new builder is here:

https://ci.chromium.org/p/chrome/builders/luci.chrome.try/win_chrome_official

I think the old bot (vm192-m4) still needs to be decommissioned, but everything else should be done.
Project Member

Comment 40 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c2d1e1f816324ce4cffa819fad3590e74e36b9a

commit 0c2d1e1f816324ce4cffa819fad3590e74e36b9a
Author: Michael Moss <mmoss@chromium.org>
Date: Mon Oct 29 18:00:21 2018

Remove bots which have (or will) move to internal builders.

- win_chrome_official moved to luci.chrome.try
- chromium.chrome bots are moving to luci.chrome.ci

R=hinoka@chromium.org

Bug: 790153,790158,790159,790163, 731383 
Change-Id: Ida6dbf9cc2b7dd6d7dcd944e641863443e562946
Reviewed-on: https://chromium-review.googlesource.com/c/1302862
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603555}
[modify] https://crrev.com/0c2d1e1f816324ce4cffa819fad3590e74e36b9a/infra/config/global/luci-milo.cfg

Description: Show this description

Sign in to add a comment