New issue
Advanced search Search tips

Issue 731363 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Task



Sign in to add a comment

Migrate "mac_chromium_asan_rel_ng" to LUCI

Project Member Reported by luci-mig...@appspot.gserviceaccount.com, Jun 9 2017

Issue description

Migrate builder tryserver.chromium.mac:mac_chromium_asan_rel_ng to LUCI.

Buildbot: https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_asan_rel_ng
LUCI: https://ci.chromium.org/buildbucket/luci.chromium.try/mac_chromium_asan_rel_ng

Migration app will be posting updates on changes of the migration status.
For the latest status, see
https://luci-migration.appspot.com/masters/tryserver.chromium.mac/builders/mac_chromium_asan_rel_ng

Migration app will close this bug when the builder is entirely migrated from Buildbot to LUCI.
 
Status: Available (was: Untriaged)

Comment 2 by no...@chromium.org, Jun 9 2017

Labels: -Restrict-View-Google

Comment 3 by efoo@chromium.org, Aug 24 2017

Do not manually mark this bug as "Fixed" when builder is working as intended (WAI) on LUCI. Migration is not complete until builder is solely on LUCI.

The LUCI migration app will mark the bug status to "Fixed" automatically when the BuildBot builder equivalent is turned down. 
Project Member

Comment 4 by luci-mig...@appspot.gserviceaccount.com, Sep 21 2017

Description: Show this description

Comment 5 by no...@chromium.org, Dec 6 2017

Labels: SchedulingType-Try

Comment 6 by efoo@chromium.org, Feb 21 2018

Labels: LUCI-Chromium Pri-1

Comment 7 by hinoka@chromium.org, Jun 21 2018

Owner: hinoka@chromium.org
Status: Started (was: Available)
Labels: LUCI-Chromium-Mass

Comment 9 Deleted

Builder is marked as flipped, but there's some build weirdness due to conflicting BuildIDs. Please verify. 

Notice that Buildbot builds have a number of incorrect data. 
Owner: efoo@chromium.org
Status: Untriaged (was: Started)
Checked a couple of the buildbot jobs, they all have similar buildbucket fields, eg:
{"build": {"bucket": "master.tryserver.chromium.mac", "created_by": "user:rnk@chromium.org", "created_ts": "1535575852508520", "id": "8936825730839300672", "lease_key": "1844584122", "tags": ["builder:mac_chromium_asan_rel_ng", "buildset:patch/gerrit/chromium-review.googlesource.com/1194698/8", "master:tryserver.chromium.mac", "user_agent:git_cl_try"]}}	

This means they're likely being triggered via:

git cl try -m master.trysever.chromium.mac -b mac_chromium_asan_rel_ng

users now need to run:

git cl try -B luci.chromium.try -b mac_chromium_asan_rel_ng

This is the same with other luci builders.  It just happens that this builder was online.  This buildbot builder is safe to take offline.
Status: Assigned (was: Untriaged)
Looks like updating_clang documentation points to triggering the Buildbot builder. I am updating this as well in my CLs. Turning this down now. 
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11fc8a17c38d3f16196fa577c8ba9b9a713a198d

commit 11fc8a17c38d3f16196fa577c8ba9b9a713a198d
Author: Eric Foo <efoo@chromium.org>
Date: Fri Aug 31 23:14:33 2018

Update mention of mac_chromium_asan_rel_ng to trigger LUCI builder

Bug:  731363 
Change-Id: I9506337b62d6a98eba462520cdf545a6d58f62b5
Reviewed-on: https://chromium-review.googlesource.com/1199821
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588203}
[modify] https://crrev.com/11fc8a17c38d3f16196fa577c8ba9b9a713a198d/docs/updating_clang.md

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b4085e15c5390f1b9dcd2016c9b58f391fd070a8

commit b4085e15c5390f1b9dcd2016c9b58f391fd070a8
Author: Eric Foo <efoo@chromium.org>
Date: Sat Sep 01 00:19:47 2018

Remove migrated tryserver.chromium.mac builders

- mac_chromium_archive_rel_ng
- mac_chromium_asan_rel_ng

Bug:731363,  731356 
Change-Id: Ie2109fb2321742d88e47a120f462322807da2130
Reviewed-on: https://chromium-review.googlesource.com/1200287
Commit-Queue: Eric Foo <efoo@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/b4085e15c5390f1b9dcd2016c9b58f391fd070a8/masters/master.tryserver.chromium.mac/master.cfg
[modify] https://crrev.com/b4085e15c5390f1b9dcd2016c9b58f391fd070a8/masters/master.tryserver.chromium.mac/slaves.cfg
[modify] https://crrev.com/b4085e15c5390f1b9dcd2016c9b58f391fd070a8/tests/masters_recipes_test.py

Status: Fixed (was: Assigned)
Removed builders from Buildbot and restarted master. 
Description: Show this description

Sign in to add a comment