New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 731350 link

Starred by 2 users
Status: WontFix
Owner:
█ imch...@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
jmukthavaram@chromium.org
mfo...@chromium.org
btolsch@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router UI] "Cast desktop" is shown instead of "Cast to" on dialog open when there are no sinks

Project Member Reported by imch...@chromium.org, Jun 8 2017 
Steps to repro:

1) Ensure cloud is enabled.
2) Ensure there are no devices.
3) Open MR dialog.

Actual: "Cast desktop" is shown at the top.
Observed: "Cast to" is shown at the top.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfc69988626f677be76ad509a0dbe47d8a8ecc54

commit dfc69988626f677be76ad509a0dbe47d8a8ecc54
Author: imcheng <imcheng@chromium.org>
Date: Fri Jun 09 01:44:27 2017

[Media Router UI] Fix pseudo sink logic for cast modes.

This fixes an issue where "Cast desktop" is shown in the dialog when
there are no sinks except for the pseudo sink (which isn't shown).

BUG= 731350 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2930983003
Cr-Commit-Position: refs/heads/master@{#478158}

[modify] https://crrev.com/dfc69988626f677be76ad509a0dbe47d8a8ecc54/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/dfc69988626f677be76ad509a0dbe47d8a8ecc54/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js

Comment 2 by sko...@chromium.org, Jun 12 2017

Labels: M-61
Status: Assigned (was: Untriaged)
Derek is this fixed now?

Comment 3 by jmukthavaram@chromium.org, Jun 13 2017

Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
imcheng@,
Tested this issue on Windows 7,Mac 10.12.5 & Ubuntu 14.04 using chrome#61.0.3128.0 & earlier version-61.0.3124.0.
Observed 'Cast to' option is shown on top in MR Dialog.
Please find the attached screen shot & confirm the expected behavior & fix on the same.

Thanks in advance..!!
731350.PNG
160 KB View Download

Comment 4 by imch...@chromium.org, Jun 13 2017

Status: Fixed (was: Assigned)
jmukthavaram@: This is working as intneded; the patch in c#1 fixed the issue.

Comment 5 by manoranj...@chromium.org, Jun 13 2017

Labels: -Needs-Feedback
imcheng@, thank you for the confirmation!

Comment 6 by jmukthavaram@chromium.org, Jun 14 2017

Status: WontFix (was: Fixed)
As per comment#4, marking this issue as 'Wontfix'.
Thanks..!!
►

Sign in to add a comment