New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731349 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Log permission metrics broken down by user engagement

Project Member Reported by benwells@chromium.org, Jun 8 2017

Issue description

This should basically log a user engagement histogram for all the different permission actions.

Tim - is this something you could look at?
 
Cc: -timloh@chromium.org
Owner: timloh@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/102eac87872ad8b399aeec59422e4f270826563f

commit 102eac87872ad8b399aeec59422e4f270826563f
Author: timloh <timloh@chromium.org>
Date: Fri Jul 21 03:55:09 2017

Log site engagement scores for permission actions

This patch adds histograms for tracking site engagement scores for
permission prompts, Permissions.Engagement.[Action].[Permission].

BUG= 731349 

Review-Url: https://codereview.chromium.org/2952003003
Cr-Commit-Position: refs/heads/master@{#488573}

[modify] https://crrev.com/102eac87872ad8b399aeec59422e4f270826563f/chrome/browser/permissions/mock_permission_request.cc
[modify] https://crrev.com/102eac87872ad8b399aeec59422e4f270826563f/chrome/browser/permissions/permission_request.cc
[modify] https://crrev.com/102eac87872ad8b399aeec59422e4f270826563f/chrome/browser/permissions/permission_request.h
[modify] https://crrev.com/102eac87872ad8b399aeec59422e4f270826563f/chrome/browser/permissions/permission_request_manager.cc
[modify] https://crrev.com/102eac87872ad8b399aeec59422e4f270826563f/chrome/browser/permissions/permission_request_manager.h
[modify] https://crrev.com/102eac87872ad8b399aeec59422e4f270826563f/chrome/browser/permissions/permission_request_manager_unittest.cc
[modify] https://crrev.com/102eac87872ad8b399aeec59422e4f270826563f/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/102eac87872ad8b399aeec59422e4f270826563f/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/102eac87872ad8b399aeec59422e4f270826563f/tools/metrics/histograms/histograms.xml

Comment 3 by timloh@chromium.org, Jul 24 2017

Status: Fixed (was: Assigned)
Looks like the CL missed 61 by a few hours, oh well :(
If it's a simple CL for metrics purposes, I'd still consider merging to M61 at this stage to be valuable.
Yep, please merge.

Comment 6 by timloh@chromium.org, Jul 25 2017

Labels: Merge-Request-61
Status: Started (was: Fixed)
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 26 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 26 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ba12ce8801c426cf2617142880528311ddfceb3

commit 7ba12ce8801c426cf2617142880528311ddfceb3
Author: Timothy Loh <timloh@chromium.org>
Date: Wed Jul 26 05:10:18 2017

Log site engagement scores for permission actions

This patch adds histograms for tracking site engagement scores for
permission prompts, Permissions.Engagement.[Action].[Permission].

BUG= 731349 
TBR=timloh@chromium.org

(cherry picked from commit 102eac87872ad8b399aeec59422e4f270826563f)

Review-Url: https://codereview.chromium.org/2952003003
Cr-Original-Commit-Position: refs/heads/master@{#488573}
Change-Id: I4b10ae633ba54e6f3c2af22058af95a2a55391ab
Reviewed-on: https://chromium-review.googlesource.com/584561
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#53}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/7ba12ce8801c426cf2617142880528311ddfceb3/chrome/browser/permissions/mock_permission_request.cc
[modify] https://crrev.com/7ba12ce8801c426cf2617142880528311ddfceb3/chrome/browser/permissions/permission_request.cc
[modify] https://crrev.com/7ba12ce8801c426cf2617142880528311ddfceb3/chrome/browser/permissions/permission_request.h
[modify] https://crrev.com/7ba12ce8801c426cf2617142880528311ddfceb3/chrome/browser/permissions/permission_request_manager.cc
[modify] https://crrev.com/7ba12ce8801c426cf2617142880528311ddfceb3/chrome/browser/permissions/permission_request_manager.h
[modify] https://crrev.com/7ba12ce8801c426cf2617142880528311ddfceb3/chrome/browser/permissions/permission_request_manager_unittest.cc
[modify] https://crrev.com/7ba12ce8801c426cf2617142880528311ddfceb3/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/7ba12ce8801c426cf2617142880528311ddfceb3/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/7ba12ce8801c426cf2617142880528311ddfceb3/tools/metrics/histograms/histograms.xml

Comment 9 by timloh@chromium.org, Jul 26 2017

Status: Fixed (was: Started)

Sign in to add a comment