New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731344 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Add CIDB build ID to TKO job keyvals

Project Member Reported by nya@chromium.org, Jun 8 2017

Issue description

Let us add CIDB build ID to TKO job keyvals so that we can associate test results with a buildbot run that triggered them.

Actually CIDB build ID is already in TKO job keyvals as |datastore_parent_key|, but it's not supposed to be parsed.

 

Comment 1 by nya@chromium.org, Jun 9 2017

Owner: nya@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/4b101b04bc7395938d65c3e71522e6f0caf91b24

commit 4b101b04bc7395938d65c3e71522e6f0caf91b24
Author: Shuhei Takahashi <nya@chromium.org>
Date: Fri Jun 09 22:33:38 2017

cbuildbot: Record build IDs in TKO job keyvals.

BUG= chromium:731344 
TEST=bin/cbuildbot --remote -g 527860 --hwtest link-paladin
     # TKO test entries have new keyvals

Change-Id: I28f951b0d318d0e43aea8fbfddaf8e3d4924b3f2
Reviewed-on: https://chromium-review.googlesource.com/527860
Commit-Ready: Shuhei Takahashi <nya@chromium.org>
Tested-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/4b101b04bc7395938d65c3e71522e6f0caf91b24/lib/constants.py
[modify] https://crrev.com/4b101b04bc7395938d65c3e71522e6f0caf91b24/cbuildbot/stages/test_stages.py

Comment 3 by nya@chromium.org, Jun 13 2017

Status: Fixed (was: Started)

Comment 4 by nya@chromium.org, Jun 14 2017

Status: Started (was: Fixed)
Hmm, I realized this adds keyvals to suite jobs only. It's useful to add them to individual test jobs too.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f8659c6b5db4ec3baaa7f1f5b06e974e26bd7b21

commit f8659c6b5db4ec3baaa7f1f5b06e974e26bd7b21
Author: Shuhei Takahashi <nya@chromium.org>
Date: Fri Jun 16 08:49:27 2017

dynamic_suite: Inherit CIDB keyvals.

Make some keyvals inherited from a suite job to test jobs.

Also fixes pylint errors needed to pass presubmit checks.

BUG= chromium:731344 
TEST=utils/unittest_suite.py
TEST=pylint

Change-Id: I62160cd9d697dd48ada6c4b39257262b6a366ec6
Reviewed-on: https://chromium-review.googlesource.com/535262
Commit-Ready: Shuhei Takahashi <nya@chromium.org>
Tested-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/f8659c6b5db4ec3baaa7f1f5b06e974e26bd7b21/server/cros/dynamic_suite/suite.py
[modify] https://crrev.com/f8659c6b5db4ec3baaa7f1f5b06e974e26bd7b21/server/cros/dynamic_suite/suite_unittest.py
[modify] https://crrev.com/f8659c6b5db4ec3baaa7f1f5b06e974e26bd7b21/server/cros/dynamic_suite/constants.py

Comment 6 by nya@chromium.org, Jul 5 2017

Status: Fixed (was: Started)
Manually verified that a test job triggered by a paladin has cidb_build_id keyval.

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment