New issue
Advanced search Search tips

Issue 731335 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: 2019-07-09
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

use_thin_lto affects host builds

Project Member Reported by yunlian@chromium.org, Jun 8 2017

Issue description

When setting use_thin_lto=true, it passes -flto=thin to host builds.
Ideally, this setting should only affect target.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/020810437a3dfa07159429ec1799a840e5d44fe0

commit 020810437a3dfa07159429ec1799a840e5d44fe0
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Jun 21 02:30:18 2017

chromeos-chrome: change ar_host if use=thinlto is set.

The USE="thinlto" applies '-flto=thin' to host packages. So we
need fix AR_host and LD_host.

BUG=chromium:731335
TEST=USE="thinlto" emerge-terra chromeos-chrome builds.

Change-Id: Ib98efd9894994dade7770c0706d438bd29626eb2
Reviewed-on: https://chromium-review.googlesource.com/538819
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/020810437a3dfa07159429ec1799a840e5d44fe0/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/34971ec1fed71089299fa579b915d2d1148f8ad9

commit 34971ec1fed71089299fa579b915d2d1148f8ad9
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Aug 04 02:23:21 2017

chromeos-chrome: use clang wrapper for host.

By default, it uses 'clang' as the host compiler when USE="clang"
is set. We have our own host wrapper for clang, so it makes sense
to use that instead.

BUG=chromium:731335
TEST=cbuildbot amd64-llvm-next-toolchain

Change-Id: I1eadb707d88b6ac0a3a434088836f9ac688048ea
Reviewed-on: https://chromium-review.googlesource.com/598450
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/34971ec1fed71089299fa579b915d2d1148f8ad9/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Labels: Pri-3
NextAction: 2019-07-09
Downgrading P2s that haven't been modified in more than 6 months, which have no component or owner.

Sign in to add a comment