We should disable it (at least for v1). Due to the icon row footer I think that making scrubbing work correctly would be a fair amount of work.

Sounds good for v1 and then we can file another bug for fixing it.

Issue 735061 has been merged into this issue.

huayinz@ - will you please take a look at this for M61? The AppMenuDragHelper controls menu scrubbing. When Chrome Home is enabled, we should disable the AppMenuDragHelper. AppMenuHandler owns the drag helper.

The AppMenuDragHelper doesn't perform dragging on chrome home even if it is enabled, so I think we don't need to disable it (I tried disabling it and the behavior stays the same)?

Thanks for checking this out. +ktam@ fyi.

If disabling results in no change in behavior, I think we can leave the code as is and fix scrubbing post-launch.

While scrubbing doesn't work, the menu shows up on touch down which still looks weird to me.  You can still see flashes of the menu if you medium press on the menu and then drag up.  I think we should make the up event be the only thing to trigger the menu showing in chrome home land (unless we fix scrubbing)

The menu showing up on touch down is issue 706253, which has to do with how touch events on the bottom toolbar are handled. I agree that we should fix that for beta/stable experimentation.

I re-read Matt's comments on that issue, and I think we can merge the two bugs. I did a little investigation based on Ted's comment in  issue 731330 . AppMenuButtonHelper shows the app menu on the ACTION_DOWN touch event. We could wait ACTION_UP or use an onClick listener instead of onTouch when Chrome Home is enabled.

huayinz@, will you please investigate?

Issue 706253 has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2aafcd2b47b113a5b198424da910a43cd568a364

commit 2aafcd2b47b113a5b198424da910a43cd568a364
Author: Becky Zhou <huayinz@chromium.org>
Date: Wed Jun 28 15:55:20 2017

Disable touch down in chrome home

+ Add check in AppMenuButtonHelper whether bottom toolbar exists

Before: app menu shows on touch down the menu button in chrome home
Now: app menu in top toolbar and custom toolbar stays the same,
       the one in chrome home is triggered only on press

BUG= 731330 

Change-Id: I67fd9039a4dc10c12a7fc742427e3966c523a7f8
Reviewed-on: https://chromium-review.googlesource.com/550556
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483006}
[modify] https://crrev.com/2aafcd2b47b113a5b198424da910a43cd568a364/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java
[modify] https://crrev.com/2aafcd2b47b113a5b198424da910a43cd568a364/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/2aafcd2b47b113a5b198424da910a43cd568a364/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

Closing this out as menu scrubbing is disabled. We can file a separate bug to add support for menu scrubbing in Chrome Home.