Improve animation when dismissing Chrome Home as new tab |
||||
Issue descriptionWhen we dismiss Chrome Home (e.g. by dragging or back button) when it is an NTP, the toolbar animation could likely be better since it fades from light to dark once closed. Note: It is especially bad in the toolbar button condition as we pull in the Chrome Home button but it doesn't exist in the tab switcher toolbar.
,
Jun 12 2017
Got it. I'll keep it as P2 for now to see if Chris has any thoughts about better animations and then we can reprioritize once we have a better idea of what we want. (e.g. not animating in the Chrome Home button in the button-trigger condition)
,
Jun 13 2017
Can we disable the sliding the toolbar buttons when Chrome Home is the NTP?
,
Jun 13 2017
The toolbar buttons need to be shown when going from NTP -> tab switcher and NTP -> regular tab, so I'm not sure what disabling the animation would help with?
,
Jun 13 2017
We would disable sliding in the toolbar buttons when going from NTP to tab switcher since they are visually different.
,
Jun 13 2017
The tab switcher toolbar and regular toolbar are the same Android View (long-term we've been talking about changing this but it's out-of-scope for M61), so we can't just disable the toolbar buttons sliding to achieve the right visual effect. We would need to write more custom animation code.
,
Jun 15 2017
Ah I see. So we can't just cross fade from Chrome Home to tab switcher toolbar as we do with the rest of the toolbar? If so, happy to de-pri this one to P3.
,
Jun 15 2017
Unfortunately we currently cannot. In an in-flight patch I am starting the transition from the normal toolbar to the tab switcher toolbar sooner so that it feels a bit less abrupt so hopefully that takes care of the "P2" polish and further improvements can be "P3".
,
Aug 10 2017
,
Mar 30 2018
The Chrome Home experiment has ended; closing obsolete bug. |
||||
►
Sign in to add a comment |
||||
Comment 1 by twelling...@chromium.org
, Jun 9 2017