New issue
Advanced search Search tips

Issue 731329 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Improve animation when dismissing Chrome Home as new tab

Project Member Reported by k...@chromium.org, Jun 8 2017

Issue description

When we dismiss Chrome Home (e.g. by dragging or back button) when it is an NTP, the toolbar animation could likely be better since it fades from light to dark once closed.

Note: It is especially bad in the toolbar button condition as we pull in the Chrome Home button but it doesn't exist in the tab switcher toolbar.
 
Cc: twelling...@chromium.org
The transition is started once the sheet is released. If the user is dragging the sheet to close it, release or close are the only signals that make sense for starting the toolbar transition, because if the user is still touching the toolbar they could start dragging it back up.

When the back button is pressed, we could add some logic to detect that the sheet is animating to its peek state and start the transition. I don't think this would be too hard, but it would need to act in coordination with the (still to be added) logic dictating whether we go back to the previous tab or the tab switcher. 

I think this should be P3 polish.

Comment 2 by k...@chromium.org, Jun 12 2017

Got it. I'll keep it as P2 for now to see if Chris has any thoughts about better animations and then we can reprioritize once we have a better idea of what we want. (e.g. not animating in the Chrome Home button in the button-trigger condition)

Comment 3 by k...@chromium.org, Jun 13 2017

Can we disable the sliding the toolbar buttons when Chrome Home is the NTP?
The toolbar buttons need to be shown when going from NTP -> tab switcher and NTP -> regular tab, so I'm not sure what disabling the animation would help with?

Comment 5 by k...@chromium.org, Jun 13 2017

We would disable sliding in the toolbar buttons when going from NTP to tab switcher since they are visually different.
The tab switcher toolbar and regular toolbar are the same Android View (long-term we've been talking about changing this but it's out-of-scope for M61), so we can't just disable the toolbar buttons sliding to achieve the right visual effect. We would need to write more custom animation code.

Comment 7 by k...@chromium.org, Jun 15 2017

Ah I see. So we can't just cross fade from Chrome Home to tab switcher toolbar as we do with the rest of the toolbar? If so, happy to de-pri this one to P3.
Labels: -Pri-2 Pri-3
Unfortunately we currently cannot.

In an in-flight patch I am starting the transition from the normal toolbar to the tab switcher toolbar sooner so that it feels a bit less abrupt so hopefully that takes care of the "P2" polish and further improvements can be "P3".

Comment 9 by kings...@google.com, Aug 10 2017

Labels: Fine-Pri-3.9
Status: WontFix (was: Assigned)
The Chrome Home experiment has ended; closing obsolete bug.

Sign in to add a comment