New issue
Advanced search Search tips

Issue 731328 link

Starred by 3 users
Status: Verified
Owner:
nparker@chromium.org
Closed: Nov 2017
Cc:
emilyschechter@chromium.org
srahim@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Security-UX


Participants' hotlists:
EnamelAndFriendsFixIt


Sign in to add a comment

Android: "A popup is blocked" uses present passive voice and isn't hyphenated

Project Member Reported by lgar...@chromium.org, Jun 8 2017 
Chrome Version: 60
 OS:Android

What steps will reproduce the problem?
(1) Visit https://permission.site
(2) Press "Popup (delayed 2 seconds)"

What is the expected result?
A notification about a blocked popup similar to other platforms.

What happens instead?
The infobar says "A popup is blocked".

I don't know if we have any other sentences like this.

Desktop has a verbose Page Action saying "Pop-up blocked", and bubble start with "The following pop-ups were blocked on this page:"

Could we change Android to "Pop-up blocked" for consistency with desktop?
(Else, the most similar to other "permissions" is "This site wants to open pop-ups".)
Screenshot_20170608-153016.png
141 KB View Download
Screen Shot 2017-06-08 at 15.33.03.png
10.0 KB View Download
Screen Shot 2017-06-08 at 15.33.06.png
67.4 KB View Download

Comment 1 by srahim@chromium.org, Jun 22 2017 

+1 to use "Pop-up blocked", not only to be consistent with desktop, but to be consistent with Android platform style, which often uses this kind of telegraphic style to save space. 

With the shorter string, we could also use a single-line mini info bar instead of the medium-sized one.

Comment 2 by est...@chromium.org, Jul 31 2017

Labels: Hotlist-GoodFirstBug OS-Android
Status: Available (was: Untriaged)

Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 4 by est...@chromium.org, Nov 10 2017

Cc: emilyschechter@chromium.org
emilyschechter can we just make this small string change as a bug fix, or do we need to clear it with UI (beyond srahim who approved in comment 1) first?

Comment 5 by jochen@chromium.org, Nov 10 2017 

My (maybe unpopular with Alex) opinion is that such a small change should not require an extra UI review: you got the string from srahim, and we don't have that much control over the string in other locales anyways, it's not like you're fundamentally changing some feature here.

Comment 6 by emilyschechter@chromium.org, Nov 10 2017 

Just sent ui-review an email to cover our bases. Go ahead.

Comment 7 by emilyschechter@chromium.org, Nov 16 2017

Labels: -Pri-3 Pri-2

Comment 8 by nparker@chromium.org, Nov 16 2017

Owner: nparker@chromium.org
Status: Started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51efa87992800f6a29fcff1bf4240090f4cc43ce

commit 51efa87992800f6a29fcff1bf4240090f4cc43ce
Author: Nathan Parker <nparker@chromium.org>
Date: Fri Nov 17 02:59:23 2017

Fix grammar of popup-blocker notification on Android.

Bug:  731328 
Change-Id: I61198120338e162c29dfbc582ea7b25063afb6bc
Reviewed-on: https://chromium-review.googlesource.com/775897
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Commit-Queue: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517262}
[modify] https://crrev.com/51efa87992800f6a29fcff1bf4240090f4cc43ce/chrome/app/generated_resources.grd

Comment 10 by nparker@chromium.org, Nov 17 2017

Status: Fixed (was: Started)

Comment 11 by kgna...@chromium.org, Nov 20 2017

Status: Verified (was: Fixed)
Works as per expected behavior, Shows as " Pop-up blocked". Verified on 64.0.3273.0
►

Sign in to add a comment