New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731323 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Huddly Package Updater should write logs to /var/log/message instead of /tmp/huddly.log

Project Member Reported by dsunk...@chromium.org, Jun 8 2017

Issue description

Chrome Version: 60 / 9592.13.0 / 60.0.3112.23
OS: Chrome OS
Device: Guado

What steps will reproduce the problem?
(1) Connect Huddly Go camera. 
(2) huddly-updater utility shall run to check and update camera fw.
(3) huddly-updater utility's logs are being written to /tmp/huddly.log

What is the expected result?

Logs should also available at /var/log/messages

(Or)

Something similar to https://chromium-review.googlesource.com/c/526298/

What happens instead?
Logs available only at /tmp/ folder.
 
Cc: -porce@chromium.org
Owner: porce@chromium.org
Summary: Huddly Package Updater should write logs to /var/log/message instead of /tmp/huddly.log (was: Huddly Package Updater should also write its log to /var/log/message instead of (or along with) /tmp/huddly.log)

Comment 2 by porce@chromium.org, Jun 8 2017

Status: Started (was: Untriaged)
Known issue; Zhonghe in the team is leading the initial efforts for sis firmware. A similar solution will be applied to Huddly case too.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/huddly-updater/+/58a69e18e4c8cfe8626ddabcbbcd10b268e48d13

commit 58a69e18e4c8cfe8626ddabcbbcd10b268e48d13
Author: Jiwoong Lee <porce@google.com>
Date: Tue Jun 13 01:20:04 2017

huddly-updater: Log to syslog by default

BUG= chromium:731323 
TEST=Build guado package, run at the target with various --log_to options.

Change-Id: I4128db6ca91b34a525e972c911aecf285cadb037
Reviewed-on: https://chromium-review.googlesource.com/531653
Commit-Ready: Jiwoong Lee <porce@chromium.org>
Tested-by: Jiwoong Lee <porce@chromium.org>
Reviewed-by: Simon Que <sque@chromium.org>

[modify] https://crrev.com/58a69e18e4c8cfe8626ddabcbbcd10b268e48d13/src/firmware.cc
[modify] https://crrev.com/58a69e18e4c8cfe8626ddabcbbcd10b268e48d13/src/module.mk
[modify] https://crrev.com/58a69e18e4c8cfe8626ddabcbbcd10b268e48d13/src/main.cc
[modify] https://crrev.com/58a69e18e4c8cfe8626ddabcbbcd10b268e48d13/src/minicam_device.cc

Comment 4 by porce@chromium.org, Jun 13 2017

Status: Fixed (was: Started)

Comment 5 by porce@chromium.org, Jun 13 2017

Cc: josa...@chromium.org dsunk...@chromium.org
Labels: -Pri-3 Pri-1
Status: Started (was: Fixed)

Comment 6 by porce@chromium.org, Jun 13 2017

Labels: Merge-Request-60
ChromeOS TPM for M60 (josafat@),
Please approve the following CL to be merged to release-R60-9592.B.

https://chromium-review.googlesource.com/531653

Unit/Integration test was done in R60-9647.0.0 by deveng.
The method of merge is cherry-pick in gerry.
The continuous build will be monitored by porce@ after merge.

Project Member

Comment 7 by sheriffbot@chromium.org, Jun 14 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Tested on R61-9648.0.0 / 61.0.3129.0 and the logs are getting written to /var/log/messages without any issues.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 14 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/huddly-updater/+/15df7a56493d8acf9f2eb8e8fbf412c1b7e0c6fa

commit 15df7a56493d8acf9f2eb8e8fbf412c1b7e0c6fa
Author: Jiwoong Lee <porce@google.com>
Date: Wed Jun 14 01:21:13 2017

huddly-updater: Log to syslog by default

Cherry-pick from CL 531653.
BUG= chromium:731323 
TEST=Build guado package, run at the target with various --log_to options.

Change-Id: I4128db6ca91b34a525e972c911aecf285cadb037
Reviewed-on: https://chromium-review.googlesource.com/531653
Commit-Ready: Jiwoong Lee <porce@chromium.org>
Tested-by: Jiwoong Lee <porce@chromium.org>
Reviewed-by: Simon Que <sque@chromium.org>
(cherry picked from commit 58a69e18e4c8cfe8626ddabcbbcd10b268e48d13)
Reviewed-on: https://chromium-review.googlesource.com/535035
Reviewed-by: Jiwoong Lee <porce@chromium.org>
Commit-Queue: Jiwoong Lee <porce@chromium.org>
Trybot-Ready: Jiwoong Lee <porce@chromium.org>

[modify] https://crrev.com/15df7a56493d8acf9f2eb8e8fbf412c1b7e0c6fa/src/firmware.cc
[modify] https://crrev.com/15df7a56493d8acf9f2eb8e8fbf412c1b7e0c6fa/src/module.mk
[modify] https://crrev.com/15df7a56493d8acf9f2eb8e8fbf412c1b7e0c6fa/src/main.cc
[modify] https://crrev.com/15df7a56493d8acf9f2eb8e8fbf412c1b7e0c6fa/src/minicam_device.cc

Project Member

Comment 11 by sheriffbot@chromium.org, Jun 19 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by porce@chromium.org, Jun 19 2017

Labels: -Merge-Approved-60
Cc: rpattumani@chromium.org

Comment 14 by porce@chromium.org, Jul 13 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Huddly-updater utility now writes logs to /var/log/messages. 

Sign in to add a comment