New issue
Advanced search Search tips

Issue 731322 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Don't fade search icon when switching between Downloads/Bookmarks/History

Project Member Reported by k...@chromium.org, Jun 8 2017

Issue description

Right now we fade the search icon out and back in when you switch between the downloads/bookmarks/history pane. We should ideally keep it visible always as it's persistent.
 
Cc: mdjones@chromium.org
+mdjones since he did the content transitions.

This is hard to do with how we implemented the bottom sheet content. Each toolbar is completely separate from the others and we fade out the old toolbar then fade in the new one. Skipping the fade on one button would be odd programmatically. Matt, please comment if that's not right.

Can we make this P3 long term polish?
twellington@ is correct, this would move the responsibility of animation from the sheet to the individual toolbars. This is possible but a pain; I'm not going to prioritize this very highly.

Comment 3 by k...@chromium.org, Jun 12 2017

Labels: -Pri-2 Pri-3
I'm OK with making this P3 given eng cost and it is mostly a polish fix. Feel free to disagree Chris.

Comment 4 by kings...@google.com, Aug 10 2017

Labels: Fine-Pri-4.0
Status: WontFix (was: Available)
The Chrome Home experiment has ended; closing obsolete bug.

Sign in to add a comment