[Chrome Home] Update snackbars in Chrome Home to Modern |
|||||||
Issue descriptionIf you close a tab in the Chrome Home tab switcher, the snackbar that comes up looks visually strange as an opaque snackbar over a translucent toolbar. We should figure out a visual treatment that works better here.
,
Jul 12 2017
Let's remove the toast instead.
,
Jul 13 2017
Remove what toast? Are you saying we should remove the undo tab closed snackbar? That seems kind of risky to me as that is the one option you have to quickly undo a potential mistake you made. Removing this would likely be quite unpopular if I would guess.
,
Jul 13 2017
My thinking was that the user can always get it back via Recents or omnibox suggestions. Looks like <1% of these toasts are used and though 2.7% of users use it, I'm wondering if folks think thats enough to warrant showing a toast every time the other 97.3% close a tab. We had a brief discussion about it in the bug bash spreadsheet: https://docs.google.com/a/google.com/spreadsheets/d/1entEbcJTeKn4iBIvusa_TqEVzISLsaSGv-P3rJhaKNM/edit?disco=AAAABN6bv6M Because this is such a low priority (and something that will eventually be addressed when we unify snackbar/toasts etc. vis snowflake), I'm happy to hold on this for now :)
,
Jul 13 2017
Because this is a feature we don't have in Bling, have we gotten any user feedback requesting something like this?
,
Jul 13 2017
I feel this is one of those things that is used very rarely, but would be sorely missed when you need it. Especially for those that accidentally close all of their tabs by mistake.
,
Aug 10 2017
,
Aug 29 2017
@Hannah, did you think this should be moved up to M63?
,
Aug 29 2017
Yep! Added a comment in the tracker as well. Thanks!
,
Aug 29 2017
I think I'm still in favor of punting this to post-M63 to phase out the changes that break flows but I'm open to other thoughts. Why do you think it should moved up to M63?
,
Aug 30 2017
Summary from our meeting with Alex: Attached specs where we changed just the font colors, and background color to white (with added dropshadow)for Chrome Home for just the download confirmation, and undo closed tab. This is a priority from the UX side but please provide some guidance on the feasibility for an update like this for M62-3+.
,
Aug 30 2017
,
Aug 31 2017
Sounds good to me. Renaming the bug to capture that and bumping priority to M63 but feel free to push back if harder.
,
Aug 31 2017
Is this a styling change for all snackbars (relatively easy) or just the two snackbars mentioned in #11 (harder, but possibly still feasible for M63)?
,
Aug 31 2017
I believe it was all snackbars but can you confirm Hannah?
,
Sep 6 2017
Becky, will you look into updating our snackbars for modern?
,
Sep 6 2017
Just want to make sure: is this a conditional change with Chrome Home or not?
,
Sep 6 2017
If unconditional, how does the shadow work tablet version? the tablet snackbar has a shorter width.
,
Sep 6 2017
It should be conditional to Chrome Home
,
Sep 6 2017
Screenshot of changes. Please check!
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19bc748359e41fdbd00798fd7706ffdbd0cf5c2b commit 19bc748359e41fdbd00798fd7706ffdbd0cf5c2b Author: Becky Zhou <huayinz@chromium.org> Date: Thu Sep 07 19:01:10 2017 [Chrome Home] Snackbar visual refresh With Chrome Home enabled: + Change background to white + Change message to black 87 and button to blue 500 + Add shadow Bug: 731321 Change-Id: I98b98daf26ed8b15dc548b13d366269bec5e8f42 Reviewed-on: https://chromium-review.googlesource.com/653485 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#500351} [modify] https://crrev.com/19bc748359e41fdbd00798fd7706ffdbd0cf5c2b/chrome/android/java/res/layout/snackbar.xml [modify] https://crrev.com/19bc748359e41fdbd00798fd7706ffdbd0cf5c2b/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/19bc748359e41fdbd00798fd7706ffdbd0cf5c2b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java
,
Sep 20 2017
Closing this out. Hannah/Chris, please re-open if there are any issues with the screenshot Becky provided in #20. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by hannahs@chromium.org
, Jun 12 2017