Hide bottom nav bar when searching history/bookmarks/downloads |
||||
Issue descriptionI think we should hide the bottom nav bar when searching history/bookmarks/history since it takes up quite a bit of space where you could be viewing the search results. However, I view this as lower priority and happy to discuss more.
,
Aug 10 2017
Issue 731033 has been merged into this issue.
,
Aug 10 2017
,
Oct 26 2017
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e0456eba2c136a5706a9e0761e579849013c705 commit 9e0456eba2c136a5706a9e0761e579849013c705 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Oct 26 20:08:02 2017 [Home] Don't position bottom nav over keyboard This change keeps the bottom nav hidden when the keyboard is showing. This only involves removing the code that was necessary to try to keep it above the keyboard; 'hidden' is its natural state. BUG= 731304 Change-Id: Ia1abc9db2c4121d010c0c29ff8cc2c95c5e7832a Reviewed-on: https://chromium-review.googlesource.com/739953 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#511939} [modify] https://crrev.com/9e0456eba2c136a5706a9e0761e579849013c705/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [modify] https://crrev.com/9e0456eba2c136a5706a9e0761e579849013c705/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java [modify] https://crrev.com/9e0456eba2c136a5706a9e0761e579849013c705/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetObserver.java [modify] https://crrev.com/9e0456eba2c136a5706a9e0761e579849013c705/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/EmptyBottomSheetObserver.java
,
Oct 26 2017
,
Dec 12 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by cl...@chromium.org
, Jun 21 2017