> - compile failure on .c files (static_assert() in magenta/syscalls/resource.h, upstream MG-836)

is https://fuchsia-review.googlesource.com/#/c/33734/

NET-105 for cert validation.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f9ff13dfa8191f7c69d91dad4f3cbf2d5b7b249

commit 8f9ff13dfa8191f7c69d91dad4f3cbf2d5b7b249
Author: thakis <thakis@chromium.org>
Date: Fri Jun 16 19:51:34 2017

fuchsia: Make sdch build.

Linux's config.h seems close enough, so use that.

BUG= 731302 

Review-Url: https://codereview.chromium.org/2943713002
Cr-Commit-Position: refs/heads/master@{#480131}

[modify] https://crrev.com/8f9ff13dfa8191f7c69d91dad4f3cbf2d5b7b249/sdch/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f11c1513e741e621b231962c83e1a9081aee4585

commit f11c1513e741e621b231962c83e1a9081aee4585
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Jun 30 01:08:21 2017

Compile ui/gfx on Fuchsia

1. Added stubs for typedefs in native_widget_types.h
2. Updated skia/ext/platform_canvas.h to define
   CreatePlatformCanvasWithPixels on Fuchsia

Bug:  731302 
Change-Id: Ibfcb3d522ff87d24c17677be8f09e7f3b3a9d9a6
Reviewed-on: https://chromium-review.googlesource.com/557219
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483569}
[modify] https://crrev.com/f11c1513e741e621b231962c83e1a9081aee4585/skia/ext/platform_canvas.h
[modify] https://crrev.com/f11c1513e741e621b231962c83e1a9081aee4585/ui/gfx/native_widget_types.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c33235ae031c7b03910b17173abba2b9f031d6a

commit 5c33235ae031c7b03910b17173abba2b9f031d6a
Author: Sergey Ulanov <sergeyu@google.com>
Date: Thu Jul 06 23:55:07 2017

Make mac version of GetNetworkList() reusable on Fuchsia

On MacOS and iOS chrome uses getifaddrs() API. It's implemented on many
systems other than Mac, particularly Fuchsia. This CL moves the
implementation to network_interfaces_getifaddrs.cc, so it's no longer
Mac-specific. Also cleaned up the code to minimize Mac dependencies.

Also moved NaCl-specific code out of network_interfaces_posix.cc.

Bug:  731302 
Change-Id: I291527a76cbd7dafd38044275c80456428ea53af
Reviewed-on: https://chromium-review.googlesource.com/562360
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484773}
[modify] https://crrev.com/5c33235ae031c7b03910b17173abba2b9f031d6a/net/BUILD.gn
[modify] https://crrev.com/5c33235ae031c7b03910b17173abba2b9f031d6a/net/base/network_interfaces.h
[add] https://crrev.com/5c33235ae031c7b03910b17173abba2b9f031d6a/net/base/network_interfaces_getifaddrs.cc
[add] https://crrev.com/5c33235ae031c7b03910b17173abba2b9f031d6a/net/base/network_interfaces_getifaddrs.h
[add] https://crrev.com/5c33235ae031c7b03910b17173abba2b9f031d6a/net/base/network_interfaces_getifaddrs_unittest.cc
[modify] https://crrev.com/5c33235ae031c7b03910b17173abba2b9f031d6a/net/base/network_interfaces_linux.cc
[delete] https://crrev.com/5eb077213d441ec8d601154bead49f2111b4d016/net/base/network_interfaces_mac.cc
[delete] https://crrev.com/5eb077213d441ec8d601154bead49f2111b4d016/net/base/network_interfaces_mac.h
[add] https://crrev.com/5c33235ae031c7b03910b17173abba2b9f031d6a/net/base/network_interfaces_nacl.cc
[modify] https://crrev.com/5c33235ae031c7b03910b17173abba2b9f031d6a/net/base/network_interfaces_posix.cc
[modify] https://crrev.com/5c33235ae031c7b03910b17173abba2b9f031d6a/net/base/network_interfaces_posix.h
[modify] https://crrev.com/5c33235ae031c7b03910b17173abba2b9f031d6a/net/base/network_interfaces_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4908557534d516a48589f36714d91ed835683f58

commit 4908557534d516a48589f36714d91ed835683f58
Author: Sergey Ulanov <sergeyu@google.com>
Date: Mon Jul 10 23:25:46 2017

Compile net_unittests on Fuchsia

Several fixes to make net_unittests compile for Fuchsia:
 1. Added cert_database_fuchsia.cc and test_root_certs_fuchsia.cc.
 2. Disabled Kerberos (not implemented on Fuchsia).
 3. Updated CertVerifyProc to use CreateCertVerifyProcBuiltin() with
    OS_FUCHSIA. Currently it uses DummySystemTrustStore, so cert
    verification will always fail. This will need to be fixed later,
    once Fuchsia adds an API for root certs store.
 4. res_ninit() is not yet implemented, so res_init() is used instead.
 5. Disabled DnsReloader. It relies on res_ninit() and it's unlikely
    to be useful on Fuchsia.

Bug:  731302 
Change-Id: I05cbb7a4b571d82894b7c62740fc2f5b36870214
Reviewed-on: https://chromium-review.googlesource.com/560050
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485440}
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/BUILD.gn
[add] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/base/platform_mime_util_fuchsia.cc
[add] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/cert/cert_database_fuchsia.cc
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/cert/cert_verify_proc.cc
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/cert/cert_verify_proc.h
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/cert/cert_verify_proc_unittest.cc
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/cert/multi_threaded_cert_verifier.cc
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/cert/multi_threaded_cert_verifier.h
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/cert/test_root_certs.h
[add] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/cert/test_root_certs_fuchsia.cc
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/dns/dns_config_service_posix.cc
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/dns/dns_reloader.cc
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/dns/host_resolver_impl.cc
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/dns/host_resolver_proc.cc
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/features.gni
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/socket/unix_domain_server_socket_posix.cc
[modify] https://crrev.com/4908557534d516a48589f36714d91ed835683f58/net/socket/unix_domain_server_socket_posix.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6a414dc61f4fe7c1274940f364e03e84712f848

commit a6a414dc61f4fe7c1274940f364e03e84712f848
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jul 12 00:18:51 2017

Build net_unittests on the Fuchsia bots.

sergeyu made net_unittests build on Fuchsia, so let's build it on the bots
to make sure it stays compilable.

Bug:  731302 
Change-Id: I631479ca619b09ddf0c7529864ae6acd898ff9d0
Reviewed-on: https://chromium-review.googlesource.com/566891
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485742}
[modify] https://crrev.com/a6a414dc61f4fe7c1274940f364e03e84712f848/testing/buildbot/chromium.fyi.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fe6a3555125166e990ed021c5e1f68619b2b9f3

commit 6fe6a3555125166e990ed021c5e1f68619b2b9f3
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Jul 19 00:34:30 2017

Run net_unittests on Fuchsia bots (with a filter).

Bug:  731302 
Change-Id: I56367b8556efb06d3777974512edc59c0b55eee0
Reviewed-on: https://chromium-review.googlesource.com/571100
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487691}
[modify] https://crrev.com/6fe6a3555125166e990ed021c5e1f68619b2b9f3/testing/buildbot/chromium.fyi.json
[add] https://crrev.com/6fe6a3555125166e990ed021c5e1f68619b2b9f3/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84fd2a923e470807b9c993cbd6a5ed2c58d1c21d

commit 84fd2a923e470807b9c993cbd6a5ed2c58d1c21d
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Jul 19 19:19:39 2017

Build and run crypto_unittests on Fuchsia bots

Bug:  731302 
Change-Id: Ie1f9ae4a7e950d5541a37f4e35f83e84df2733e2
Reviewed-on: https://chromium-review.googlesource.com/576407
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487936}
[modify] https://crrev.com/84fd2a923e470807b9c993cbd6a5ed2c58d1c21d/testing/buildbot/chromium.fyi.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77132a2bc78e8dc9ce411e8166bfd009f6476f6f

commit 77132a2bc78e8dc9ce411e8166bfd009f6476f6f
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Jul 21 02:34:05 2017

Use Hardcoded mime types to implement GetPreferredExtensionForMimeType().

Updated GetPreferredExtensionForMimeType() implementation so it
searches uses the same MIME type tables that are used for
GetExtensionsForMimeType() and GetWellKnownMimeTypeFromExtension()

Previously platform_mime_util_linux.cc and mime_extension_chromeos.cc
contained some hardcoded tables to map between mime types and filename
extensions. There is no reason these need to be separate from the maps
in mime_util.cc. Merged them with the tables in mime_util.cc

Bug:  731302 
Change-Id: Icdaad51c70cffbf62c404297ad615ac5c6dd33e9
Reviewed-on: https://chromium-review.googlesource.com/578649
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488556}
[modify] https://crrev.com/77132a2bc78e8dc9ce411e8166bfd009f6476f6f/net/BUILD.gn
[modify] https://crrev.com/77132a2bc78e8dc9ce411e8166bfd009f6476f6f/net/base/filename_util_unittest.cc
[delete] https://crrev.com/609d97766b5ea2ff6fcf64d794fd986e0acaff71/net/base/mime_extension_chromeos.cc
[delete] https://crrev.com/609d97766b5ea2ff6fcf64d794fd986e0acaff71/net/base/mime_extension_chromeos.h
[modify] https://crrev.com/77132a2bc78e8dc9ce411e8166bfd009f6476f6f/net/base/mime_util.cc
[modify] https://crrev.com/77132a2bc78e8dc9ce411e8166bfd009f6476f6f/net/base/mime_util.h
[modify] https://crrev.com/77132a2bc78e8dc9ce411e8166bfd009f6476f6f/net/base/mime_util_unittest.cc
[modify] https://crrev.com/77132a2bc78e8dc9ce411e8166bfd009f6476f6f/net/base/platform_mime_util.h
[modify] https://crrev.com/77132a2bc78e8dc9ce411e8166bfd009f6476f6f/net/base/platform_mime_util_fuchsia.cc
[modify] https://crrev.com/77132a2bc78e8dc9ce411e8166bfd009f6476f6f/net/base/platform_mime_util_linux.cc
[modify] https://crrev.com/77132a2bc78e8dc9ce411e8166bfd009f6476f6f/net/base/platform_mime_util_mac.mm
[modify] https://crrev.com/77132a2bc78e8dc9ce411e8166bfd009f6476f6f/net/base/platform_mime_util_win.cc
[modify] https://crrev.com/77132a2bc78e8dc9ce411e8166bfd009f6476f6f/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1be4d5c1b63d516b1eb173a7070fe9204dae2be6

commit 1be4d5c1b63d516b1eb173a7070fe9204dae2be6
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Jul 21 18:46:15 2017

Update Fuchsia SDK instructions to include netstack

Current version of Fuchsia SDK doesn't include netstack, which will be
required to run many tests. Updated the SDK instructions to include the
following packages in the SDK:
 - netstack: netstack service.
 - runtime-config: bootstrap configs to run netstack.

I'll update test_runner.py to start bootstrap and netstack after the
SDK is updated with these packages.

Bug:  731302 
Change-Id: Ida1870f2135a878ad9e036ac4e1858fc7039d1c4
Reviewed-on: https://chromium-review.googlesource.com/581947
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488720}
[modify] https://crrev.com/1be4d5c1b63d516b1eb173a7070fe9204dae2be6/docs/fuchsia_sdk_updates.md

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df97778dec61a7c5bd0702f7f352e33514bc33cb

commit df97778dec61a7c5bd0702f7f352e33514bc33cb
Author: Sergey Ulanov <sergeyu@google.com>
Date: Mon Jul 24 18:40:19 2017

Update fuchsia/test_runner.py to run bootstrap.

Now that the Fuchsia SDK includes configs for the "bootstrap"
service, migrate to launching the test binary via bootstrap, rather
than  launching it directly as an "initial app". This makes the 
system services launched by the default bootstrap configuration 
available to the test binary.

Bug:  731302 
Change-Id: Ie17d123f7de91ea49a8bd11ddf67a6bd903dfdfb
Reviewed-on: https://chromium-review.googlesource.com/582047
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489031}
[modify] https://crrev.com/df97778dec61a7c5bd0702f7f352e33514bc33cb/build/fuchsia/test_runner.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e821e1a89eac8982aa1d8fd3a3fbb31660309cf

commit 7e821e1a89eac8982aa1d8fd3a3fbb31660309cf
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Jul 24 22:36:03 2017

fuchsia: Only run test binary once

Regressed at https://chromium-review.googlesource.com/c/582047/, or
possibly https://chromium.googlesource.com/chromium/src.git/+/b29655da291d0fe10c945899913a21a63c278636
when bootstrap was rolled in (?).

bootstrap already runs autorun in apps.config, so don't add a second
run of the test binary.

Bug:  731302 , 706592
Change-Id: I6847942b64598777424ab2b106d2c7e1ba3ca8f5
Reviewed-on: https://chromium-review.googlesource.com/583928
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489105}
[modify] https://crrev.com/7e821e1a89eac8982aa1d8fd3a3fbb31660309cf/build/fuchsia/test_runner.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d65d81cbef53a4dd3e97e5343d560255a7302e60

commit d65d81cbef53a4dd3e97e5343d560255a7302e60
Author: Sergey Ulanov <sergeyu@google.com>
Date: Tue Jul 25 19:33:56 2017

Use readdir() instead of readdir_r() in SimpleIndexFile.

Fuchsia currently doesn't implement readdir_r(). libc implementations
on Linux, Android and MacOS allocate dirent struct inside DIR, so
readdir() is safe as long as DIR is not shared between multiple thread,
i.e. readdir() is safe to use in SimpleIndexFile.
Also readdir_r() is deprecated in glibc.

Bug:  731302 
Change-Id: I748a6c39c01600dcea18d19fc8650258297af92b
Reviewed-on: https://chromium-review.googlesource.com/577972
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489400}
[modify] https://crrev.com/d65d81cbef53a4dd3e97e5343d560255a7302e60/net/disk_cache/simple/simple_index_file_posix.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f93e063ca4ea1755f93df36918b143a14d5a3301

commit f93e063ca4ea1755f93df36918b143a14d5a3301
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Jul 26 01:02:39 2017

Add EIO in net_errors_posix.cc

EIO is used on Fuchsia for generic IO errors.

Bug:  731302 
Change-Id: I1630b20d28c8074d490218b08d4ce8894fb69e68
Reviewed-on: https://chromium-review.googlesource.com/584789
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489503}
[modify] https://crrev.com/f93e063ca4ea1755f93df36918b143a14d5a3301/net/base/net_errors_posix.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2e887030e59d94073063f2e109df0375ccc1343

commit d2e887030e59d94073063f2e109df0375ccc1343
Author: Egor Pasko <pasko@chromium.org>
Date: Wed Jul 26 15:03:43 2017

simplecache: remove DCHECK after index restore

When file traversal hits an error from libc, the entries found so far
are still usable and can be merged into the index. This only happens on
POSIX systems, since the FileEnumerator-based implementation swallows
errors.

Alternatively we could ignore the error in TraverseCacheDirectory() on
POSIX as well.

Also added a comment clarifying this.

Bug:  731302 
Change-Id: Id19e4e60fed99328ea9a83f2eaa3ae9ce8e3aaf7
Reviewed-on: https://chromium-review.googlesource.com/584827
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489643}
[modify] https://crrev.com/d2e887030e59d94073063f2e109df0375ccc1343/net/disk_cache/simple/simple_index.cc
[modify] https://crrev.com/d2e887030e59d94073063f2e109df0375ccc1343/net/disk_cache/simple/simple_index_file.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cbcbc5264ceab4603c748b10db64cc66460e52b

commit 7cbcbc5264ceab4603c748b10db64cc66460e52b
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Jul 26 18:29:13 2017

Update TCP unittests to handle Connect() result.

TCP socket unittests were ignoring the value returned from Connect().
connect() is allowed to complete synchronously, but the tests were not
handling this case.

Bug:  731302 
Change-Id: I436fcc566d2bf6be01be92ac800a2dc2f6eba055
Reviewed-on: https://chromium-review.googlesource.com/585333
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489703}
[modify] https://crrev.com/7cbcbc5264ceab4603c748b10db64cc66460e52b/net/socket/tcp_client_socket_unittest.cc
[modify] https://crrev.com/7cbcbc5264ceab4603c748b10db64cc66460e52b/net/socket/tcp_server_socket_unittest.cc
[modify] https://crrev.com/7cbcbc5264ceab4603c748b10db64cc66460e52b/net/socket/tcp_socket_unittest.cc

Here are some issues I found when investigating failures in socket unittests.

* EIO is returned for all errors from netstack. We get valid error codes only for errors handled by the MXIO layer. Pending fix: https://fuchsia-review.googlesource.com/#/c/43685/

* NET-120: connect() is always blocking, ignores O_NONBLOCK. Pending fix: https://fuchsia-review.googlesource.com/c/42986/

* NET-121: Flags, particularly MSG_PEEK. are not supported in recv(). Breaks SocketPosix.IsConnected().

* NET-122: recvfrom() doesn't allow non-null src_addr for connected sockets. Breaks UDP sockets in Chrome. Fixed in trunk for UDP sockets only. Toshi works on a fix for TCP (not relevant for Chrome).

* NET-123: broadcast doesn't seem to be supported. This breaks some unittests, but AFAICT Chrome doesn't use broadcast sockets. Will disable the unittest.

* NET-124: bind() doesn't fail when binding to a used local port. Breaks RANDOM_BIND for UDP sockets.

* NET-57: Multicast is not supported. We will need this mainly for MDNS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a13eb3f514c8191b80215b779a2a535f8ae75f38

commit a13eb3f514c8191b80215b779a2a535f8ae75f38
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Jul 28 05:35:50 2017

Add DLOG(FATAL) for EIO on Fuchsia.

crrev.com/489503 added EIO in MapSystemError(). Fuchsia's MXIO may
return EIO for some errors currently, but it's better to use
more-specific error codes. This CL adds an DLOG(FATAL) to make the
cases when EIO is returned visible.

Also updated warning that's logged for unrecognized error codes to
include strerror().

Bug:  731302 
Change-Id: Iea285424ee0fa0a1fa06ba91fe7204e50b48dd98
Reviewed-on: https://chromium-review.googlesource.com/588030
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490286}
[modify] https://crrev.com/a13eb3f514c8191b80215b779a2a535f8ae75f38/net/base/net_errors_posix.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38e18bd525a1282f75ede31906bb52c2fc936517

commit 38e18bd525a1282f75ede31906bb52c2fc936517
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Jul 28 18:59:36 2017

Cleanups in udp_socket_unittests. Disabled some tests for Fuchsia.

Various cleanups in the tests.
Disabled tests for broadcast and multicast as these features are not
fully implemented on Fuchsia yet.

Bug:  731302 
Change-Id: I3adf576a6d32d03fce54d1ca4175310a03a04664
Reviewed-on: https://chromium-review.googlesource.com/590868
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490480}
[modify] https://crrev.com/38e18bd525a1282f75ede31906bb52c2fc936517/net/socket/udp_socket_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cd680e72a411c5a565098251d42863c43aef17f

commit 9cd680e72a411c5a565098251d42863c43aef17f
Author: Sergey Ulanov <sergeyu@google.com>
Date: Tue Aug 08 01:41:26 2017

Make chrome_test_server_spawner usable on Fuchsia

chrome_test_server_spawner is used by net_unittests to spawn test
server on the host. Previuously it had dependencies on Android. Moved
it to build/util/common and refactored Android dependency, so the
same code can be used when running these tests on Fuchsia bots.

Bug:  731302 
Change-Id: Ie4069b6cc0f1dc98b96f62fdf6a1b692a86b3997
Reviewed-on: https://chromium-review.googlesource.com/603669
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492498}
[modify] https://crrev.com/9cd680e72a411c5a565098251d42863c43aef17f/build/android/pylib/local/local_test_server_spawner.py
[modify] https://crrev.com/9cd680e72a411c5a565098251d42863c43aef17f/build/android/test_runner.pydeps
[rename] https://crrev.com/9cd680e72a411c5a565098251d42863c43aef17f/build/util/lib/common/chrome_test_server_spawner.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c5186257e56f5e73686145a1f66ba3fd03c2b62

commit 6c5186257e56f5e73686145a1f66ba3fd03c2b62
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Sat Aug 12 19:06:27 2017

Filter failing tests in net_unittests and media_unittests on Fuchsia

TBR=scottmg@chromium.org

Bug:  737802 ,  731302 
Change-Id: I166c0b168a216f8f9453cf7d2e3fb719ecf81f9f
Reviewed-on: https://chromium-review.googlesource.com/612748
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493982}
[modify] https://crrev.com/6c5186257e56f5e73686145a1f66ba3fd03c2b62/testing/buildbot/filters/fuchsia.media_unittests.filter
[modify] https://crrev.com/6c5186257e56f5e73686145a1f66ba3fd03c2b62/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e8d6f32424a11a6e65681862d471277df4a4e5a

commit 9e8d6f32424a11a6e65681862d471277df4a4e5a
Author: Sergey Ulanov <sergeyu@google.com>
Date: Mon Aug 14 22:12:58 2017

Remove host argument from SpawnedTestServer constructor.

SpawnedTestServer previously took host parameter to specify host name
for the test server, but it always starts the server on localhost. All
tests were passing kLocalhost (127.0.0.1) for that parameter. Removing
this parameter will allow to make this tests work on Fuchsia, where test
server will run on a different IP address.

Also cleaned up default values initialization in BaseTestServer and
BaseTestServer::SSLOptions.

Bug:  731302 
Change-Id: Ibb1206fb34dc8707db6dc0451b96323699760121
Reviewed-on: https://chromium-review.googlesource.com/608725
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494206}
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/browser/extensions/api/socket/socket_apitest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/browser/extensions/extension_apitest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/browser/net/ftp_browsertest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/browser/net/proxy_browsertest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/browser/net/websocket_browsertest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/browser/policy/test/local_policy_test_server.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/browser/safe_browsing/local_two_phase_testserver.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/chrome/test/ppapi/ppapi_test.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/components/sync/test/local_sync_test_server.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/content/browser/shared_worker/worker_browsertest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/content/public/test/browser_test_base.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/extensions/browser/api/sockets_udp/sockets_udp_apitest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/net/test/spawned_test_server/base_test_server.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/net/test/spawned_test_server/base_test_server.h
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/net/test/spawned_test_server/local_test_server.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/net/test/spawned_test_server/local_test_server.h
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/net/test/spawned_test_server/remote_test_server.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/net/test/spawned_test_server/remote_test_server.h
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/net/tools/testserver/run_testserver.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/9e8d6f32424a11a6e65681862d471277df4a4e5a/net/websockets/websocket_end_to_end_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05407bb2c6452b139d9afd426691dac058602bd7

commit 05407bb2c6452b139d9afd426691dac058602bd7
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Aug 16 11:19:20 2017

Fix MessagePumpFuchsia to avoid handling the same event multiple times.

Previously, when MX_ERR_TIMED_OUT is retuned from mx_port_wait() the
message pump would handle it the same way as MX_OK, i.e. it would
process the content of packet parameter. Due to this issue the pump
would handles the same packet received from the port more than once,
sometimes calling a watch controller that's already stopped or deleted.

Bug:  731302 , 706592
Change-Id: I80f64ea9a00c3b2ea6344ce31be5d6339e37d904
Reviewed-on: https://chromium-review.googlesource.com/615730
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494747}
[modify] https://crrev.com/05407bb2c6452b139d9afd426691dac058602bd7/base/message_loop/message_pump_fuchsia.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d7898c2fc228f02672bd753e857ef503f266164

commit 4d7898c2fc228f02672bd753e857ef503f266164
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Aug 18 18:51:45 2017

Roll Fuchsia SDK

The new version should have the following issues addressed:
 - Fix for the issues that break base::SyncSocket,
     https://crbug.com/741783 
 - bind() not failing when binding to used UDP ports, NET-124

NOTRY=true

Bug:  741783 ,  731302 
Change-Id: I9986a75ee00dfc6bb52a14b7cb5d558b3aaf632e
Reviewed-on: https://chromium-review.googlesource.com/620288
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495632}
[modify] https://crrev.com/4d7898c2fc228f02672bd753e857ef503f266164/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfd0cfe183541be794256aa4c354cc2840a9042a

commit bfd0cfe183541be794256aa4c354cc2840a9042a
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Aug 18 22:14:30 2017

Enable tests that were failing due to shutdown() not working correctly.

Last SDK roll should make base::CancellableSyncSocket work correctly,
so the tests can be enabled now.

NOTRY=true

Bug:  731302 
Change-Id: I160e3af7839dfd68c26e31185cb35cf0881c87b1
Reviewed-on: https://chromium-review.googlesource.com/620326
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495713}
[modify] https://crrev.com/bfd0cfe183541be794256aa4c354cc2840a9042a/testing/buildbot/filters/fuchsia.base_unittests.filter
[modify] https://crrev.com/bfd0cfe183541be794256aa4c354cc2840a9042a/testing/buildbot/filters/fuchsia.media_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37a55d03a87f907d617c499d23c0b18d6f009311

commit 37a55d03a87f907d617c499d23c0b18d6f009311
Author: Sergey Ulanov <sergeyu@google.com>
Date: Sat Aug 19 02:22:47 2017

Update net_unittests filter on Fuchsia to run UDP & TCP socket tests.

All problems that were breaking UDP & TCP socket tests were resolved,
so these tests should pass now.

Bug:  731302 
Change-Id: I7635c44bbd0fdf39ba0f4fa3b0c0c834d3b144a9
Reviewed-on: https://chromium-review.googlesource.com/622127
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495788}
[modify] https://crrev.com/37a55d03a87f907d617c499d23c0b18d6f009311/net/socket/udp_socket_unittest.cc
[modify] https://crrev.com/37a55d03a87f907d617c499d23c0b18d6f009311/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d874d23c620235973134c270f1c821935496b17

commit 3d874d23c620235973134c270f1c821935496b17
Author: Sergey Ulanov <sergeyu@google.com>
Date: Tue Aug 22 17:36:02 2017

Always use relative path for certificates passed to testserver.py

Previously tests were passing relative path on Android and absolute path
on other platforms. Relative path is required when using testserver
spawner (used on Android and Fuchsia) because the tests and test_server
are running on different machines. With this change relative path will
be used on all platforms.
 1. Updated GetTestClientCertsDirectory() to return the same relative
    path on all platforms.
 2. Updated LocalTestServer to set CWD when starting testserver.py to
    source root. This is consistent with how testserver.py is started
    in chrome_test_server_spawner.py

Bug:  731302 
Change-Id: I9afc21135bde972338e93c0e0784bf9dc97344ed
Reviewed-on: https://chromium-review.googlesource.com/624818
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496351}
[modify] https://crrev.com/3d874d23c620235973134c270f1c821935496b17/net/test/spawned_test_server/local_test_server_posix.cc
[modify] https://crrev.com/3d874d23c620235973134c270f1c821935496b17/net/test/spawned_test_server/local_test_server_win.cc
[modify] https://crrev.com/3d874d23c620235973134c270f1c821935496b17/net/test/test_data_directory.cc
[modify] https://crrev.com/3d874d23c620235973134c270f1c821935496b17/net/test/test_data_directory.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b261234953ca1ef7658a72a987f4ec07b7f4525

commit 3b261234953ca1ef7658a72a987f4ec07b7f4525
Author: Sergey Ulanov <sergeyu@google.com>
Date: Tue Aug 22 18:51:09 2017

Generate net-test-server-config in test_runner on Fuchsia.

- Now test_runner.py generates net-test-server-config instead of
  net-test-server-ports as that's what will be expected by the tests
  after https://chromium-review.googlesource.com/c/619813.
- Now test_runner ensures that  testserver is stopped even if tests fail
  to stop it.
- Updated WaitUntil() to limit waiting time instead of number of
  attempts.

Bug:  731302 
Change-Id: I51fa7436f672ee0f52c3b866e4d266de1a456574
Reviewed-on: https://chromium-review.googlesource.com/620286
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496388}
[modify] https://crrev.com/3b261234953ca1ef7658a72a987f4ec07b7f4525/build/fuchsia/runner_common.py
[modify] https://crrev.com/3b261234953ca1ef7658a72a987f4ec07b7f4525/build/fuchsia/test_runner.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13f58d7d848ee2312dcce9ac32966e81c9b0d8cf

commit 13f58d7d848ee2312dcce9ac32966e81c9b0d8cf
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Aug 23 19:18:50 2017

Allocate port for testserver spawner dynamically.

Previously the port for testserver spawner for hardcoded in
test_runner.py. This means that tests may fail if that port is used when
the test is started. Now the port is allocated dynamically.

Bug:  731302 
Change-Id: Ib22e2470cbe952aa25b1b02cf2f5c6a551ebae20
Reviewed-on: https://chromium-review.googlesource.com/627243
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496764}
[modify] https://crrev.com/13f58d7d848ee2312dcce9ac32966e81c9b0d8cf/build/fuchsia/test_runner.py
[modify] https://crrev.com/13f58d7d848ee2312dcce9ac32966e81c9b0d8cf/build/util/lib/common/chrome_test_server_spawner.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4613270be5c6dc15cf611df28f9ff0c81e3a9c2

commit e4613270be5c6dc15cf611df28f9ff0c81e3a9c2
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Aug 25 00:34:30 2017

Don't set SO_KEEPALIVE on Fuchsia

SO_KEEPALIVE is not implemented on Fuchsia, but TCPSocketPosix tries to
enable it for all sockets, which causes netstack to spam console.
SO_KEEPALIVE is not used on Android and iOS. Disable it on Fuchsia too.

Bug:  731302 ,  758706 
Change-Id: I2ea1deb52de43c46550b8dc1eae92c876228bf4a
Reviewed-on: https://chromium-review.googlesource.com/630978
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497263}
[modify] https://crrev.com/e4613270be5c6dc15cf611df28f9ff0c81e3a9c2/net/socket/tcp_socket_posix.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c0bcafd1ceeefb678ade0b004e0d6585f3a941c

commit 7c0bcafd1ceeefb678ade0b004e0d6585f3a941c
Author: Sergey Ulanov <sergeyu@google.com>
Date: Mon Aug 28 19:03:26 2017

Use RemoteTestServer on Fuchsia.

Python currently doesn't run on Fuchsia, so we need to run testserver.py
outside of qemu. Updated spawned_test_server.h to use RemoteTestServer
on Fuchsia. Also set use_test_server flag for net_unittests, so the
test_runner will start test server spawner when running net_unittests.

Bug:  731302 
Change-Id: If6383ad671d6eb7c37242dca6fc02b0df872bda1
Reviewed-on: https://chromium-review.googlesource.com/636788
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497822}
[modify] https://crrev.com/7c0bcafd1ceeefb678ade0b004e0d6585f3a941c/net/BUILD.gn
[modify] https://crrev.com/7c0bcafd1ceeefb678ade0b004e0d6585f3a941c/net/test/spawned_test_server/spawned_test_server.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/937d6ebafe744ecccf79cf6015e7e861c82bd628

commit 937d6ebafe744ecccf79cf6015e7e861c82bd628
Author: Sergey Ulanov <sergeyu@google.com>
Date: Mon Aug 28 22:35:38 2017

Add TestServerConfig to allow testserver outside localhost

Previuosly testserver was always assumed to be running on localhost
even when started with RemoteTestServer. This CL adds TestServerConfig
that allows to pass to the tests configuration for the test server.
The config specifies how the tests should connect to the test spawner
and to the test server itself. The config also replaces the mechanism
that was used to pass spawner's port number on Android (through
net-test-server-ports file).

TBR=phajdan.jr@chromium.org

Bug:  731302 
Change-Id: Ib2e07e6d293c52164b12b73dfd5ebe13d89d018d
Reviewed-on: https://chromium-review.googlesource.com/619813
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497907}
[modify] https://crrev.com/937d6ebafe744ecccf79cf6015e7e861c82bd628/PRESUBMIT.py
[modify] https://crrev.com/937d6ebafe744ecccf79cf6015e7e861c82bd628/build/android/pylib/local/local_test_server_spawner.py
[modify] https://crrev.com/937d6ebafe744ecccf79cf6015e7e861c82bd628/net/BUILD.gn
[modify] https://crrev.com/937d6ebafe744ecccf79cf6015e7e861c82bd628/net/test/spawned_test_server/remote_test_server.cc
[modify] https://crrev.com/937d6ebafe744ecccf79cf6015e7e861c82bd628/net/test/spawned_test_server/remote_test_server.h
[add] https://crrev.com/937d6ebafe744ecccf79cf6015e7e861c82bd628/net/test/spawned_test_server/remote_test_server_config.cc
[add] https://crrev.com/937d6ebafe744ecccf79cf6015e7e861c82bd628/net/test/spawned_test_server/remote_test_server_config.h
[modify] https://crrev.com/937d6ebafe744ecccf79cf6015e7e861c82bd628/net/test/spawned_test_server/spawner_communicator.cc
[modify] https://crrev.com/937d6ebafe744ecccf79cf6015e7e861c82bd628/net/test/spawned_test_server/spawner_communicator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5

commit d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5
Author: Sergey Ulanov <sergeyu@google.com>
Date: Tue Aug 29 01:05:22 2017

Update test server spawner to run multiple test servers in parallel

Previously test server spawner didn't allow running more than one test
server. With this change it's now possible to run multiple tests that
depend on test_server in parallel.
 1. Updated chrome_test_launch_spawner.py to support more than one
    test server. /kill now requires a get parameter to specify which
    server should be killed. Number of concurrent test servers is
    specified by test runner which instantiates the spawner.
 2. Updated test runners for Android and Fuchsia to pass the new
    max_servers parameter for the spawner to match test parallelism
    on these platforms (1 on Android, 4 on Fuchsia).

Bug:  731302 
Change-Id: I2e0e0c79dddb0b9f3745a444aae28e9235c3f126
Reviewed-on: https://chromium-review.googlesource.com/627339
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497967}
[modify] https://crrev.com/d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5/build/android/pylib/local/local_test_server_spawner.py
[modify] https://crrev.com/d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5/build/fuchsia/runner_common.py
[modify] https://crrev.com/d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5/build/fuchsia/test_runner.py
[modify] https://crrev.com/d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5/build/util/lib/common/chrome_test_server_spawner.py
[modify] https://crrev.com/d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5/net/test/spawned_test_server/remote_test_server.cc
[modify] https://crrev.com/d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5/net/test/spawned_test_server/spawner_communicator.cc
[modify] https://crrev.com/d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5/net/test/spawned_test_server/spawner_communicator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/690dbd0f33566dfbeba1a9b88e6911adcfb4aa34

commit 690dbd0f33566dfbeba1a9b88e6911adcfb4aa34
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Aug 29 20:09:22 2017

Revert "Update test server spawner to run multiple test servers in parallel"

This reverts commit d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5.

Reason for revert: Broke net_unittests on Cronet bots

Original change's description:
> Update test server spawner to run multiple test servers in parallel
> 
> Previously test server spawner didn't allow running more than one test
> server. With this change it's now possible to run multiple tests that
> depend on test_server in parallel.
>  1. Updated chrome_test_launch_spawner.py to support more than one
>     test server. /kill now requires a get parameter to specify which
>     server should be killed. Number of concurrent test servers is
>     specified by test runner which instantiates the spawner.
>  2. Updated test runners for Android and Fuchsia to pass the new
>     max_servers parameter for the spawner to match test parallelism
>     on these platforms (1 on Android, 4 on Fuchsia).
> 
> Bug:  731302 
> Change-Id: I2e0e0c79dddb0b9f3745a444aae28e9235c3f126
> Reviewed-on: https://chromium-review.googlesource.com/627339
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497967}

TBR=phajdan.jr@chromium.org,mmenke@chromium.org,sergeyu@chromium.org,jbudorick@chromium.org

Change-Id: Ia8fbe198eddd3900665b18192f9ebfd0a2f08c75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  731302 
Reviewed-on: https://chromium-review.googlesource.com/642150
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498212}
[modify] https://crrev.com/690dbd0f33566dfbeba1a9b88e6911adcfb4aa34/build/android/pylib/local/local_test_server_spawner.py
[modify] https://crrev.com/690dbd0f33566dfbeba1a9b88e6911adcfb4aa34/build/fuchsia/runner_common.py
[modify] https://crrev.com/690dbd0f33566dfbeba1a9b88e6911adcfb4aa34/build/fuchsia/test_runner.py
[modify] https://crrev.com/690dbd0f33566dfbeba1a9b88e6911adcfb4aa34/build/util/lib/common/chrome_test_server_spawner.py
[modify] https://crrev.com/690dbd0f33566dfbeba1a9b88e6911adcfb4aa34/net/test/spawned_test_server/remote_test_server.cc
[modify] https://crrev.com/690dbd0f33566dfbeba1a9b88e6911adcfb4aa34/net/test/spawned_test_server/spawner_communicator.cc
[modify] https://crrev.com/690dbd0f33566dfbeba1a9b88e6911adcfb4aa34/net/test/spawned_test_server/spawner_communicator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62cf685519caeaffb848879e549b0e2dac11d25c

commit 62cf685519caeaffb848879e549b0e2dac11d25c
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Aug 30 20:39:23 2017

Reland "Update test server spawner to run multiple test servers in parallel"

This is a reland of d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5
Original change's description:
> Update test server spawner to run multiple test servers in parallel
> 
> Previously test server spawner didn't allow running more than one test
> server. With this change it's now possible to run multiple tests that
> depend on test_server in parallel.
>  1. Updated chrome_test_launch_spawner.py to support more than one
>     test server. /kill now requires a get parameter to specify which
>     server should be killed. Number of concurrent test servers is
>     specified by test runner which instantiates the spawner.
>  2. Updated test runners for Android and Fuchsia to pass the new
>     max_servers parameter for the spawner to match test parallelism
>     on these platforms (1 on Android, 4 on Fuchsia).
> 
> Bug:  731302 
> Change-Id: I2e0e0c79dddb0b9f3745a444aae28e9235c3f126
> Reviewed-on: https://chromium-review.googlesource.com/627339
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497967}

TBR=mmenke@chromium.org

Bug:  731302 
Change-Id: I153632cf1fc946f0543a55108555644993a942a5
Reviewed-on: https://chromium-review.googlesource.com/642151
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498596}
[modify] https://crrev.com/62cf685519caeaffb848879e549b0e2dac11d25c/build/android/pylib/local/local_test_server_spawner.py
[modify] https://crrev.com/62cf685519caeaffb848879e549b0e2dac11d25c/build/fuchsia/runner_common.py
[modify] https://crrev.com/62cf685519caeaffb848879e549b0e2dac11d25c/build/fuchsia/test_runner.py
[modify] https://crrev.com/62cf685519caeaffb848879e549b0e2dac11d25c/build/util/lib/common/chrome_test_server_spawner.py
[modify] https://crrev.com/62cf685519caeaffb848879e549b0e2dac11d25c/net/test/spawned_test_server/remote_test_server.cc
[modify] https://crrev.com/62cf685519caeaffb848879e549b0e2dac11d25c/net/test/spawned_test_server/spawner_communicator.cc
[modify] https://crrev.com/62cf685519caeaffb848879e549b0e2dac11d25c/net/test/spawned_test_server/spawner_communicator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4039bfa76af61b9ca5ba2f390852b0bf8d36ffd9

commit 4039bfa76af61b9ca5ba2f390852b0bf8d36ffd9
Author: Sergey Ulanov <sergeyu@google.com>
Date: Thu Aug 31 20:00:46 2017

Implement TestRootCerts and add SystemTrustStore stub for Fuchsia.

1. Updated TestRootCerts to store list of temporary certs in memory.
2. Added SystemTrustStoreFuchsia. Currently it contains only certs
   added to TestRootCerts. Will extend it to load system certs in a
   separate CL.

Bug:  731302 
Change-Id: Id6e1c526f92f1cc256fbf8545c8b6b20190f288b
Reviewed-on: https://chromium-review.googlesource.com/643448
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498962}
[modify] https://crrev.com/4039bfa76af61b9ca5ba2f390852b0bf8d36ffd9/net/cert/internal/system_trust_store.cc
[modify] https://crrev.com/4039bfa76af61b9ca5ba2f390852b0bf8d36ffd9/net/cert/test_root_certs.h
[modify] https://crrev.com/4039bfa76af61b9ca5ba2f390852b0bf8d36ffd9/net/cert/test_root_certs_fuchsia.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a0b019faa115d77d3836552501a6833b57c940c

commit 2a0b019faa115d77d3836552501a6833b57c940c
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Aug 31 23:09:40 2017

Add RemoteTestServerProxy to proxy test server connections to a remote IP.

Many tests that use test server assume that the server runs on
localhost. RemoteTestServer was previously used only on Android and
there connections are forwarded to the host using adb. The same
approach is not feasible on Fuchsia because there is no adb. This CL
adds RemoteTestServerProxy which will forward connections from
localhost to a remote testserve address.

Bug:  731302 
Change-Id: I84a93ba9435f0b3bd514b02178754e30a51270b1
Reviewed-on: https://chromium-review.googlesource.com/636864
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499064}
[modify] https://crrev.com/2a0b019faa115d77d3836552501a6833b57c940c/net/BUILD.gn
[modify] https://crrev.com/2a0b019faa115d77d3836552501a6833b57c940c/net/test/spawned_test_server/base_test_server.cc
[modify] https://crrev.com/2a0b019faa115d77d3836552501a6833b57c940c/net/test/spawned_test_server/base_test_server.h
[modify] https://crrev.com/2a0b019faa115d77d3836552501a6833b57c940c/net/test/spawned_test_server/local_test_server_posix.cc
[modify] https://crrev.com/2a0b019faa115d77d3836552501a6833b57c940c/net/test/spawned_test_server/local_test_server_win.cc
[modify] https://crrev.com/2a0b019faa115d77d3836552501a6833b57c940c/net/test/spawned_test_server/remote_test_server.cc
[modify] https://crrev.com/2a0b019faa115d77d3836552501a6833b57c940c/net/test/spawned_test_server/remote_test_server.h
[add] https://crrev.com/2a0b019faa115d77d3836552501a6833b57c940c/net/test/spawned_test_server/remote_test_server_proxy.cc
[add] https://crrev.com/2a0b019faa115d77d3836552501a6833b57c940c/net/test/spawned_test_server/remote_test_server_proxy.h
[add] https://crrev.com/2a0b019faa115d77d3836552501a6833b57c940c/net/test/spawned_test_server/remote_test_server_proxy_unittests.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c6541d70ddac34c1ee91a28218bc4582d1161d7

commit 3c6541d70ddac34c1ee91a28218bc4582d1161d7
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Aug 31 23:59:52 2017

Add unittests for File::Write(nullptr, 0)

File::Write(nullptr, 0) works and it is used by some code in chrome,
but there were no explicit tests for it. Add unittests to make sure it
doesn't break again.

Bug:  731302 
Change-Id: I36fcd083c7d1f0e360e8887d487537d8b1c012f9
Reviewed-on: https://chromium-review.googlesource.com/646729
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499076}
[modify] https://crrev.com/3c6541d70ddac34c1ee91a28218bc4582d1161d7/base/files/file.h
[modify] https://crrev.com/3c6541d70ddac34c1ee91a28218bc4582d1161d7/base/files/file_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3614654957b3b1b9794eb2a11d6a5077cc6e1ef9

commit 3614654957b3b1b9794eb2a11d6a5077cc6e1ef9
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Sep 01 00:49:26 2017

Enable more net_unittests on Fuchsia

* Enabled some tests that were failing, but should pass now.
* Enabled tests that were disabled due to slow QEMU.

NOTRY=true

Bug:  731302 
Change-Id: I1a096ff755a0315595dbc37ed8527fde0452cefb
Reviewed-on: https://chromium-review.googlesource.com/646751
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499084}
[modify] https://crrev.com/3614654957b3b1b9794eb2a11d6a5077cc6e1ef9/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/932f5caf2ea66efa55d81af1f00e9f26b3aadb9a

commit 932f5caf2ea66efa55d81af1f00e9f26b3aadb9a
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Sep 05 21:36:02 2017

Update RemoteTestServer to support asynchronous startup.

LocalTestServer allows to start testserver asynchronously, but
RemoteTestServer didn't support it. This feature is used by some
unittests that need to run multiple instances of the server. Currently
these tests are disabled on Android. This change will allow to enable
them on Android and on Fuchsia.

Replaced SpawnedCommunicator with RemoteTestServerSpawnerRequest.
The new class is asynchronous and sends only one request. This makes
it easier to track request state in RemoteTestServer for asynchronous
operations.

Bug:  731302 
Change-Id: I6e8f43cecf753a923a418ded972917adb4c56c12
Reviewed-on: https://chromium-review.googlesource.com/640130
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499755}
[modify] https://crrev.com/932f5caf2ea66efa55d81af1f00e9f26b3aadb9a/net/BUILD.gn
[modify] https://crrev.com/932f5caf2ea66efa55d81af1f00e9f26b3aadb9a/net/test/spawned_test_server/base_test_server.cc
[modify] https://crrev.com/932f5caf2ea66efa55d81af1f00e9f26b3aadb9a/net/test/spawned_test_server/base_test_server.h
[modify] https://crrev.com/932f5caf2ea66efa55d81af1f00e9f26b3aadb9a/net/test/spawned_test_server/local_test_server.cc
[modify] https://crrev.com/932f5caf2ea66efa55d81af1f00e9f26b3aadb9a/net/test/spawned_test_server/local_test_server.h
[modify] https://crrev.com/932f5caf2ea66efa55d81af1f00e9f26b3aadb9a/net/test/spawned_test_server/remote_test_server.cc
[modify] https://crrev.com/932f5caf2ea66efa55d81af1f00e9f26b3aadb9a/net/test/spawned_test_server/remote_test_server.h
[add] https://crrev.com/932f5caf2ea66efa55d81af1f00e9f26b3aadb9a/net/test/spawned_test_server/remote_test_server_spawner_request.cc
[add] https://crrev.com/932f5caf2ea66efa55d81af1f00e9f26b3aadb9a/net/test/spawned_test_server/remote_test_server_spawner_request.h
[delete] https://crrev.com/509dfd6cb0a5dcbbcbd8680923165b2b1d3d01ee/net/test/spawned_test_server/spawner_communicator.cc
[delete] https://crrev.com/509dfd6cb0a5dcbbcbd8680923165b2b1d3d01ee/net/test/spawned_test_server/spawner_communicator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/352e8c6348de4b3bf411dff3310890ca93123da5

commit 352e8c6348de4b3bf411dff3310890ca93123da5
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Sep 06 06:22:38 2017

Enable more net_unittests on Fuchsia

Enabled tests that use test server, now that RemoteTestServer
should work properly on Fuchsia.

Bug:  731302 
Change-Id: I8f3d4f8a4a1b7902f3706d78288234eb34212f87
Reviewed-on: https://chromium-review.googlesource.com/651386
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499894}
[modify] https://crrev.com/352e8c6348de4b3bf411dff3310890ca93123da5/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/884169a08ef299ce74b811f033605e4f49be51dc

commit 884169a08ef299ce74b811f033605e4f49be51dc
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Sep 06 18:58:02 2017

Enable HTTPS tests on Fuchsia

Enabled HTTPS* tests on Fuchsia, since they should pass now. Updated
unittests for OCSP, AIA and CRL set, since these features are not
implemented in CertVerifyProcBuiltin.

Bug:  731302 ,  762380 
Change-Id: I5e4d3affe9783c502330d8784eb866a78ddd755e
Reviewed-on: https://chromium-review.googlesource.com/651606
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500025}
[modify] https://crrev.com/884169a08ef299ce74b811f033605e4f49be51dc/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/884169a08ef299ce74b811f033605e4f49be51dc/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/009a09061bcfb606c9f574bde74d8faf83de8663

commit 009a09061bcfb606c9f574bde74d8faf83de8663
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Sep 07 20:13:11 2017

Roll Fuchsia SDK to 0a2d4198189795c3e67383e2d97c789db69b6c87

The new SDK includes fix for UDP sockets, see
https://fuchsia-review.googlesource.com/#/c/garnet/+/59525/

NOTRY=true

Bug: 707030,  731302 
Change-Id: Ie51b9b8982a42cf6cfeadbe59d1360abb3a962c0
Reviewed-on: https://chromium-review.googlesource.com/655797
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500365}
[modify] https://crrev.com/009a09061bcfb606c9f574bde74d8faf83de8663/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e30ddfa79c548cd940b42ab23abf502dce07b6a8

commit e30ddfa79c548cd940b42ab23abf502dce07b6a8
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Sep 07 23:20:24 2017

Fix HttpServerTest to handle syncronous Connect().

Previously TestHttpClient used in HttpServerTest would hang when
Connect() completes synchronously. Connect() is currently synchronous
on Fuchsia (which is a bug). Updated the test to use
TestCompletiongCallback, which makes code simpler and allows to handle
synchronous completion properly. Also removed these tests from the test
filter on Fuchsia

Bug:  731302 
Change-Id: I6f750e6f37782385bfaab003e194c434aaf0e0fe
Reviewed-on: https://chromium-review.googlesource.com/655942
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500430}
[modify] https://crrev.com/e30ddfa79c548cd940b42ab23abf502dce07b6a8/net/server/http_server_unittest.cc
[modify] https://crrev.com/e30ddfa79c548cd940b42ab23abf502dce07b6a8/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03ae8b26cac782874390cadc5fd5faa6025cf5ba

commit 03ae8b26cac782874390cadc5fd5faa6025cf5ba
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Sep 08 04:22:51 2017

Enable QuicEndToEnd and TokenBindingURLRequest tests on Fuchsia

These tests pass now and can be enabled.

NOTRY=true

Bug:  731302 
Change-Id: I7a2bdb6820efa6a0d418f727f7370ee7f81a723c
Reviewed-on: https://chromium-review.googlesource.com/656457
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500506}
[modify] https://crrev.com/03ae8b26cac782874390cadc5fd5faa6025cf5ba/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a337dcd89c49d249cb19ec1e39036b68e1522a01

commit a337dcd89c49d249cb19ec1e39036b68e1522a01
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Sep 08 20:53:14 2017

Enable WebSocket unittests on Fuchsia

Enabled WebSocket* unittests on Fuchsia, except those that were
disabled on Android, as these are currently not compatible with
RemoteTestServer.

NOTRY=true

Bug: 441711,  731302 
Change-Id: I0cf09e8c2c85ce638beec78b804ab9dff4ad65f8
Reviewed-on: https://chromium-review.googlesource.com/656600
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500654}
[modify] https://crrev.com/a337dcd89c49d249cb19ec1e39036b68e1522a01/net/websockets/websocket_end_to_end_test.cc
[modify] https://crrev.com/a337dcd89c49d249cb19ec1e39036b68e1522a01/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d1a427420e4ae3d6b0d1d73a8ab11b8d8be8361

commit 2d1a427420e4ae3d6b0d1d73a8ab11b8d8be8361
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Sep 08 21:39:48 2017

Add UDPSocketTest.PartialRecv unittests. Unittest cleanups.

1. Added new unittests that Recv() with small buffer discards rest of
   the message as expected. This test was failing on Fuchsia due to
   a bug (see NET-169).
2. Minor unittests cleanups. Particularly removed partial send/write
   handling from SendToSocket() and  WriteToSocket() because these
   operations are always atomic for UDP sockets.

Bug:  731302 
Change-Id: I311bb7d185f7e811df57cfb2cbdbb184aacf62c0
Reviewed-on: https://chromium-review.googlesource.com/653817
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500698}
[modify] https://crrev.com/2d1a427420e4ae3d6b0d1d73a8ab11b8d8be8361/net/socket/udp_socket_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c786d33ad7886c8d656ded42b68b4d0746b6881

commit 4c786d33ad7886c8d656ded42b68b4d0746b6881
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Sep 08 22:53:25 2017

Enable WebSocketEndToEndTests with RemoteTestServer

1. Added ws server type in test server spawner.
2. Fixed a bug in testserver.py which prevented it from loading certs
   with relative paths (because it has to chdir to the working dir)
3. Enabled some tests on Android and Fuchsia. The two tests that are
   still disabled depend on basic-auth-proxy mode in testserver, which
   doesn't work with RemoteTestServer.

Bug: 441711,  731302 
Change-Id: Id8346111f260ead648a98b0854669d1211fe3393
Reviewed-on: https://chromium-review.googlesource.com/656758
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500722}
[modify] https://crrev.com/4c786d33ad7886c8d656ded42b68b4d0746b6881/build/util/lib/common/chrome_test_server_spawner.py
[modify] https://crrev.com/4c786d33ad7886c8d656ded42b68b4d0746b6881/net/tools/testserver/testserver.py
[modify] https://crrev.com/4c786d33ad7886c8d656ded42b68b4d0746b6881/net/websockets/websocket_end_to_end_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2fd4ab556f8cfbb2b33a17c356af6569192e0b5

commit b2fd4ab556f8cfbb2b33a17c356af6569192e0b5
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Sat Sep 09 00:32:17 2017

Fix MessagePumpFuchsia to call DoIdleWork() only after IO events.

Previously MessagePumpFuchsia was running DoIdleWork() before handling
any IO events. As result RunUntilIdle() wasn't handling IO events,
which was breaking some unittests.

Enabled URLRequestTestHTTP.HeadersCallbacks, which was broken by this
bug.

TBR=dcheng@chromium.org

Bug:  731302 
Change-Id: I85ecfb3be725f4e10ba4afb754b1c7ac31da50da
Reviewed-on: https://chromium-review.googlesource.com/656578
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500757}
[modify] https://crrev.com/b2fd4ab556f8cfbb2b33a17c356af6569192e0b5/base/message_loop/message_loop_io_posix_unittest.cc
[modify] https://crrev.com/b2fd4ab556f8cfbb2b33a17c356af6569192e0b5/base/message_loop/message_pump_fuchsia.cc
[modify] https://crrev.com/b2fd4ab556f8cfbb2b33a17c356af6569192e0b5/base/message_loop/message_pump_fuchsia.h
[modify] https://crrev.com/b2fd4ab556f8cfbb2b33a17c356af6569192e0b5/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4de6f1393f7efa9e4ff45254e402dbabb4727030

commit 4de6f1393f7efa9e4ff45254e402dbabb4727030
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Sep 11 23:33:19 2017

Roll Fuchsia SDK to d7db7f4e971de73ccec78eaf6c34a0f424e8831f

Following issues are fixed in this version:
1. NET-170: MSG_TRUNC support in recvmsg().
2. NET-120: asynchronous connect().

NOTRY=true

Bug:  731302 , 707030
Change-Id: I74047a9d86fe4bce6c384658676903b115ed437a
Reviewed-on: https://chromium-review.googlesource.com/661298
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501096}
[modify] https://crrev.com/4de6f1393f7efa9e4ff45254e402dbabb4727030/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1c3ca49ed7f55362c6ee4b008a7f7f43213fa69

commit f1c3ca49ed7f55362c6ee4b008a7f7f43213fa69
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Sep 12 21:18:04 2017

Revert "Roll Fuchsia SDK to d7db7f4e971de73ccec78eaf6c34a0f424e8831f"

This reverts commit 4de6f1393f7efa9e4ff45254e402dbabb4727030.

Reason for revert: net_unittests failures

Original change's description:
> Roll Fuchsia SDK to d7db7f4e971de73ccec78eaf6c34a0f424e8831f
> 
> Following issues are fixed in this version:
> 1. NET-170: MSG_TRUNC support in recvmsg().
> 2. NET-120: asynchronous connect().
> 
> NOTRY=true
> 
> Bug:  731302 , 707030
> Change-Id: I74047a9d86fe4bce6c384658676903b115ed437a
> Reviewed-on: https://chromium-review.googlesource.com/661298
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501096}

TBR=sergeyu@chromium.org,scottmg@chromium.org

Change-Id: I30e9140ea3d7a1119a234e74828d527b9214c782
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  731302 , 707030
Reviewed-on: https://chromium-review.googlesource.com/663498
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501400}
[modify] https://crrev.com/f1c3ca49ed7f55362c6ee4b008a7f7f43213fa69/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/379cb2841871fafb96f73c02afc244081a72648d

commit 379cb2841871fafb96f73c02afc244081a72648d
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Sep 12 21:30:14 2017

Disable UDPSocketTest.PartialRecv on Fuchsia

UDPSocketTest.PartialRecv depends on MSG_TRUNC, which wasn't supported
in older versions of SDK. The test needs to be disabled temporarily
because the recent SDK roll had to be reverted.

TBR=scottmg@chromium.org
NOTRY=true

Bug:  731302 
Change-Id: I5b4ec03ccabb60d1719ce2088831183a8a54c045
Reviewed-on: https://chromium-review.googlesource.com/662881
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501403}
[modify] https://crrev.com/379cb2841871fafb96f73c02afc244081a72648d/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d160bd7e0b1f72a762160f324ee106dd3de25678

commit d160bd7e0b1f72a762160f324ee106dd3de25678
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Sep 12 22:04:40 2017

Fix test flakiness in DiskCache tests caused by MessageLoopHelper

Previously MessageLoopHelper was starting a periodic timer that quits 
a run loop. It kept that timer running even after
WaitUntilCacheIoFinished() returns and used QuitCurrentWhenIdleDeprecated().
As result MessageLoopHelper::TimerExpired() would sometimes quit a RunLoop
that's not owned by MessageLoopHelper. This made DiskCache*AsyncIO* tests
flaky on Fuchsia. This change fixes both problems: the timer is stopped
after WaitUntilCacheIoFinished() returns and TimerExpired() uses
RunLoop::Quit(), so it won't quit a wrong RunLoop.

Bug:  731302 
Change-Id: Ie7f7444c7f1bb662c1de511cae3de0a9efc46349
Reviewed-on: https://chromium-review.googlesource.com/661357
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501422}
[modify] https://crrev.com/d160bd7e0b1f72a762160f324ee106dd3de25678/net/disk_cache/disk_cache_test_util.cc
[modify] https://crrev.com/d160bd7e0b1f72a762160f324ee106dd3de25678/net/disk_cache/disk_cache_test_util.h
[modify] https://crrev.com/d160bd7e0b1f72a762160f324ee106dd3de25678/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64c58efa3aed07d91386df0aef80e22853bde906

commit 64c58efa3aed07d91386df0aef80e22853bde906
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Sep 12 23:56:13 2017

Enable SQLite and CertVerifyProcInternal tests in net_unittests on Fuchsia

These tests pass after https://crrev.com/501346

Bug:  731302 
Change-Id: I4c6639e59f4270933aaf66a9a25ffac8beb3761f
Reviewed-on: https://chromium-review.googlesource.com/662922
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501461}
[modify] https://crrev.com/64c58efa3aed07d91386df0aef80e22853bde906/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21dea15ba6117af0b06bd89c6dd6f427a016423d

commit 21dea15ba6117af0b06bd89c6dd6f427a016423d
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Sep 13 00:50:50 2017

Disable UnixDomain[Client|Server]Socket on Fuchsia.

Previously the classes for Unix domain sockets were compiled on all
POSIX platforms, except NaCl, but the tests were disabled on iOS and
filtered on Fuchsia. This change disabled compilation of these classes
and unittests on all platforms on which they are not supported (iOS,
Fuchsia and NaCl).

Bug:  731302 
Change-Id: I1da281845fd282d0f791cc4a324ef3d233f8a598
Reviewed-on: https://chromium-review.googlesource.com/664157
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501490}
[modify] https://crrev.com/21dea15ba6117af0b06bd89c6dd6f427a016423d/net/BUILD.gn
[modify] https://crrev.com/21dea15ba6117af0b06bd89c6dd6f427a016423d/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4580e7e30e66a06a71ff260579c299fe1e625d1

commit c4580e7e30e66a06a71ff260579c299fe1e625d1
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Sep 13 23:30:11 2017

Disable URLRequest FTP tests on Fuchsia

FTP is not compatible with RemoteTestServer, so these tests have to be
disabled on Fuchsia as they were disabled on Android.

Bug:  495220 ,  731302 
Change-Id: I585669ccee2d3fbd11a130bd38d84b32437a3477
Reviewed-on: https://chromium-review.googlesource.com/662960
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501798}
[modify] https://crrev.com/c4580e7e30e66a06a71ff260579c299fe1e625d1/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/c4580e7e30e66a06a71ff260579c299fe1e625d1/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e49f498ca48a78e6a2227748e661be67144bd4d

commit 2e49f498ca48a78e6a2227748e661be67144bd4d
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Sep 14 19:37:51 2017

Avoid reading test binary in URLRequestTest.FileTest

Previously URLRequestTest.FileTest was reading test binary. Because
the binary can be big the test takes significant amount of time to run.
Fuchsia bots run these tests under qemu where IO is slow, so the test
is flaky and timeout sometimes (it takes more than 45 seconds to load
the whole file). Also the test was reading /etc/hosts on Android which
doesn't look like a good solution either. Updated this and other tests
for file URL loader to create a temporary file.

Bug:  731302 
Change-Id: Icdbacc4ccdcd77e44c5174f34d771cd283f71f82
Reviewed-on: https://chromium-review.googlesource.com/665557
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502015}
[modify] https://crrev.com/2e49f498ca48a78e6a2227748e661be67144bd4d/net/url_request/url_request_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f3d3357977bcbec1957dcad7cf1fb9280cc2c3a

commit 0f3d3357977bcbec1957dcad7cf1fb9280cc2c3a
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Sep 18 19:32:07 2017

Fix flake in HostCacheTest.SerializeAndDeserialize on Fuchsia

SerializeAndDeserialize serializes and deserializes cache state to JSON.
the serializer use base::Time for serialized time values, while
internally the same values are stored and compared as base::TimeTicks.
The test was assumming that base::Time and base::TimeTicks cannot drift
more than 1 ms. This assumption fails when more than 1 ms passes between
the two Now() calls, which can easily happen when the process gets
preempted after the first Now() call. This test fails sometimes on
Fuchsia, where the test are executed under qemu.
This CL relaxes the restrictions to 100ms, which will make this test less
flaky.

Bug:  731302 
Change-Id: I86ea3d44e059f18cc5e7d0816e30289603782a09
Reviewed-on: https://chromium-review.googlesource.com/671645
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502638}
[modify] https://crrev.com/0f3d3357977bcbec1957dcad7cf1fb9280cc2c3a/net/dns/host_cache_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec1d3dea2948381ad6fca72a75ea061aaa7952da

commit ec1d3dea2948381ad6fca72a75ea061aaa7952da
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Sep 19 19:27:47 2017

Stop compiling PythonUtils on Android, iOS and Fuchsia.

Python doesn't work on Android, iOS and Fuchsia, so it doesn't make sense
to compile PythonUtils there. 
Also disabled compilation of LocalTestServer and LocalSyncTestServer
on Android because they are not used there.

Bug:  731302 
Change-Id: I35361cbd79f10bca5122b375a63ab1ac0e31d7bf
Reviewed-on: https://chromium-review.googlesource.com/663100
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502916}
[modify] https://crrev.com/ec1d3dea2948381ad6fca72a75ea061aaa7952da/BUILD.gn
[modify] https://crrev.com/ec1d3dea2948381ad6fca72a75ea061aaa7952da/chrome/browser/BUILD.gn
[modify] https://crrev.com/ec1d3dea2948381ad6fca72a75ea061aaa7952da/components/sync/BUILD.gn
[modify] https://crrev.com/ec1d3dea2948381ad6fca72a75ea061aaa7952da/net/BUILD.gn
[modify] https://crrev.com/ec1d3dea2948381ad6fca72a75ea061aaa7952da/net/test/python_utils_unittest.cc
[modify] https://crrev.com/ec1d3dea2948381ad6fca72a75ea061aaa7952da/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fb900cc0e300dd544206a2c65a2a4c3d7bfbdce

commit 0fb900cc0e300dd544206a2c65a2a4c3d7bfbdce
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Sep 20 00:27:31 2017

Cleanup fuchsia.net_unittests.filter

- Enabled URLRequestQuic*, UDPSocketTest.PartialRecv and
CloseOnConnectHttpServerTest.ServerImmediatelyClosesConnection.
- Disabled URLRequestTestHTTP.GetTest_ManyCookies instead of filtering
it (also fails on Windows).
- Added comments for other filtered tests.

TBR=mmenke@chromium.org

Bug:  731302 
Change-Id: I5b75159462c1c636bd2979b57c1bef69018e571c
Reviewed-on: https://chromium-review.googlesource.com/658677
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503004}
[modify] https://crrev.com/0fb900cc0e300dd544206a2c65a2a4c3d7bfbdce/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/0fb900cc0e300dd544206a2c65a2a4c3d7bfbdce/testing/buildbot/filters/fuchsia.net_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67e676e2b90a38398d0ba809029d5460339b456f

commit 67e676e2b90a38398d0ba809029d5460339b456f
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Sep 25 19:37:09 2017

Load system-provided root certificates on Fuchsia

Now SystemTrustStoreFuchsia loads root certs from
/system/data/boringssl/cert.pem .

Bug:  731302 
Change-Id: I39c48388f03284cc5f2d37f34496ba763491b2e7
Reviewed-on: https://chromium-review.googlesource.com/644826
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504131}
[modify] https://crrev.com/67e676e2b90a38398d0ba809029d5460339b456f/net/cert/internal/system_trust_store.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e4a3e9fc974b2c0267aba091ef3effe8ebcd3ca

commit 9e4a3e9fc974b2c0267aba091ef3effe8ebcd3ca
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Sep 26 16:55:27 2017

Roll Fuchsia SDK to 36d9ffb6bda53112e826941757efe04654050d46

This version:
 - Fixes getaddrinfo().
 - Adds media_client library.

TBR=yzshen@chromium.org
NOTRY=true

Bug: 707030,  737802 ,  731302 
Change-Id: I271d9681194d81d2979635784b3f0ca2c0a946d0
Reviewed-on: https://chromium-review.googlesource.com/683311
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504401}
[modify] https://crrev.com/9e4a3e9fc974b2c0267aba091ef3effe8ebcd3ca/DEPS
[modify] https://crrev.com/9e4a3e9fc974b2c0267aba091ef3effe8ebcd3ca/mojo/edk/embedder/platform_handle.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/232f0079a6d8414bd65a9caccf9bd3fd1d96ad9c

commit 232f0079a6d8414bd65a9caccf9bd3fd1d96ad9c
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Sun May 06 08:20:22 2018

Enable couple of net_unittests on fuchsia that were timing out previously

The tests are not expected to timeout anymore with TSC clock

Bug:  731302 
Change-Id: I747383b85fec029b9edfe375ed436b1586a2a544
Reviewed-on: https://chromium-review.googlesource.com/1045620
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556353}
[modify] https://crrev.com/232f0079a6d8414bd65a9caccf9bd3fd1d96ad9c/testing/buildbot/filters/fuchsia.net_unittests.filter