New issue
Advanced search Search tips

Issue 731295 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Improve first-run experience when in Finch condition

Project Member Reported by k...@chromium.org, Jun 8 2017

Issue description

We should avoid having to restart Chrome when the user goes through the FRE experience.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd3ce8c51b5b17427615582a9566bc0afa3d1907

commit fd3ce8c51b5b17427615582a9566bc0afa3d1907
Author: tedchoc <tedchoc@chromium.org>
Date: Fri Jun 16 22:07:03 2017

[Chrome Home] Avoid restart if experiment enabled after FRE.

When determining if Chrome Home is enabled, check if the native
libraries have been initialized by the time the feature boolean is
first read (i.e. because FRE already happened and init'd the browser
process).  If the libraries have been initialized, also check the
finch flag value to determine if we should show Chrome home.

TEST=1.) Clear data, kill Chrome
     2.) build/android/adb_chrome_public_command_line "--enable-features=ChromeHome"
     3.) Start Chrome and proceed through FRE, see you are in Chrome Home w/o
         restarting.
BUG= 731295 

Review-Url: https://codereview.chromium.org/2946493002
Cr-Commit-Position: refs/heads/master@{#480191}

[modify] https://crrev.com/fd3ce8c51b5b17427615582a9566bc0afa3d1907/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java

Issue 713928 has been merged into this issue.
Owner: tedc...@chromium.org
Status: Fixed (was: Available)
I believe this is fixed.

We should likely have another bug where we disable the force restart logic.  Ideally, we'd do that only if you flip the flag from about://flags.  Users updating to a chrome build with the experiment enabled should probably not get a forced restart.
Issue 713928 was for the forced restart. I will de-dup.

Sign in to add a comment