We should animate appropriately when navigating from the new tab panel. Spec: https://folio.googleplex.com/bijou-cleer/170217-MotionMVP#%2FNewTabToTab.mov%3Fc=show
I don't think one you duped to is a duplicate. This bug is about navigating from an NTP and the duped bug is about opening a link in a new tab.
Attaching video demo.
LGTM
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc4f1d73db4ca8883bc568378856e3a7c05f6d78 commit dc4f1d73db4ca8883bc568378856e3a7c05f6d78 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Jun 22 19:54:08 2017 [Home] Implement new tab creation animation from tab switcher This change introduces the animation for creating a new tab from the tab switcher. A previously unused code path through StackLayout has been replaced by the logic for this animation. The primary additions are as follows: - New tab slides up in 300ms. - Existing tabs in stack move to top of screen. - Landscape mode excludes this animation. BUG= 731294 Change-Id: Iedb542f08eb75bbb50f33eee4bf5e113d4d05c56 Reviewed-on: https://chromium-review.googlesource.com/541917 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#481636} [modify] https://crrev.com/dc4f1d73db4ca8883bc568378856e3a7c05f6d78/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/dc4f1d73db4ca8883bc568378856e3a7c05f6d78/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java [modify] https://crrev.com/dc4f1d73db4ca8883bc568378856e3a7c05f6d78/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java [modify] https://crrev.com/dc4f1d73db4ca8883bc568378856e3a7c05f6d78/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java [modify] https://crrev.com/dc4f1d73db4ca8883bc568378856e3a7c05f6d78/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java [modify] https://crrev.com/dc4f1d73db4ca8883bc568378856e3a7c05f6d78/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java [modify] https://crrev.com/dc4f1d73db4ca8883bc568378856e3a7c05f6d78/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationLandscape.java [modify] https://crrev.com/dc4f1d73db4ca8883bc568378856e3a7c05f6d78/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationPortrait.java [modify] https://crrev.com/dc4f1d73db4ca8883bc568378856e3a7c05f6d78/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabController.java [modify] https://crrev.com/dc4f1d73db4ca8883bc568378856e3a7c05f6d78/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da8516be896f763c64cd895d2c0b09dbd72baa89 commit da8516be896f763c64cd895d2c0b09dbd72baa89 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Jun 22 22:40:20 2017 Revert "[Home] Implement new tab creation animation from tab switcher" This reverts commit dc4f1d73db4ca8883bc568378856e3a7c05f6d78. Reason for revert: testCloseNTP became flaky. Original change's description: > [Home] Implement new tab creation animation from tab switcher > > This change introduces the animation for creating a new tab from the > tab switcher. A previously unused code path through StackLayout has > been replaced by the logic for this animation. The primary additions > are as follows: > > - New tab slides up in 300ms. > - Existing tabs in stack move to top of screen. > - Landscape mode excludes this animation. > > BUG= 731294 > > Change-Id: Iedb542f08eb75bbb50f33eee4bf5e113d4d05c56 > Reviewed-on: https://chromium-review.googlesource.com/541917 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481636} TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org Change-Id: Iee7028fda3fc6d7dc4fbca614f9abcc4f906811d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731294 Reviewed-on: https://chromium-review.googlesource.com/545179 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#481694} [modify] https://crrev.com/da8516be896f763c64cd895d2c0b09dbd72baa89/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/da8516be896f763c64cd895d2c0b09dbd72baa89/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java [modify] https://crrev.com/da8516be896f763c64cd895d2c0b09dbd72baa89/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java [modify] https://crrev.com/da8516be896f763c64cd895d2c0b09dbd72baa89/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java [modify] https://crrev.com/da8516be896f763c64cd895d2c0b09dbd72baa89/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java [modify] https://crrev.com/da8516be896f763c64cd895d2c0b09dbd72baa89/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java [modify] https://crrev.com/da8516be896f763c64cd895d2c0b09dbd72baa89/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationLandscape.java [modify] https://crrev.com/da8516be896f763c64cd895d2c0b09dbd72baa89/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationPortrait.java [modify] https://crrev.com/da8516be896f763c64cd895d2c0b09dbd72baa89/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabController.java [modify] https://crrev.com/da8516be896f763c64cd895d2c0b09dbd72baa89/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java
Issue 736137 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6320ff4c5350c77ba43e49ed3c745f5a77ebe079 commit 6320ff4c5350c77ba43e49ed3c745f5a77ebe079 Author: Matthew Jones <mdjones@chromium.org> Date: Mon Jun 26 20:45:13 2017 Revert "Revert "[Home] Implement new tab creation animation from tab switcher"" This reverts commit da8516be896f763c64cd895d2c0b09dbd72baa89. Reason for revert: Removing obsolete test asserts. Original change's description: > Revert "[Home] Implement new tab creation animation from tab switcher" > > This reverts commit dc4f1d73db4ca8883bc568378856e3a7c05f6d78. > > Reason for revert: testCloseNTP became flaky. > > Original change's description: > > [Home] Implement new tab creation animation from tab switcher > > > > This change introduces the animation for creating a new tab from the > > tab switcher. A previously unused code path through StackLayout has > > been replaced by the logic for this animation. The primary additions > > are as follows: > > > > - New tab slides up in 300ms. > > - Existing tabs in stack move to top of screen. > > - Landscape mode excludes this animation. > > > > BUG= 731294 > > > > Change-Id: Iedb542f08eb75bbb50f33eee4bf5e113d4d05c56 > > Reviewed-on: https://chromium-review.googlesource.com/541917 > > Commit-Queue: Matthew Jones <mdjones@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#481636} > > TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org > > Change-Id: Iee7028fda3fc6d7dc4fbca614f9abcc4f906811d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 731294 > Reviewed-on: https://chromium-review.googlesource.com/545179 > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481694} TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org Change-Id: I23c541c120d3f1bb442ad9d0632fb294ecb87b6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731294 Reviewed-on: https://chromium-review.googlesource.com/546838 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#482386} [modify] https://crrev.com/6320ff4c5350c77ba43e49ed3c745f5a77ebe079/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/6320ff4c5350c77ba43e49ed3c745f5a77ebe079/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java [modify] https://crrev.com/6320ff4c5350c77ba43e49ed3c745f5a77ebe079/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java [modify] https://crrev.com/6320ff4c5350c77ba43e49ed3c745f5a77ebe079/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java [modify] https://crrev.com/6320ff4c5350c77ba43e49ed3c745f5a77ebe079/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java [modify] https://crrev.com/6320ff4c5350c77ba43e49ed3c745f5a77ebe079/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java [modify] https://crrev.com/6320ff4c5350c77ba43e49ed3c745f5a77ebe079/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationLandscape.java [modify] https://crrev.com/6320ff4c5350c77ba43e49ed3c745f5a77ebe079/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationPortrait.java [modify] https://crrev.com/6320ff4c5350c77ba43e49ed3c745f5a77ebe079/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabController.java [modify] https://crrev.com/6320ff4c5350c77ba43e49ed3c745f5a77ebe079/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java
Comment 1 by mdjones@chromium.org
, Jun 9 2017Status: Duplicate (was: Available)