New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731291 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 704556



Sign in to add a comment

Placeholder images should have text showing original resource size of image

Project Member Reported by sclit...@chromium.org, Jun 8 2017

Issue description

See spec: https://docs.google.com/document/d/1BHeA1azbgCdZgCnr16VN2g7A9MHPQ_dwKn5szh8evMQ/edit

Placeholder images should display text showing the original resource size of the image when possible, as per the spec linked above.
 
Cc: -bbergher@chromium.org

Comment 2 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1fa322dc8f20e01750fbbaa1f910ceec13b7df2

commit e1fa322dc8f20e01750fbbaa1f910ceec13b7df2
Author: Scott Little <sclittle@chromium.org>
Date: Fri Jan 12 02:15:52 2018

Show text indicating the full resource size on PlaceholderImages.

This CL makes ImageResourceContent estimate the full resource size of an
image that's replaced by a placeholder image, and passes that to the
PlaceholderImage which formats and localizes the text to show it as part
of the image if there's enough room.

Placeholder image visual specifications:
https://docs.google.com/document/d/1BHeA1azbgCdZgCnr16VN2g7A9MHPQ_dwKn5szh8evMQ/edit

Bug:  731291 , 706060
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If59522dd09f142fa3fe09bc2ecc9ee5ab9d5ba41
Reviewed-on: https://chromium-review.googlesource.com/858288
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528849}
[modify] https://crrev.com/e1fa322dc8f20e01750fbbaa1f910ceec13b7df2/content/app/strings/content_strings.grd
[modify] https://crrev.com/e1fa322dc8f20e01750fbbaa1f910ceec13b7df2/content/child/blink_platform_impl.cc
[modify] https://crrev.com/e1fa322dc8f20e01750fbbaa1f910ceec13b7df2/third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp
[modify] https://crrev.com/e1fa322dc8f20e01750fbbaa1f910ceec13b7df2/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/e1fa322dc8f20e01750fbbaa1f910ceec13b7df2/third_party/WebKit/Source/platform/graphics/PlaceholderImage.cpp
[modify] https://crrev.com/e1fa322dc8f20e01750fbbaa1f910ceec13b7df2/third_party/WebKit/Source/platform/graphics/PlaceholderImage.h
[add] https://crrev.com/e1fa322dc8f20e01750fbbaa1f910ceec13b7df2/third_party/WebKit/Source/platform/graphics/PlaceholderImageTest.cpp
[modify] https://crrev.com/e1fa322dc8f20e01750fbbaa1f910ceec13b7df2/third_party/WebKit/public/platform/WebLocalizedString.h

Status: Fixed (was: Available)

Sign in to add a comment