New issue
Advanced search Search tips

Issue 731288 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Swipe from Chrome Home trigger button to open Chrome Home

Project Member Reported by k...@chromium.org, Jun 8 2017

Issue description

In order to make the gesture feel more nature while minimizing accidental swipes, would it be possible to enable the swipe gesture when swiping from the Chrome Home button (in the button trigger scenario)?
 
I'm going to start with this behind a flag (one of the swipe logic experiment variations).

Comment 2 by k...@chromium.org, Jun 12 2017

That's fine thanks!
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc0d7decd1a3ee9bfdb16d425aa46146de3ecd4c

commit fc0d7decd1a3ee9bfdb16d425aa46146de3ecd4c
Author: Matthew Jones <mdjones@chromium.org>
Date: Mon Jun 12 23:05:16 2017

[Home] Add expand button swipe experiment variation

This change adds another variation to the swipe logic experiment;
enabling swipe on the expand button. This change also generalizes the
allowed swipe range to work with or without the experiments enabled.

- "restrict-area" will only work if there is no expand button.
- "button-only" will only work if the expand button is enabled.

BUG= 731288 

Change-Id: I04f7479c91827bb0bc1019d0e86c7b75588c7c00
Reviewed-on: https://chromium-review.googlesource.com/530094
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478808}
[modify] https://crrev.com/fc0d7decd1a3ee9bfdb16d425aa46146de3ecd4c/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
[modify] https://crrev.com/fc0d7decd1a3ee9bfdb16d425aa46146de3ecd4c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/fc0d7decd1a3ee9bfdb16d425aa46146de3ecd4c/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/fc0d7decd1a3ee9bfdb16d425aa46146de3ecd4c/chrome/browser/about_flags.cc
[modify] https://crrev.com/fc0d7decd1a3ee9bfdb16d425aa46146de3ecd4c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/fc0d7decd1a3ee9bfdb16d425aa46146de3ecd4c/chrome/browser/flag_descriptions.h

Status: Fixed (was: Assigned)

Sign in to add a comment