New issue
Advanced search Search tips

Issue 731286 link

Starred by 1 user
Status: Fixed
Owner:
kainino@chromium.org
Closed: Nov 2017
Cc:
zmo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 782497



Sign in to add a comment

BackRenderbuffer path (pepper 3d?) incorrectly treats samples=1 as non-multisampled

Project Member Reported by kainino@chromium.org, Jun 8 2017 
BackRenderbuffer::AllocateStorage incorrectly treats samples=1 as a non-multisampled renderbuffer. According to the spec, samples=0 is non-multisampled but samples=1 is allowed to be upgraded to samples>1. Thus it's invalid to convert it into glRenderbufferStorage instead of glRenderbufferStorageMultisample.

Comment 1 by kainino@chromium.org, Jun 8 2017 

  // TODO(kainino): "samples <= 1" is technically incorrect (it should be
  // "samples == 0"), but it causes framebuffer incompleteness in some
  // situations. Once this is fixed, this entire arm is no longer necessary -
  // RenderbufferStorageMultisampleHelper implements it.  http://crbug.com/731286

Comment 2 by kainino@chromium.org, Nov 21 2017

Blocking: 782497
Owner: kainino@chromium.org
Status: Fixed (was: Available)
I fixed this particular instance of the problem in http://crrev.com/c/765091 but forgot to reference this bug id. I'll close this; the other bug will be for the remaining issues.
►

Sign in to add a comment