New issue
Advanced search Search tips

Issue 731283 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The metrics for the version 2 of the WebRTC echo canceller AEC2 are reported when the echo canceller version 3 is active.

Project Member Reported by peah@chromium.org, Jun 8 2017

Issue description

The metrics for the version 2 of the WebRTC echo canceller AEC2 are reported when the echo canceller version 3 is active. This is not desired, as the echo canceller 2 is not used when echo canceller 3 is active and the reported metrics will therefore be wrong. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaeebae2cdd61180c7b3d82428620a9eb922b98d

commit eaeebae2cdd61180c7b3d82428620a9eb922b98d
Author: peah <peah@chromium.org>
Date: Fri Jun 09 12:07:08 2017

Disabling logging of AEC metrics for AEC version 2 when AEC3 is active.

This CL ensures that the metrics for the WebRTC echo canceller version 2
are not logged when echo canceller version 3 is active

BUG= chromium:731283 , chromium:731633

Review-Url: https://codereview.chromium.org/2926713006
Cr-Commit-Position: refs/heads/master@{#478252}

[modify] https://crrev.com/eaeebae2cdd61180c7b3d82428620a9eb922b98d/content/renderer/media/media_stream_audio_processor.cc

Comment 2 by peah@chromium.org, Jun 9 2017

Labels: Merge-Request-60 OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 9 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e6a37793572fee88228e4f1789fbac058ecf1c6

commit 9e6a37793572fee88228e4f1789fbac058ecf1c6
Author: Henrik Grunell <grunell@chromium.org>
Date: Mon Jun 12 08:58:29 2017

Disabling logging of AEC metrics for AEC version 2 when AEC3 is active.

This CL ensures that the metrics for the WebRTC echo canceller version 2
are not logged when echo canceller version 3 is active

BUG= chromium:731283 , chromium:731633
TBR=peah@chromium.org

(cherry picked from commit eaeebae2cdd61180c7b3d82428620a9eb922b98d)

Review-Url: https://codereview.chromium.org/2926713006
Cr-Original-Commit-Position: refs/heads/master@{#478252}
Change-Id: Id5c16c80b192ddd3a983be32e2cf8b5512d80c5e
Reviewed-on: https://chromium-review.googlesource.com/530226
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#305}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/9e6a37793572fee88228e4f1789fbac058ecf1c6/content/renderer/media/media_stream_audio_processor.cc

Can this bug be closed?

Comment 6 by peah@google.com, Jul 6 2017

Status: Fixed (was: Assigned)
Labels: Test
What tests could have prevented this from happening?
Labels: -Test MissingTests
Ping

Comment 10 by peah@chromium.org, Sep 27 2017

That is a good question. I think the correct way to handle it would be for AEC2 to refuse reporting the metrics when it is not active.
That could then easily be tested for.

To test for metric values which are not updated could also be done, but I think it is the wrong approach. 
Labels: -MissingTests
I would encourage to do what you say in #10, then, but we won't nag about it anymore. Your call.

Sign in to add a comment