Fuchsia and //net conflict on ERR_ macros |
||||
Issue descriptionmagenta/errors.h defines macros like ERR_TIMED_OUT ERR_ACCESS_DENIED So does //net/base/net_errors.h. Want to change all of Fuchsia to be MX_ERR_ by any chance? :P
,
Jun 8 2017
MG-835 upstream. I guess we'll probably have to do the #undef dance and hope net doesn't actually need to check for TIMED_OUT from a syscall.
,
Jun 8 2017
Oops, crossed comments. Thanks swetland!
,
Jun 8 2017
,
Jun 13 2017
Looks like this happened upstream: https://fuchsia-review.googlesource.com/#/c/33721/ So we just need an SDK roll I guess?
,
Jun 13 2017
That CL adds the MX_ prefixes, but I don't think the conflicting ones are removed yet. We could probably get away with a few #undefs after that CL though (maybe that's what you meant...) I wanted to get a `cat` binary added too (all the newest fanciest tech!) https://fuchsia-review.googlesource.com/c/34189/ and then it'd be good to update to latest Fuchsia to get some of the fixes that have landed recently.
,
Jun 13 2017
Oh durr. kulakowski, can we add the old symbols behind some `#ifndef MX_OLD_MACRO_NAMES` thingy or similar?
,
Jun 13 2017
Yes, there's a #ifndef USE_MX_ERRORS already in there.
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecbdf4e071a703ba4250e3dafb7ed304e373aac1 commit ecbdf4e071a703ba4250e3dafb7ed304e373aac1 Author: Scott Graham <scottmg@chromium.org> Date: Thu Jun 15 20:56:30 2017 Update Fuchsia SDK to f79f55be4e69ebd90ea84f79d7322525853256c3 Two notable changes: - realpath() works. - ERR_TIMED_OUT, et al. are guarded and MX_ prefixed are available. Steps followed (mostly in Fuchsia tree): - check if fuchsia-dashboard.appspot.com looks green - sync - fbuild - fboot on Intel NUC - runtests on device and make sure everything passes - configure and build a release mode build with sdk config: $ ./packages/gn/gen.py -r --goma -m runtime $ ./packages/gn/build.py -r -j1000 - assemble sysroot and package tools into tgz $ ./scripts/makesdk.go . - compute sha1 $ sha1sum fuchsia-sdk.tgz f79f55be4e69ebd90ea84f79d7322525853256c3 - upload to gs bucket $ gsutil.py cp fuchsia-sdk.tgz gs://fuchsia-build/fuchsia/sdk/linux64/f79f55be4e69ebd90ea84f79d7322525853256c Then, on the chromium side, update DEPS to point at this sdk rev, build and confirm things are OK-ish, and make any changes required. Bug: 706592,707030, 731280 Change-Id: I05f1d6a30c03d58f515af313b54ffe2000a71c20 Reviewed-on: https://chromium-review.googlesource.com/537078 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#479822} [modify] https://crrev.com/ecbdf4e071a703ba4250e3dafb7ed304e373aac1/DEPS [modify] https://crrev.com/ecbdf4e071a703ba4250e3dafb7ed304e373aac1/build/fuchsia/test_runner.py
,
Jun 16 2017
The following revision refers to this bug: https://boringssl.googlesource.com/boringssl/+/72b36cfed8a63bf41439b0473f799e3a1ac9a961 commit 72b36cfed8a63bf41439b0473f799e3a1ac9a961 Author: Nico Weber <thakis@chromium.org> Date: Fri Jun 16 17:01:32 2017 fuchsia: Use new spelling of NO_ERROR. Bug: chromium:731280 Change-Id: I87161a3400ac5119401ec157df5843249971327a Reviewed-on: https://boringssl-review.googlesource.com/17246 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Aaron Green <aarongreen@google.com> Reviewed-by: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> [modify] https://crrev.com/72b36cfed8a63bf41439b0473f799e3a1ac9a961/crypto/rand_extra/fuchsia.c
,
Jun 16 2017
The following revision refers to this bug: https://boringssl.googlesource.com/boringssl/+/72b36cfed8a63bf41439b0473f799e3a1ac9a961 commit 72b36cfed8a63bf41439b0473f799e3a1ac9a961 Author: Nico Weber <thakis@chromium.org> Date: Fri Jun 16 17:01:32 2017 fuchsia: Use new spelling of NO_ERROR. Bug: chromium:731280 Change-Id: I87161a3400ac5119401ec157df5843249971327a Reviewed-on: https://boringssl-review.googlesource.com/17246 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Aaron Green <aarongreen@google.com> Reviewed-by: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> [modify] https://crrev.com/72b36cfed8a63bf41439b0473f799e3a1ac9a961/crypto/rand_extra/fuchsia.c
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a0405f8f3607547ae3872063a1c50b2c95989b7 commit 5a0405f8f3607547ae3872063a1c50b2c95989b7 Author: Nico Weber <thakis@chromium.org> Date: Fri Jun 16 17:24:48 2017 fuchsia: Use new, qualified error names, disable old names. BUG= 731280 R=scottmg@chromium.org Review-Url: https://codereview.chromium.org/2941283002 . Cr-Commit-Position: refs/heads/master@{#480089} [modify] https://crrev.com/5a0405f8f3607547ae3872063a1c50b2c95989b7/base/message_loop/message_pump_fuchsia.cc [modify] https://crrev.com/5a0405f8f3607547ae3872063a1c50b2c95989b7/base/process/kill_fuchsia.cc [modify] https://crrev.com/5a0405f8f3607547ae3872063a1c50b2c95989b7/base/process/launch_fuchsia.cc [modify] https://crrev.com/5a0405f8f3607547ae3872063a1c50b2c95989b7/base/process/process_fuchsia.cc [modify] https://crrev.com/5a0405f8f3607547ae3872063a1c50b2c95989b7/base/process/process_handle_fuchsia.cc [modify] https://crrev.com/5a0405f8f3607547ae3872063a1c50b2c95989b7/base/process/process_util_unittest.cc [modify] https://crrev.com/5a0405f8f3607547ae3872063a1c50b2c95989b7/base/rand_util_fuchsia.cc [modify] https://crrev.com/5a0405f8f3607547ae3872063a1c50b2c95989b7/build/config/fuchsia/BUILD.gn
,
Jun 16 2017
(Technically only fixed after the next boringssl, but that happens every week.) |
||||
►
Sign in to add a comment |
||||
Comment 1 by swetland@google.com
, Jun 8 2017