The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e9ff6090994e9e6b3e63e40436654eb4e968271

commit 5e9ff6090994e9e6b3e63e40436654eb4e968271
Author: lpy <lpy@chromium.org>
Date: Wed Jun 28 18:33:02 2017

[AudioStreamMonitor] Adds API to collect frame-level audibility.

This patch creates API to collect frame-level audibility in order to do
frame-level throttling and suspension, only sends audio changed state to
RenderFrameHost when we don't have power level monitoring or the audible state
of a stream changes, and defers to RenderFrameHost to send signals to
RenderProcessHost about audio stream added/removed.

BUG= 731270 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2948613002
Cr-Commit-Position: refs/heads/master@{#483075}

[modify] https://crrev.com/5e9ff6090994e9e6b3e63e40436654eb4e968271/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/5e9ff6090994e9e6b3e63e40436654eb4e968271/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/5e9ff6090994e9e6b3e63e40436654eb4e968271/content/browser/media/audio_stream_monitor.cc
[modify] https://crrev.com/5e9ff6090994e9e6b3e63e40436654eb4e968271/content/browser/media/audio_stream_monitor.h
[modify] https://crrev.com/5e9ff6090994e9e6b3e63e40436654eb4e968271/content/browser/media/audio_stream_monitor_unittest.cc

Hi,

I'm afraid the change in #1 has a massive impact on WebRTC functionality on my MacBook Air. The problem is still visible on ToT and I bisected between (yesterdays) ToT and lkgr to find this change.

I do the following:
- Start an appr.tc call between my MacBook Air and my workstation in one tab.
- Open YouTube in another tab (and let the first one keep running) on the MacBook.
- Mute the microphone in apprtc on my workstation.

At this point, the video feed from the MacBook (as shown on my workstation) stops updating and all the Chrome audio on the MacBook becomes terribly choppy. Looking at the logs, they're spewing out errors from different subsystems, like "UDP send of 1130 bytes failed with error 35", "AudioSyncReader::Read timed out, [...]" etc.

Sometimes I need to change back to apprtc and then back away from it for the problems to appear. They all disappear once I again focus the apprtc frame or unmute the mic on my workstation, but reappear once the mic is muted and apprtc is not the currently visible frame.

Would you like me to file this as a separate bug, or is it enough to track this here?

+cc grunell@ to be aware of audio issues on Mac

Please file a separate bug

Alright. New bug here: https://bugs.chromium.org/p/chromium/issues/detail?id=745537
I've put you down as owner for the time being, please reassign if that makes sense.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffd6e197407f715dc74f51ead5f2e079c39fb464

commit ffd6e197407f715dc74f51ead5f2e079c39fb464
Author: Peiyong Lin <lpy@chromium.org>
Date: Fri Aug 04 04:09:36 2017

[GRC] Add MetricsCollector.

This patch:
1. implements MetricsCollector to report background heuristics metrics;
2. adds UMA histogram to report audibility for background tabs;
3. creates empty ResourceCoordinatorInterface when service connection
is not available or resource coordinator service is not enabled.

BUG= 731270 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I53621e5a09a0c02e0526acfc405c751b62b4188d
Reviewed-on: https://chromium-review.googlesource.com/575512
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491936}
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.h
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer_unittest.cc
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.h
[add] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/metrics_collector.cc
[add] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/metrics_collector.h
[add] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[delete] https://crrev.com/f7a950420e3c1cae1c249430d6dccd55d5973cf6/services/resource_coordinator/coordination_unit/tab_metrics_collector.cc
[delete] https://crrev.com/f7a950420e3c1cae1c249430d6dccd55d5973cf6/services/resource_coordinator/coordination_unit/tab_metrics_collector.h
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/tab_signal_generator_impl.cc
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/tab_signal_generator_impl.h
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.cc
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.h
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/public/cpp/resource_coordinator_interface.h
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/public/interfaces/coordination_unit.mojom
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/services/resource_coordinator/resource_coordinator_service.cc
[modify] https://crrev.com/ffd6e197407f715dc74f51ead5f2e079c39fb464/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/348ee76b1e677c177a4f1552f48ca40ce72b7f2e

commit 348ee76b1e677c177a4f1552f48ca40ce72b7f2e
Author: Peiyong Lin <lpy@chromium.org>
Date: Wed Aug 09 03:42:58 2017

[GRC] Report first title updated UMA for background tabs.

This patch:
1. adds UMA histogram to report title updated for background
tabs;
2. minor clean up on resource_coordinator::mojom::Event and add
On*EventReceived to CoordinationUnitGraphObserver.

BUG= 731270 

Change-Id: I662c23405a1e731f8a7a99a5d2bc44c723fbd9fb
Reviewed-on: https://chromium-review.googlesource.com/585835
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492813}
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.h
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.cc
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.h
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/public/cpp/resource_coordinator_interface.h
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/public/interfaces/BUILD.gn
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/public/interfaces/coordination_unit.mojom
[delete] https://crrev.com/25dba32e4601e05935debb62fcd95e5123371a58/services/resource_coordinator/public/interfaces/events.mojom
[add] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/348ee76b1e677c177a4f1552f48ca40ce72b7f2e/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4

commit 9d35d8488f3d49d73d1bd38d5e496fbae6c403f4
Author: Peiyong Lin <lpy@chromium.org>
Date: Mon Aug 21 23:18:37 2017

[GRC] Report first alert fired UMA for background tabs.

This patch adds UMA histogram to report first alert fired happen for
background tabs, histogram records the time from when the tab becomes
background to when a JavaScript alert is fired.

Minor fix: Remove entry from web_contents_data_map_ when
WebContentsCoordinationUnit is destroyed.

BUG= 731270 ,  756004 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: If04a495aef60d7e300177271547a472792da5c3b
Reviewed-on: https://chromium-review.googlesource.com/614913
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496113}
[modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.h
[modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc
[modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.h
[modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9f6a13096222ba63845e5a25bd318e2c99268c6

commit e9f6a13096222ba63845e5a25bd318e2c99268c6
Author: Peiyong Lin <lpy@chromium.org>
Date: Tue Aug 22 06:13:27 2017

[TooManyTabs][GRC] Report first notification creation UMA for background tabs.

This patch plumbs the signal of notification creation event to GRC and
reports UMA for background tabs when a notification is created.

Minor: Add SendEvent method to BlinkResourceCoordinatorBase.

BUG= 731270 

Change-Id: Ic2ba9e570a2e82d0ea1aec7bf548acc08f3d4715
Reviewed-on: https://chromium-review.googlesource.com/611055
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496229}
[modify] https://crrev.com/e9f6a13096222ba63845e5a25bd318e2c99268c6/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/e9f6a13096222ba63845e5a25bd318e2c99268c6/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/e9f6a13096222ba63845e5a25bd318e2c99268c6/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/e9f6a13096222ba63845e5a25bd318e2c99268c6/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/e9f6a13096222ba63845e5a25bd318e2c99268c6/third_party/WebKit/Source/modules/notifications/BUILD.gn
[modify] https://crrev.com/e9f6a13096222ba63845e5a25bd318e2c99268c6/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/e9f6a13096222ba63845e5a25bd318e2c99268c6/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.cpp
[modify] https://crrev.com/e9f6a13096222ba63845e5a25bd318e2c99268c6/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.h
[modify] https://crrev.com/e9f6a13096222ba63845e5a25bd318e2c99268c6/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/401a6d4f4ea3aaeec8c5c5b6ea68cd597aae836a

commit 401a6d4f4ea3aaeec8c5c5b6ea68cd597aae836a
Author: Peiyong Lin <lpy@chromium.org>
Date: Tue Aug 22 20:29:52 2017

[GRC] Report first favicon updated UMA for background tabs.

This patch adds UMA histogram to report first favicon update happen for
background tabs, histogram records the time from when the tab becomes
background to when the favicon is updated; and also adds a timer to
delay sending favicon/title update signals to GRC for 5 minutes.

BUG= 731270 

Change-Id: I8c429bc18903fb509cba559d6adee19e73e889fd
Reviewed-on: https://chromium-review.googlesource.com/612499
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496425}
[modify] https://crrev.com/401a6d4f4ea3aaeec8c5c5b6ea68cd597aae836a/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/401a6d4f4ea3aaeec8c5c5b6ea68cd597aae836a/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/401a6d4f4ea3aaeec8c5c5b6ea68cd597aae836a/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/401a6d4f4ea3aaeec8c5c5b6ea68cd597aae836a/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/401a6d4f4ea3aaeec8c5c5b6ea68cd597aae836a/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/401a6d4f4ea3aaeec8c5c5b6ea68cd597aae836a/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/401a6d4f4ea3aaeec8c5c5b6ea68cd597aae836a/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/255eda8fe05c786f1c70adb8cc8be03c792374b8

commit 255eda8fe05c786f1c70adb8cc8be03c792374b8
Author: Peiyong Lin <lpy@chromium.org>
Date: Tue Aug 22 23:07:53 2017

[GRC] Add UKM report for background tabs audibility.

This patch adds UKM reports for background tabs audibility. Currently we
collect audible signal at frame-level, both main frame and child frames
are using the same source id to report UKM.

BUG= 731270 , 753486

Change-Id: I461ea2d8a6ef742fcb2850250ad68a5b71c89600
Reviewed-on: https://chromium-review.googlesource.com/604515
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496491}
[modify] https://crrev.com/255eda8fe05c786f1c70adb8cc8be03c792374b8/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/255eda8fe05c786f1c70adb8cc8be03c792374b8/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/255eda8fe05c786f1c70adb8cc8be03c792374b8/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e31b0b47faf7f774b7ad91d33b828218cc375c17

commit e31b0b47faf7f774b7ad91d33b828218cc375c17
Author: Peiyong Lin <lpy@chromium.org>
Date: Mon Aug 28 22:26:08 2017

[GRC] Add heuristics UKM and refactor MetricsCollector.

This patch:
1. adds heuristics UKM;
2. rafactors MetricsCollector to unify background tabs metrics report;
3. moved metrics report 5-minutes timeout logic to MetricsCollector;
4. adds more unit tests.

BUG= 731270 , 753486

Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
Reviewed-on: https://chromium-review.googlesource.com/627594
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497900}
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/BUILD.gn
[add] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/882c1f822459b38b69332ad5370b1eff6d7e482c

commit 882c1f822459b38b69332ad5370b1eff6d7e482c
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Aug 29 00:52:42 2017

Speculatively revert "[GRC] Add heuristics UKM and refactor MetricsCollector."

This reverts commit e31b0b47faf7f774b7ad91d33b828218cc375c17.

Reason for speculative revert:
Suspected for breaking tests in build:
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62729


Original change's description:
> [GRC] Add heuristics UKM and refactor MetricsCollector.
> 
> This patch:
> 1. adds heuristics UKM;
> 2. rafactors MetricsCollector to unify background tabs metrics report;
> 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> 4. adds more unit tests.
> 
> BUG= 731270 , 753486
> 
> Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> Reviewed-on: https://chromium-review.googlesource.com/627594
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497900}

TBR=dcheng@chromium.org,chrisha@chromium.org,holte@chromium.org,lpy@chromium.org

Change-Id: I40e09c00036adc133c5c4ab14e94aeea2bffe3e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  731270 , 753486, 759905
Reviewed-on: https://chromium-review.googlesource.com/639851
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497964}
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/BUILD.gn
[delete] https://crrev.com/dfb14c872c50f0a3728422c6243e560963aa0d06/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bc2eb1c983d21de6899c44a0382104ca83a5010

commit 6bc2eb1c983d21de6899c44a0382104ca83a5010
Author: Peiyong Lin <lpy@chromium.org>
Date: Wed Aug 30 08:27:25 2017

Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."

This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
Original change's description:

TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> [GRC] Add heuristics UKM and refactor MetricsCollector.
> 
> This patch:
> 1. adds heuristics UKM;
> 2. rafactors MetricsCollector to unify background tabs metrics report;
> 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> 4. adds more unit tests.
> 
> BUG= 731270 , 753486
> 
> Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> Reviewed-on: https://chromium-review.googlesource.com/627594
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497900}

Bug:  731270 , 753486
Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
Reviewed-on: https://chromium-review.googlesource.com/640010
Reviewed-by: lpy <lpy@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498395}
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/BUILD.gn
[add] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fceb00993ee141501b060988386e201207926fb

commit 8fceb00993ee141501b060988386e201207926fb
Author: Henrik Boström <hbos@chromium.org>
Date: Wed Aug 30 12:54:25 2017

Speculative revert, MetricsCollectorTest.FromBackgroundedToFirst* tests consistently fail on Win7 Tests (dbg)(1)

Revert "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector.""

This reverts commit 6bc2eb1c983d21de6899c44a0382104ca83a5010.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."
> 
> This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
> Original change's description:
> 
> TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> > [GRC] Add heuristics UKM and refactor MetricsCollector.
> > 
> > This patch:
> > 1. adds heuristics UKM;
> > 2. rafactors MetricsCollector to unify background tabs metrics report;
> > 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> > 4. adds more unit tests.
> > 
> > BUG= 731270 , 753486
> > 
> > Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> > Reviewed-on: https://chromium-review.googlesource.com/627594
> > Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Steven Holte <holte@chromium.org>
> > Commit-Queue: lpy <lpy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#497900}
> 
> Bug:  731270 , 753486
> Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
> Reviewed-on: https://chromium-review.googlesource.com/640010
> Reviewed-by: lpy <lpy@chromium.org>
> Commit-Queue: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498395}

TBR=dcheng@chromium.org,chrisha@chromium.org,holte@chromium.org,lpy@chromium.org

Change-Id: I33981ae07237f24005b2811fb5eca509e8068726
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  731270 , 753486
Reviewed-on: https://chromium-review.googlesource.com/643426
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498436}
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/BUILD.gn
[delete] https://crrev.com/19397b2658015dbe924370ae9fd999de615c268a/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f28e17610a74d58803586e7296b7bf5049619f87

commit f28e17610a74d58803586e7296b7bf5049619f87
Author: Peiyong Lin <lpy@chromium.org>
Date: Thu Aug 31 20:05:44 2017

Reland "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector.""

This is a reland of 6bc2eb1c983d21de6899c44a0382104ca83a5010
Original change's description:
> Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."
> 
> This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
> Original change's description:
> 
> TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> > [GRC] Add heuristics UKM and refactor MetricsCollector.
> > 
> > This patch:
> > 1. adds heuristics UKM;
> > 2. rafactors MetricsCollector to unify background tabs metrics report;
> > 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> > 4. adds more unit tests.
> > 
> > BUG= 731270 , 753486
> > 
> > Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> > Reviewed-on: https://chromium-review.googlesource.com/627594
> > Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Steven Holte <holte@chromium.org>
> > Commit-Queue: lpy <lpy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#497900}
> 
> Bug:  731270 , 753486
> Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
> Reviewed-on: https://chromium-review.googlesource.com/640010
> Reviewed-by: lpy <lpy@chromium.org>
> Commit-Queue: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498395}

TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org

Bug:  731270 , 753486
Change-Id: I65f2a5bc86e8ddd4af4b1739c306b6d1bc70b4b1
Reviewed-on: https://chromium-review.googlesource.com/643568
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498965}
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/BUILD.gn
[add] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb

commit 2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb
Author: Mike Wittman <wittman@chromium.org>
Date: Thu Aug 31 22:23:56 2017

Revert "Reland "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."""

This reverts commit f28e17610a74d58803586e7296b7bf5049619f87.

Reason for revert: still fails on Win7 Debug

[ RUN      ] MetricsCollectorTest.FromBackgroundedToFirstNonPersistentNotificationCreatedUMA5MinutesTimeout
../../services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc(33): error: Value of: metrics_collector_->ShouldReportMetrics( CoordinationUnitImpl::ToWebContentsCoordinationUnit(web_contents_cu))
  Actual: false
Expected: true
../../base/test/histogram_tester.cc(72): error:       Expected: count
      Which is: 1
To be equal to: 0
Histogram "TabManager.Heuristics.FromBackgroundedToFirstNonPersistentNotificationCreated" does not exist.
[  FAILED  ] MetricsCollectorTest.FromBackgroundedToFirstNonPersistentNotificationCreatedUMA5MinutesTimeout (2 ms)


Original change's description:
> Reland "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector.""
> 
> This is a reland of 6bc2eb1c983d21de6899c44a0382104ca83a5010
> Original change's description:
> > Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."
> > 
> > This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
> > Original change's description:
> > 
> > TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> > > [GRC] Add heuristics UKM and refactor MetricsCollector.
> > > 
> > > This patch:
> > > 1. adds heuristics UKM;
> > > 2. rafactors MetricsCollector to unify background tabs metrics report;
> > > 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> > > 4. adds more unit tests.
> > > 
> > > BUG= 731270 , 753486
> > > 
> > > Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> > > Reviewed-on: https://chromium-review.googlesource.com/627594
> > > Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > Reviewed-by: Steven Holte <holte@chromium.org>
> > > Commit-Queue: lpy <lpy@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#497900}
> > 
> > Bug:  731270 , 753486
> > Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
> > Reviewed-on: https://chromium-review.googlesource.com/640010
> > Reviewed-by: lpy <lpy@chromium.org>
> > Commit-Queue: lpy <lpy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#498395}
> 
> TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> 
> Bug:  731270 , 753486
> Change-Id: I65f2a5bc86e8ddd4af4b1739c306b6d1bc70b4b1
> Reviewed-on: https://chromium-review.googlesource.com/643568
> Commit-Queue: lpy <lpy@chromium.org>
> Reviewed-by: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498965}

TBR=dcheng@chromium.org,chrisha@chromium.org,holte@chromium.org,lpy@chromium.org

Change-Id: I2a125eef30d2186f3e3a962d053bfab8b0596569
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  731270 , 753486
Reviewed-on: https://chromium-review.googlesource.com/646532
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499045}
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/BUILD.gn
[delete] https://crrev.com/e974d892054aaf5ed122d37329c25aaa1010a96f/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85b2a0fca5a5721bd32d0dc71d703c9b700b6852

commit 85b2a0fca5a5721bd32d0dc71d703c9b700b6852
Author: Peiyong Lin <lpy@chromium.org>
Date: Fri Sep 01 07:29:11 2017

Reland: [GRC] Add heuristics UKM and refactor MetricsCollector.

This patch also disables MetricsCollectorTest on Windows because it
failed on Win 7 dbg.

This is a reland of f28e17610a74d58803586e7296b7bf5049619f87
Original change's description:
> Reland "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector.""
> 
> This is a reland of 6bc2eb1c983d21de6899c44a0382104ca83a5010
> Original change's description:
> > Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."
> > 
> > This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
> > Original change's description:
> > 
> > TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> > > [GRC] Add heuristics UKM and refactor MetricsCollector.
> > > 
> > > This patch:
> > > 1. adds heuristics UKM;
> > > 2. rafactors MetricsCollector to unify background tabs metrics report;
> > > 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> > > 4. adds more unit tests.
> > > 
> > > BUG= 731270 , 753486
> > > 
> > > Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> > > Reviewed-on: https://chromium-review.googlesource.com/627594
> > > Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > Reviewed-by: Steven Holte <holte@chromium.org>
> > > Commit-Queue: lpy <lpy@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#497900}
> > 
> > Bug:  731270 , 753486
> > Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
> > Reviewed-on: https://chromium-review.googlesource.com/640010
> > Reviewed-by: lpy <lpy@chromium.org>
> > Commit-Queue: lpy <lpy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#498395}
> 
> TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> 
> Bug:  731270 , 753486
> Change-Id: I65f2a5bc86e8ddd4af4b1739c306b6d1bc70b4b1
> Reviewed-on: https://chromium-review.googlesource.com/643568
> Commit-Queue: lpy <lpy@chromium.org>
> Reviewed-by: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498965}

TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org

Bug:  731270 , 753486
Change-Id: I10d8a16821848c8896e054dad0185b368905dc6e
Reviewed-on: https://chromium-review.googlesource.com/646533
Reviewed-by: lpy <lpy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499148}
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/BUILD.gn
[add] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/tools/metrics/ukm/ukm.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6998dc25a9a954c33acb6d405a348af129da24f7

commit 6998dc25a9a954c33acb6d405a348af129da24f7
Author: Peiyong Lin <lpy@chromium.org>
Date: Fri Sep 01 18:16:21 2017

Reland: [GRC] Add heuristics UKM and refactor MetricsCollector.

This patch also disables MetricsCollectorTest on Windows because it
failed on Win 7 dbg.

This is a reland of f28e17610a74d58803586e7296b7bf5049619f87
Original change's description:
> Reland "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector.""
> 
> This is a reland of 6bc2eb1c983d21de6899c44a0382104ca83a5010
> Original change's description:
> > Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."
> > 
> > This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
> > Original change's description:
> > 
> > TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> > > [GRC] Add heuristics UKM and refactor MetricsCollector.
> > > 
> > > This patch:
> > > 1. adds heuristics UKM;
> > > 2. rafactors MetricsCollector to unify background tabs metrics report;
> > > 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> > > 4. adds more unit tests.
> > > 
> > > BUG= 731270 , 753486
> > > 
> > > Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> > > Reviewed-on: https://chromium-review.googlesource.com/627594
> > > Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > Reviewed-by: Steven Holte <holte@chromium.org>
> > > Commit-Queue: lpy <lpy@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#497900}
> > 
> > Bug:  731270 , 753486
> > Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
> > Reviewed-on: https://chromium-review.googlesource.com/640010
> > Reviewed-by: lpy <lpy@chromium.org>
> > Commit-Queue: lpy <lpy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#498395}
> 
> TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> 
> Bug:  731270 , 753486
> Change-Id: I65f2a5bc86e8ddd4af4b1739c306b6d1bc70b4b1
> Reviewed-on: https://chromium-review.googlesource.com/643568
> Commit-Queue: lpy <lpy@chromium.org>
> Reviewed-by: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498965}

TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org

Bug:  731270 , 753486
Change-Id: I10d8a16821848c8896e054dad0185b368905dc6e
Reviewed-on: https://chromium-review.googlesource.com/646533
Reviewed-by: lpy <lpy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499148}(cherry picked from commit 85b2a0fca5a5721bd32d0dc71d703c9b700b6852)
Reviewed-on: https://chromium-review.googlesource.com/648186
Cr-Commit-Position: refs/branch-heads/3202@{#7}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/BUILD.gn
[add] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/tools/metrics/ukm/ukm.xml

I think we only have follow-up analysis to do, implementation was done.