New issue
Advanced search Search tips

Issue 731269 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

ExtensionApiTestWithManagementPolicy.InitiatorProtectedByPolicy flaky on win_chromium_rel_ng

Project Member Reported by ynovikov@chromium.org, Jun 8 2017

Issue description

Thanks, looking into it.
CL with fix pending code review.
https://codereview.chromium.org/2934583002/
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed5e8042ee77b69b64cab0b2c602878299341a22

commit ed5e8042ee77b69b64cab0b2c602878299341a22
Author: nrpeter <nrpeter@google.com>
Date: Mon Jun 12 17:40:38 2017

Reland: chrome.webRequest support for ExtensionSettings

Origional CL (2495353003) was rolled back by sheriff due to flaky test.
This initial patchet is a direct patch of 2495353003. Second patchset contains the fix.

chrome.webRequest support for ExtensionSettings
-If URL or Origin matches an ExtensionSettings protected host, the event will not be dispatched to that extension / app.

BUG= 731269 

patch from issue 2495353003 at patchset 400001 (http://crrev.com/2495353003#ps400001)

Review-Url: https://codereview.chromium.org/2934583002
Cr-Commit-Position: refs/heads/master@{#478669}

[modify] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
[modify] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/chrome/browser/extensions/extension_with_management_policy_apitest.cc
[modify] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/chrome/browser/extensions/extension_with_management_policy_apitest.h
[add] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/chrome/test/data/extensions/api_test/webrequest/policy_blocked/background.js
[add] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/chrome/test/data/extensions/api_test/webrequest/policy_blocked/manifest.json
[add] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/chrome/test/data/extensions/api_test/webrequest/policy_blocked/ref_remote_js.html
[add] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/chrome/test/data/extensions/api_test/webrequest/policy_blocked/ref_remote_js.js
[modify] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/extensions/browser/api/declarative_webrequest/webrequest_action.cc
[modify] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/extensions/browser/api/web_request/web_request_permissions.cc
[modify] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/extensions/browser/api/web_request/web_request_permissions.h
[modify] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/extensions/common/permissions/permissions_data.cc
[modify] https://crrev.com/ed5e8042ee77b69b64cab0b2c602878299341a22/extensions/common/permissions/permissions_data.h

Status: Fixed (was: Assigned)

Sign in to add a comment