Tab manager should fast kill tabs whenever possible |
||||
Issue descriptionToday, when tab manager gets a critical memory pressure signal, we still shut down the tab gracefully. This is bad for the user: it is important to respond to critical pressure signals rapidly, so the OS doesn't have to go killing processes itself. Doing a graceful shutdown of a tab involves running potentially large amounts of JS, which may in turn allocate memory, or trigger page faults to bring in the page's memory that would have otherwise been swapped out to save memory. Combined, this behavior ends up making a critical-memory situation worse, not better. Expected behavior: chrome responds as rapidly as possible to critical memory pressures situations.
,
Jun 8 2017
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c0ec6e12db2504a1b090b9910041b1a0aa46c6e commit 2c0ec6e12db2504a1b090b9910041b1a0aa46c6e Author: Oystein Eftevaag <oysteine@chromium.org> Date: Fri Jun 09 03:55:58 2017 Tab discarding: Attempt fast shutdown of render process BUG= 731240 R=chrisha@chromium.org Change-Id: I2e6e8ed5cfcc0e415d633283c80869c261132d5d Reviewed-on: https://chromium-review.googlesource.com/528474 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Oystein Eftevaag <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#478194} [modify] https://crrev.com/2c0ec6e12db2504a1b090b9910041b1a0aa46c6e/chrome/browser/resource_coordinator/tab_manager.cc [modify] https://crrev.com/2c0ec6e12db2504a1b090b9910041b1a0aa46c6e/chrome/browser/resource_coordinator/tab_manager.h [modify] https://crrev.com/2c0ec6e12db2504a1b090b9910041b1a0aa46c6e/chrome/browser/resource_coordinator/tab_manager_browsertest.cc [modify] https://crrev.com/2c0ec6e12db2504a1b090b9910041b1a0aa46c6e/tools/metrics/histograms/enums.xml [modify] https://crrev.com/2c0ec6e12db2504a1b090b9910041b1a0aa46c6e/tools/metrics/histograms/histograms.xml
,
Jun 13 2017
,
Jul 17 2017
,
Jul 31 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nduca@chromium.org
, Jun 8 2017