Agree with you on SetCookieWithCreationTime, but I think the other has some consumers in production code (Though they could still be switched to another API, presumably)?

https://cs.chromium.org/chromium/src/android_webview/browser/cookie_manager.cc?type=cs&q=GetCookiesWithOptions&l=419
https://cs.chromium.org/chromium/src/content/browser/media/android/media_resource_getter_impl.cc?type=cs&q=GetCookiesWithOptions&l=261

Quite right, missed those.  Joys of codesearch/fat-fingering grep.  This bug should be considered to be about SetCookieWithCreationTime only, which is less interesting.

Doing this as a learning exercise. Actually mostly done, I think.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a61ed028d0c21ae0344080785a05100f3d63413d

commit a61ed028d0c21ae0344080785a05100f3d63413d
Author: Maks Orlovich <morlovich@chromium.org>
Date: Thu Mar 01 18:24:24 2018

CookieMonster: remove testonly SetCookieWithCreationTimeForTesting

... since it's easy for test fixture to provide based on public API.
This reduced SetCookieWithCreationTimeAndOptions down to a single caller,
so fold it in and simplify it a little bit.

Bug:  731236 
Change-Id: Ib5acd742ddb6aea7d26dff4952f800826bf5f1e2
Reviewed-on: https://chromium-review.googlesource.com/940142
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540218}
[modify] https://crrev.com/a61ed028d0c21ae0344080785a05100f3d63413d/net/cookies/cookie_monster.cc
[modify] https://crrev.com/a61ed028d0c21ae0344080785a05100f3d63413d/net/cookies/cookie_monster.h
[modify] https://crrev.com/a61ed028d0c21ae0344080785a05100f3d63413d/net/cookies/cookie_monster_unittest.cc

(pwnall@ actually got rid of GetCookiesWithOptionsAsync, too, which was a considerably more complex change than the above)