New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731222 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cellular updates: Update icon is not removed from system status tray after user confirms download

Project Member Reported by sdantul...@chromium.org, Jun 8 2017

Issue description

Google Chrome	60.0.3112.20 (Official Build) dev (64-bit)
Revision	0
Platform	9592.10.0 (Official Build) dev-channel samus

What steps will reproduce the problem?
1. Chromebook on cellular network
2. See update icon in system tray
3. Click on 'Click to view update details'
4. Click 'Continue' on confirmation dialog
5. Updates start downloading

What is the expected result?
Remove update icon from system status tray

What happens instead?
Update icon is still present in system tray.
 
Cc: steve...@chromium.org
Owner: weidongg@chromium.org
Status: Assigned (was: Untriaged)
Let me confirm with the PM about the right behavior here. I am not sure whether we should show the icon until after update completed and system reboots.
Cc: hannia@chromium.org
I just confirmed with hannia@. This is intended behavior.
Why do we want a different behaviour than regular update?
By regular update, do you mean that the update should be downloaded without any dialog in the middle?
The user should be notified of the update size before he make decision whether to proceed to downloading, as size matters in metered connections.
Once the user clicks "Continue" in the confirmation dialog, we should remove the update icon from the system menu until the user needs to restart.

If there are any issues during the download (error downloading, user restarts, etc), we should retry since the user has given us permission to use the cellular data.
Re #6, Ok, I see. That makes sense. I will upload a CL to fix this.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98258cced1d9ed158af9e98706225119b6765e2d

commit 98258cced1d9ed158af9e98706225119b6765e2d
Author: weidongg <weidongg@chromium.org>
Date: Tue Jun 13 22:35:49 2017

Remove update icon after user confirms download

This CL removes update icon from system tray along with the
corresponding row in details view after user confirms download of the
update over cellular connections.

BUG= 731222 

Review-Url: https://codereview.chromium.org/2933923002
Cr-Commit-Position: refs/heads/master@{#479181}

[modify] https://crrev.com/98258cced1d9ed158af9e98706225119b6765e2d/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/98258cced1d9ed158af9e98706225119b6765e2d/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/98258cced1d9ed158af9e98706225119b6765e2d/ash/system/update/tray_update.cc
[modify] https://crrev.com/98258cced1d9ed158af9e98706225119b6765e2d/ash/system/update/tray_update.h
[add] https://crrev.com/98258cced1d9ed158af9e98706225119b6765e2d/ash/system/update/update_observer.h
[modify] https://crrev.com/98258cced1d9ed158af9e98706225119b6765e2d/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/98258cced1d9ed158af9e98706225119b6765e2d/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/98258cced1d9ed158af9e98706225119b6765e2d/chromeos/dbus/update_engine_client.cc
[modify] https://crrev.com/98258cced1d9ed158af9e98706225119b6765e2d/chromeos/dbus/update_engine_client.h

Labels: Merge-Request-60
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 14 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Status: Fixed (was: Assigned)
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 23 2017

Cc: josa...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-60
Status: Verified (was: Fixed)
Verified on M64 build during cellular AU from 10104.0.0 to 10106.0.0

Sign in to add a comment