New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731202 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 753640
issue 787206

Blocking:
issue 717808
issue 794313



Sign in to add a comment

Clean up latency info

Project Member Reported by tdres...@chromium.org, Jun 8 2017

Issue description

See doc for plan here:
https://docs.google.com/document/d/10Ytvqz3CSKzE7ENdHaBv_zPvNuX7spPTuCQ-aDSqirE/edit#heading=h.x84l7x119ihf

We'd like to get LatencyInfo into a more rational state.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a

commit 7a5ff008cb7963c34c5207fa60145a1d7d9ea99a
Author: tdresser <tdresser@chromium.org>
Date: Tue Jun 27 19:56:45 2017

LatencyInfo trace_id_ no longer dependent on sequence_number.

trace_id_ is the primary consumer of sequence_numbers
in LatencyInfo.

In order to get rid of sequence_number, first remove the
dependency between trace_id_ and sequence_number.

This is a precursor to
https://codereview.chromium.org/2914023002.

BUG=731202
TEST=RenderWidgetHostLatencyTrackerTest, latency_unittests
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2953073002
Cr-Commit-Position: refs/heads/master@{#482718}

[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/cc/trees/latency_info_swap_promise_monitor.cc
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/content/common/input/input_param_traits_unittest.cc
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/ui/latency/ipc/latency_info_param_traits.cc
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/ui/latency/ipc/latency_info_param_traits_unittest.cc
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/ui/latency/latency_info.cc
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/ui/latency/latency_info.h
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/ui/latency/latency_info_unittest.cc
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/ui/latency/mojo/latency_info.mojom
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/ui/latency/mojo/latency_info_struct_traits.cc
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/ui/latency/mojo/latency_info_struct_traits.h
[modify] https://crrev.com/7a5ff008cb7963c34c5207fa60145a1d7d9ea99a/ui/latency/mojo/struct_traits_unittest.cc

Comment 2 by kbr@chromium.org, Jul 7 2017

Cc: kbr@chromium.org jbau...@chromium.org
Cc: tdres...@chromium.org kenrb@chromium.org vmi...@chromium.org briander...@chromium.org
 Issue 753773  has been merged into this issue.
Blocking: 717808

Comment 5 by kbr@chromium.org, Sep 15 2017

Blockedon: 753640
Cc: sadrul@chromium.org
Owner: nzolghadr@chromium.org
Blockedon: 787206
Blocking: 794313
[Bug triage: no update in the last 100 days] 
Any update on this? 
Ping again. Any update?
Owner: sadrul@chromium.org
I did a bunch of stuff back then on this but I believe Sadrul is driving this now.
Sadrul, are you working on this? If not then we can change it to available.
Components: -Speed>Metrics Internals>GPU>Metrics

Sign in to add a comment