New issue
Advanced search Search tips

Issue 731192 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Jun 2017
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router] Do current-time increments in the dialog WebUI

Project Member Reported by taku...@chromium.org, Jun 8 2017 
In the new WebUI route controller (crbug/684642), while the media is playing we require the MediaRouteProviders in the component extension to be responsible for incrementing the current time every second. This requires the extension to stay awake.

To make the WebUI increment the time on its own, we need to let the WebUI know when the media is buffering. To do that, we can replace the is_paused attribute of mojom::MediaStatus with an enum with the values PLAYING, PAUSED, and BUFFERING.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/572110ec256c5a328a0cc6f17a893c27418410fb

commit 572110ec256c5a328a0cc6f17a893c27418410fb
Author: takumif <takumif@chromium.org>
Date: Wed Jun 21 21:49:56 2017

[Media Router] Increment the media's current_time in the WebUI route controller

This CL replaces the is_paused attribute of the MediaRoute object with play_state
enum, and makes the WebUI route controller increment the current time of
the media every second if the enum value is PLAYING (not PAUSED/BUFFERING).

This is the second of the three (extension-side, browser-side, extension-side)
patches to allow the WebUI route controller to increment the current time (shown
on the seek bar) on its own while the media is playing:

1. Add play_state attribute to the extension side (cl/159493444)
2. Make the browser side use only play_state, and increment time on its own
(this patch)
3. Remove is_paused attribute and time-incrementing-logic from the extension
side

This CL must land after the CL #1 above.

BUG= 731192 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2932933002
Cr-Commit-Position: refs/heads/master@{#481318}

[modify] https://crrev.com/572110ec256c5a328a0cc6f17a893c27418410fb/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
[modify] https://crrev.com/572110ec256c5a328a0cc6f17a893c27418410fb/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/572110ec256c5a328a0cc6f17a893c27418410fb/chrome/browser/resources/media_router/media_router_data.js
[modify] https://crrev.com/572110ec256c5a328a0cc6f17a893c27418410fb/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/572110ec256c5a328a0cc6f17a893c27418410fb/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/572110ec256c5a328a0cc6f17a893c27418410fb/chrome/common/media_router/media_status.cc
[modify] https://crrev.com/572110ec256c5a328a0cc6f17a893c27418410fb/chrome/common/media_router/media_status.h
[modify] https://crrev.com/572110ec256c5a328a0cc6f17a893c27418410fb/chrome/common/media_router/mojo/media_status.mojom
[modify] https://crrev.com/572110ec256c5a328a0cc6f17a893c27418410fb/chrome/common/media_router/mojo/media_status_struct_traits.cc
[modify] https://crrev.com/572110ec256c5a328a0cc6f17a893c27418410fb/chrome/common/media_router/mojo/media_status_struct_traits.h
[modify] https://crrev.com/572110ec256c5a328a0cc6f17a893c27418410fb/chrome/test/data/webui/media_router/route_controls_tests.js

Comment 2 by taku...@chromium.org, Jun 26 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment