New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731189 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[cast_channel] clean up cast_channel namespace usage in cast_channel_api.cc

Project Member Reported by zhaobin@chromium.org, Jun 8 2017

Issue description

To resolve code review comments in :
https://codereview.chromium.org/2913033003/diff/100001/extensions/browser/api/cast_channel/cast_channel_api.h#newcode41

After moving cast channel related files to //components, we have three separate "cast_channel" namespaces (::cast_channel,
extensions::cast_channel, extensions::api::cast_channel). Removing some of them if they're no longer needed, renaming some to better
match content, etc...
 

Comment 1 by sko...@chromium.org, Jun 12 2017

Labels: Hotlist-Fixit-PE2017
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7a0f8f0e12886381fd35db180fee05dcbf12d98

commit e7a0f8f0e12886381fd35db180fee05dcbf12d98
Author: Bin Zhao <zhaobin@chromium.org>
Date: Tue Jul 18 20:18:45 2017

[cast_channel] clean up cast_channel namespace

- All classes under extensions/browser/api/cast_channel/ use namespace extensions
- Auto generated code (cast_channel.h) from cast_channel.idl uses namespace extensions::api

Bug:  731189 
Change-Id: I8b658f909296ecab8dd9c99e3845adf1ff1389d8
Reviewed-on: https://chromium-review.googlesource.com/574968
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487581}
[modify] https://crrev.com/e7a0f8f0e12886381fd35db180fee05dcbf12d98/extensions/browser/api/cast_channel/cast_channel_api.cc
[modify] https://crrev.com/e7a0f8f0e12886381fd35db180fee05dcbf12d98/extensions/browser/api/cast_channel/cast_channel_api_unittest.cc
[modify] https://crrev.com/e7a0f8f0e12886381fd35db180fee05dcbf12d98/extensions/browser/api/cast_channel/cast_channel_enum_util.cc
[modify] https://crrev.com/e7a0f8f0e12886381fd35db180fee05dcbf12d98/extensions/browser/api/cast_channel/cast_channel_enum_util.h
[modify] https://crrev.com/e7a0f8f0e12886381fd35db180fee05dcbf12d98/extensions/browser/api/cast_channel/cast_channel_enum_util_unittest.cc
[modify] https://crrev.com/e7a0f8f0e12886381fd35db180fee05dcbf12d98/extensions/browser/api/cast_channel/cast_message_util.cc
[modify] https://crrev.com/e7a0f8f0e12886381fd35db180fee05dcbf12d98/extensions/browser/api/cast_channel/cast_message_util.h

Status: Fixed (was: Started)

Sign in to add a comment