Crash on wrapping search on a pdf |
|||||
Issue descriptionChrome Version: Built from master at 0ed1d7f2ebb841f99aa71bb052e1619f9ec6a318 What steps will reproduce the problem? (1) Open a PDF file (2) Ctrl+F to find a string present in the file (3) Continue search until it wraps to the beginning What is the expected result? Wraps to the beginning. What happens instead? Crash. Please use labels and text to provide additional information. [1:1:0608/122452.973556:FATAL:out_of_process_instance.cc(1154)] Check failed: current_find_index >= 0 (-1 vs. 0) #0 0x7fb128486b0b base::debug::StackTrace::StackTrace() #1 0x7fb12848580c base::debug::StackTrace::StackTrace() #2 0x7fb1284f93a3 logging::LogMessage::~LogMessage() #3 0x56066e91ae41 chrome_pdf::OutOfProcessInstance::NotifySelectedFindResultChanged() #4 0x56066e8ee0b3 chrome_pdf::PDFiumEngine::SelectFindResult() #5 0x56066e9185f4 chrome_pdf::OutOfProcessInstance::SelectFindResult() https://paste.googleplex.com/4911084699910144 Does not happen on google-chrome-unstable.
,
Jun 9 2017
This looks to have been introduced in http://crrev.com/2836973002 (and was later refactored a little). In particular, this line: https://cs.chromium.org/chromium/src/pdf/pdfium/pdfium_engine.cc?rcl=d626453911a21cc606c9e6688da109291aecf25f&l=2209
,
Jun 20 2017
,
Aug 30 2017
https://codereview.chromium.org/2836973002 makes this change intentionally. It seems we should just remove the DCHECK, as -1 is now a valid value to receive in SelectFindResult.
,
Aug 30 2017
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/408a4393b14d18a971df45141e75dcd537942463 commit 408a4393b14d18a971df45141e75dcd537942463 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Thu Aug 31 14:40:33 2017 Change DCHECK in pdfium_engine.cc for new find protocol. Bug: chromium:731188 Change-Id: Icf12b7907bad0897f1a385539f102e601bfcf030 Reviewed-on: https://chromium-review.googlesource.com/644354 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Paul Meyer <paulmeyer@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#498861} [modify] https://crrev.com/408a4393b14d18a971df45141e75dcd537942463/pdf/out_of_process_instance.cc
,
Aug 31 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thestig@chromium.org
, Jun 8 2017