New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731186 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Add documentation for the different builds of Chrome for Android

Project Member Reported by nyquist@chromium.org, Jun 8 2017

Issue description

There are 3 main public APK targets for Chrome: chrome_public_apk, chrome_modern_public_apk and monochrome_public_apk.

The differences between these should be highlighted in the public documentation.

# Chrome
  - Used for devices running API level [16,20].
  - Min SDK version = 16.
# Chrome Modern
  - Used for devices running API level [21,23].
  - Min SDK version = 21.
  - The APK has the big .so file uncompressed.
  - This means the APK is bigger, but the on-disk size for the end user is smaller, since there is no reason to extract the .so file, it is just read directly from the right spot in the APK file.
  - For a full download from the Play Store, it is virtually always compressed in transit with content-encoding: gzip or similar which provides about the same compression as compressing the .so in the APK anyway, since it is still deflate under the hood. So: Full download should be more or less the same bytes on the network.
  - For delta downloads, the uncompressed version is generally smaller, since delta for uncompressed .so files are typically better.
# Monochrome
  - Used for devices running API level [24,).
  - Min SDK version = 24.
  - Contains both WebView and Chrome within the same APK.
 
Curious where you think a good place to document this would be.

//chrome/android/README.md?

comments beside each android_apk() target?

//docs/android_build_instructions.md?

I'm not sure myself :/
Yeah, not sure either.

It feels a little bit weird putting it all in the android_apk targets, and it will become hard to link to if you want to help someone out. Also, the min_sdk_version is typically "right there".

So maybe until we have more reasons to create //chrome/android/README.md, maybe just put it in //docs/android_build_instructions.md? At least that feels like a very natural place.

I would probably keep the string 'chrome_public_apk' around for all the other commands listed there though, just so we don't confuse people. Just add a new paragraph about the choices I think.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/052376a54fcd5df3f2d781c5b95e51e026a98fca

commit 052376a54fcd5df3f2d781c5b95e51e026a98fca
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Sep 26 01:54:11 2017

Android: Rename chrome->libchrome and document various apk targets

The rename will help to call out that multiple build targets exist on
Android.

Bug:  731186 
Change-Id: I1dbe2ffe932b25ab8739f53c2cd05c2ee3d8b2b6
Reviewed-on: https://chromium-review.googlesource.com/682770
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504257}
[modify] https://crrev.com/052376a54fcd5df3f2d781c5b95e51e026a98fca/chrome/android/BUILD.gn
[modify] https://crrev.com/052376a54fcd5df3f2d781c5b95e51e026a98fca/docs/android_build_instructions.md

Owner: agrieve@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/05d4e8dba5e39c9a6530fb3e92b93b5954384b8c

commit 05d4e8dba5e39c9a6530fb3e92b93b5954384b8c
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Sep 26 17:28:18 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3f445df632781fed7053789796e9dee14a4cc3c

commit e3f445df632781fed7053789796e9dee14a4cc3c
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Sep 26 18:43:22 2017

Remove //chrome/android:chrome alias

Downstream rename is now complete.

Bug:  731186 
Change-Id: I78be4e134d0a4ea0cf98c714f92d4835902de5e9
Reviewed-on: https://chromium-review.googlesource.com/684956
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504437}
[modify] https://crrev.com/e3f445df632781fed7053789796e9dee14a4cc3c/chrome/android/BUILD.gn

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0a4c69633cbc88b9954ce9520c3dc5a9ec0a78c

commit a0a4c69633cbc88b9954ce9520c3dc5a9ec0a78c
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Sep 26 19:01:49 2017

Revert "Remove //chrome/android:chrome alias"

This reverts commit e3f445df632781fed7053789796e9dee14a4cc3c.

Reason for revert: 
Broke compile: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20KitKat%20Builder/builds/3365

Original change's description:
> Remove //chrome/android:chrome alias
> 
> Downstream rename is now complete.
> 
> Bug:  731186 
> Change-Id: I78be4e134d0a4ea0cf98c714f92d4835902de5e9
> Reviewed-on: https://chromium-review.googlesource.com/684956
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504437}

TBR=nyquist@chromium.org,agrieve@chromium.org

Change-Id: I65a66e72aabc72986c8e9aacef485807cab98c3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  731186 
Reviewed-on: https://chromium-review.googlesource.com/685635
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504444}
[modify] https://crrev.com/a0a4c69633cbc88b9954ce9520c3dc5a9ec0a78c/chrome/android/BUILD.gn

Cc: nyquist@chromium.org
Status: Started (was: Fixed)
Should we close this once the fix sticks?
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5362d2a9854efea8a6902fe63426e641014b9e8

commit c5362d2a9854efea8a6902fe63426e641014b9e8
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Sep 26 21:37:01 2017

Reland "Remove //chrome/android:chrome alias"

This is a reland of e3f445df632781fed7053789796e9dee14a4cc3c
Original change's description:
> Remove //chrome/android:chrome alias
> 
> Downstream rename is now complete.
> 
> Bug:  731186 
> Change-Id: I78be4e134d0a4ea0cf98c714f92d4835902de5e9
> Reviewed-on: https://chromium-review.googlesource.com/684956
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504437}

Bug:  731186 
Change-Id: I82816beec565bcd3a86c849a7e79caf006dde851
Reviewed-on: https://chromium-review.googlesource.com/685399
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504490}
[modify] https://crrev.com/c5362d2a9854efea8a6902fe63426e641014b9e8/chrome/BUILD.gn
[modify] https://crrev.com/c5362d2a9854efea8a6902fe63426e641014b9e8/chrome/android/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment