Issue 731185 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	chanli@chromium.org
Closed:	Jun 2017
Cc:	█ robert...@chromium.org wylieb@chromium.org lijeffrey@chromium.org chanli@chromium.org liaoyuke@chromium.org st...@chromium.org
Components:	Tools>Test>FindIt
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
effort-small

Use a hidden HTML form instead of composing url by javascript

Project Member Reported by st...@chromium.org, Jun 8 2017

Issue description

Similar to the other bug 731184, we should fix https://cs.chromium.org/chromium/infra/appengine/findit/templates/list_analyses.html?q=CreateUrl

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/292bb414ed2a4c6cde811dd8208113032b0a587c

commit 292bb414ed2a4c6cde811dd8208113032b0a587c
Author: Chan <chanli@chromium.org>
Date: Fri Jun 09 23:34:16 2017

[Findit] Use a hidden HTML form instead of composing url by javascript

Bug:731185
Change-Id: I83ff4991c707c5d98e16995b6c9689e8f78ed148
Reviewed-on: https://chromium-review.googlesource.com/528428
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/292bb414ed2a4c6cde811dd8208113032b0a587c/appengine/findit/templates/list_analyses.html
[modify] https://crrev.com/292bb414ed2a4c6cde811dd8208113032b0a587c/appengine/findit/handlers/test/list_analyses_test.py
[modify] https://crrev.com/292bb414ed2a4c6cde811dd8208113032b0a587c/appengine/findit/handlers/list_analyses.py

Comment 2 by chanli@chromium.org, Jun 9 2017

Status: Fixed (was: Assigned)

►

Issue 731185 link

Issue metadata

Use a hidden HTML form instead of composing url by javascript

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 9 2017

Comment 1 Deleted

Comment 2 by chanli@chromium.org, Jun 9 2017

Comment 2 Deleted

Sign in to add a comment