New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731184 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Use HTML form or in-placed link instead of composing url in javascript

Project Member Reported by st...@chromium.org, Jun 8 2017

Issue description

We should fix below pages:
https://cs.chromium.org/chromium/infra/appengine/findit/templates/flake/dashboard.html?q=createUrl
https://cs.chromium.org/chromium/infra/appengine/findit/templates/auto_revert_metrics.html?q=createUrl
https://cs.chromium.org/chromium/infra/appengine/findit/templates/check_reverted_cls.html?q=createUrl
https://cs.chromium.org/chromium/infra/appengine/findit/templates/pipeline_errors_dashboard.html?q=createUrl
https://cs.chromium.org/chromium/infra/appengine/findit/templates/try_job_dashboard.html?q=createUrl


After fixing, it should look like:
HTML form -- https://cs.chromium.org/chromium/infra/appengine/findit/templates/flake/result.html?q="Rerun Analysis"
In-placed link -- https://cs.chromium.org/chromium/infra/appengine/findit/templates/config.html?q=Previous

If needed, javascript could be used to update the values of some parameter at runtime.
(If the http request has to be async without page reload like giving feedback on analysis result, we could go with javascript for that purpose. But if the http request is to reload/refresh/replace the current page, an HTML form or a link is usually a better option. We also need to use POST and GET accordingly.)
 

Sign in to add a comment