New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731173 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

fixing resizing on orientation changes

Project Member Reported by danielpark@chromium.org, Jun 8 2017

Issue description

Change resizing logic to use minimum padding on each side instead of a max proportion for the width. if 75% of the screen isn't large enough for the menu (i.e. on small screens), then use minimum padding method.
 
Labels: -Pri-3 OS-Linux Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c76fe2d15d81e2e125ad5efc57a70ab143870a6e

commit c76fe2d15d81e2e125ad5efc57a70ab143870a6e
Author: danielpark <danielpark@chromium.org>
Date: Wed Jul 05 22:18:04 2017

Adding smarter resizing logic for the context menu on orientation changes

* Renamed CONTEXT_MENU_MIN_PADDING_PX to mContextMenuMinimumPaddingPx

* Grouped context_menu_min_vertical_padding and context_menu_min_side_padding into
context_menu_min_padding.

* Added more comments in TabularContextMenuViewPager#onMeasure

* Made padding into a global variable called CONTEXT_MENU_MIN_PADDING_PX.

* Renamed context_menu_height_padding to context_menu_min_vertical_padding with half
the value, but multiplied all usages by 2 so the total values are the same.

* Added context_menu_min_side_padding.

* Rewrote sizing logic so width is the minimum of 500 dp or total width - 2 * side_padding

* Added a max height to context menu row

* Added a max height to the context menu so it no longer leaks over the edge.

* The list view now scrolls when the context menu reaches max height.

Previous issue link: https://codereview.chromium.org/2956943002/
I had to recreate it after fixing the owner issue.

BUG= 731173 

Review-Url: https://codereview.chromium.org/2959853002
Cr-Commit-Position: refs/heads/master@{#484364}

[modify] https://crrev.com/c76fe2d15d81e2e125ad5efc57a70ab143870a6e/chrome/android/java/res/layout/tabular_context_menu_page.xml
[modify] https://crrev.com/c76fe2d15d81e2e125ad5efc57a70ab143870a6e/chrome/android/java/res/layout/tabular_context_menu_row.xml
[modify] https://crrev.com/c76fe2d15d81e2e125ad5efc57a70ab143870a6e/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/c76fe2d15d81e2e125ad5efc57a70ab143870a6e/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java

Status: Fixed (was: Untriaged)

Sign in to add a comment