New issue
Advanced search Search tips

Issue 731166 link

Starred by 0 users
Status: Fixed
Owner:
guidou@chromium.org
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

content::DiscreteSet: rename or move to namespace

Project Member Reported by guidou@chromium.org, Jun 8 2017 
The name is too generic for this class, which is very specific to constraints processing. It should be either renamed or moved to a namespace to avoid future clashes with an actual generic class with that name.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4aad93e53565aea365aae22b7abf971f39d111f

commit a4aad93e53565aea365aae22b7abf971f39d111f
Author: Guido Urdaneta <guidou@chromium.org>
Date: Thu Jun 21 23:03:07 2018

Use namespace for MediaStream constraint utility set types

These utility sets are very specific to constraints processing, but they
have generic-looking names such as DiscreteSet and NumericRangeSet,
which might cause issues if actually generic sets with those names want
to be added elsewhere.

Bug:  731166 
Change-Id: I5a5fcec7d1a83417b007621b496b22acba509352
Reviewed-on: https://chromium-review.googlesource.com/1101201
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569409}
[modify] https://crrev.com/a4aad93e53565aea365aae22b7abf971f39d111f/content/renderer/media/stream/media_stream_constraints_util.cc
[modify] https://crrev.com/a4aad93e53565aea365aae22b7abf971f39d111f/content/renderer/media/stream/media_stream_constraints_util.h
[modify] https://crrev.com/a4aad93e53565aea365aae22b7abf971f39d111f/content/renderer/media/stream/media_stream_constraints_util_audio.cc
[modify] https://crrev.com/a4aad93e53565aea365aae22b7abf971f39d111f/content/renderer/media/stream/media_stream_constraints_util_sets.cc
[modify] https://crrev.com/a4aad93e53565aea365aae22b7abf971f39d111f/content/renderer/media/stream/media_stream_constraints_util_sets.h
[modify] https://crrev.com/a4aad93e53565aea365aae22b7abf971f39d111f/content/renderer/media/stream/media_stream_constraints_util_sets_unittest.cc
[modify] https://crrev.com/a4aad93e53565aea365aae22b7abf971f39d111f/content/renderer/media/stream/media_stream_constraints_util_unittest.cc
[modify] https://crrev.com/a4aad93e53565aea365aae22b7abf971f39d111f/content/renderer/media/stream/media_stream_constraints_util_video_content.cc
[modify] https://crrev.com/a4aad93e53565aea365aae22b7abf971f39d111f/content/renderer/media/stream/media_stream_constraints_util_video_device.cc

Comment 2 by guidou@chromium.org, Jun 22 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment