We've gradually accumulated a ton of unused resources in Clank. Each of which bloats our apk size. Remove the unused ones, update suppressions, and reactivate the lint check. M-61 for Chrome Go.
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/104e03d8520b292a3aa62141b34e324b5eb97813 commit 104e03d8520b292a3aa62141b34e324b5eb97813 Author: Peter Wen <wnwen@google.com> Date: Thu Jun 08 16:19:23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e894e1afbb801479455e05aed800ff5b31fb285 commit 4e894e1afbb801479455e05aed800ff5b31fb285 Author: Peter Wen <wnwen@chromium.org> Date: Wed Jun 21 18:31:50 2017 Android: Include generated files in lint Previously srcjars were not included as part of the java files that we ran lint on. Now they are extracted to a temporary directory for each target. Linting srcjars improves intdef and unused resources checks. Type annotations will be available in Java 8. Removing it for now and adding TODO to add it back when Java 8 becomes available. Bug: 731159 , 730711 Change-Id: Id2d7abe981c8ba8a23712748942d500056023587 Reviewed-on: https://chromium-review.googlesource.com/539897 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#481253} [modify] https://crrev.com/4e894e1afbb801479455e05aed800ff5b31fb285/build/android/gyp/lint.py [modify] https://crrev.com/4e894e1afbb801479455e05aed800ff5b31fb285/build/android/gyp/write_build_config.py [modify] https://crrev.com/4e894e1afbb801479455e05aed800ff5b31fb285/build/android/lint/suppressions.xml [modify] https://crrev.com/4e894e1afbb801479455e05aed800ff5b31fb285/build/config/android/internal_rules.gni [modify] https://crrev.com/4e894e1afbb801479455e05aed800ff5b31fb285/components/location/android/java/src/org/chromium/components/location/LocationUtils.java [modify] https://crrev.com/4e894e1afbb801479455e05aed800ff5b31fb285/net/android/java/src/org/chromium/net/X509Util.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29d4ab46123d8b7ca92dfa3129098bbb7460139d commit 29d4ab46123d8b7ca92dfa3129098bbb7460139d Author: Peter Wen <wnwen@chromium.org> Date: Wed Jul 12 16:44:08 2017 Android: Remove unused resources These were found as part of the effort to re-enable android unused resources lint checks. The actual lint checks will be re-enabled once platform-tools is rolled to version 26+. Bug: 731159 Change-Id: I6c977371acac62b4301fe71def8e0f0313238a73 Reviewed-on: https://chromium-review.googlesource.com/566893 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#485994} [modify] https://crrev.com/29d4ab46123d8b7ca92dfa3129098bbb7460139d/build/android/lint/suppressions.xml [delete] https://crrev.com/2c2e56f561ef8809e32b819085fff50f23dade18/chrome/android/java/res/layout/chrome_home_incognito_new_tab_page.xml [delete] https://crrev.com/2c2e56f561ef8809e32b819085fff50f23dade18/chrome/android/java/res/layout/chrome_home_new_tab_page.xml [delete] https://crrev.com/2c2e56f561ef8809e32b819085fff50f23dade18/chrome/android/java/res/layout/fragment_lock_screen.xml [delete] https://crrev.com/2c2e56f561ef8809e32b819085fff50f23dade18/chrome/android/java/res/layout/reader_mode_text_view.xml [modify] https://crrev.com/29d4ab46123d8b7ca92dfa3129098bbb7460139d/chrome/app/generated_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e0ca1fb4928d46c05ef444b376b3ab1c0db02b2 commit 0e0ca1fb4928d46c05ef444b376b3ab1c0db02b2 Author: Peter Wen <wnwen@chromium.org> Date: Thu Jul 20 18:01:06 2017 Android: Turn on UnusedResources lint check Fixes current lint warnings and starts to remove obsolete old suppressions. Moving towards a world where we have as few suppressions as possible. Bug: 731159 Change-Id: If960d984b0906b80d3cd8c504a0d0af83f6a8a89 Reviewed-on: https://chromium-review.googlesource.com/578488 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488307} [modify] https://crrev.com/0e0ca1fb4928d46c05ef444b376b3ab1c0db02b2/build/android/lint/suppressions.xml [modify] https://crrev.com/0e0ca1fb4928d46c05ef444b376b3ab1c0db02b2/chrome/android/webapk/shell_apk/BUILD.gn [modify] https://crrev.com/0e0ca1fb4928d46c05ef444b376b3ab1c0db02b2/remoting/android/client_java_tmpl.gni [delete] https://crrev.com/6585ea382c6068830d0be539d2855569cb3cc83f/remoting/android/java/res/layout/account_selected.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e56888a823d548d9a4afa4a738074753c49af883 commit e56888a823d548d9a4afa4a738074753c49af883 Author: Scott Little <sclittle@chromium.org> Date: Thu Jul 20 18:25:56 2017 Revert "Android: Turn on UnusedResources lint check" This reverts commit 0e0ca1fb4928d46c05ef444b376b3ab1c0db02b2. Reason for revert: Broke compile on Android Arm64 Builder (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29 Original change's description: > Android: Turn on UnusedResources lint check > > Fixes current lint warnings and starts to remove obsolete old > suppressions. Moving towards a world where we have as few suppressions > as possible. > > Bug: 731159 > Change-Id: If960d984b0906b80d3cd8c504a0d0af83f6a8a89 > Reviewed-on: https://chromium-review.googlesource.com/578488 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Reviewed-by: Yuwei Huang <yuweih@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488307} TBR=wnwen@chromium.org,hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org Change-Id: I7dc0c54b509fe2597a38bb6d660d9c4e7232321d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731159 Reviewed-on: https://chromium-review.googlesource.com/579749 Reviewed-by: Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#488314} [modify] https://crrev.com/e56888a823d548d9a4afa4a738074753c49af883/build/android/lint/suppressions.xml [modify] https://crrev.com/e56888a823d548d9a4afa4a738074753c49af883/chrome/android/webapk/shell_apk/BUILD.gn [modify] https://crrev.com/e56888a823d548d9a4afa4a738074753c49af883/remoting/android/client_java_tmpl.gni [add] https://crrev.com/e56888a823d548d9a4afa4a738074753c49af883/remoting/android/java/res/layout/account_selected.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/213738bd67fe48a4a22066680a55e483d23bd6c8 commit 213738bd67fe48a4a22066680a55e483d23bd6c8 Author: Peter Wen <wnwen@chromium.org> Date: Thu Jul 20 18:27:01 2017 Revert "Android: Turn on UnusedResources lint check" This reverts commit 0e0ca1fb4928d46c05ef444b376b3ab1c0db02b2. Reason for revert: <INSERT REASONING HERE> Original change's description: > Android: Turn on UnusedResources lint check > > Fixes current lint warnings and starts to remove obsolete old > suppressions. Moving towards a world where we have as few suppressions > as possible. > > Bug: 731159 > Change-Id: If960d984b0906b80d3cd8c504a0d0af83f6a8a89 > Reviewed-on: https://chromium-review.googlesource.com/578488 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Reviewed-by: Yuwei Huang <yuweih@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488307} TBR=wnwen@chromium.org,hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org Change-Id: I0347f22ffdf8ff7fa50a94a5d164dc4b790851f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731159 Reviewed-on: https://chromium-review.googlesource.com/580227 Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488315}
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94fc8d933c7a1c6d3414a752615c93bd3df8ec8a commit 94fc8d933c7a1c6d3414a752615c93bd3df8ec8a Author: Peter Wen <wnwen@chromium.org> Date: Thu Jul 20 20:19:50 2017 Reland "Android: Turn on UnusedResources lint check" Original CL: http://crrev.com/c/578488 Fixes: Cronet builders TBR=hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org Bug: 731159 Change-Id: I6a54dfbae76c1d55166dbcaaea7bbbc93e60bf34 Reviewed-on: https://chromium-review.googlesource.com/580267 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488380} [modify] https://crrev.com/94fc8d933c7a1c6d3414a752615c93bd3df8ec8a/build/android/lint/suppressions.xml [modify] https://crrev.com/94fc8d933c7a1c6d3414a752615c93bd3df8ec8a/chrome/android/webapk/shell_apk/BUILD.gn [modify] https://crrev.com/94fc8d933c7a1c6d3414a752615c93bd3df8ec8a/remoting/android/client_java_tmpl.gni [delete] https://crrev.com/bcce8b135d29e3d5f30ec3dd93dce8b44d392c00/remoting/android/java/res/layout/account_selected.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3d8718a33913edc90c47877193f6f3b3455ef9f commit f3d8718a33913edc90c47877193f6f3b3455ef9f Author: Miriam Gershenson <mgersh@chromium.org> Date: Thu Jul 20 20:57:14 2017 Revert "Reland "Android: Turn on UnusedResources lint check"" This reverts commit 94fc8d933c7a1c6d3414a752615c93bd3df8ec8a. Reason for revert: Cronet builders are breaking again, debug builders only this time: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20x86%20Builder%20%28dbg%29/builds/61964 We have an android_cronet_tester trybot but I don't remember if it does debug builds or not. Original change's description: > Reland "Android: Turn on UnusedResources lint check" > > Original CL: http://crrev.com/c/578488 > > Fixes: Cronet builders > > TBR=hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org > > Bug: 731159 > Change-Id: I6a54dfbae76c1d55166dbcaaea7bbbc93e60bf34 > Reviewed-on: https://chromium-review.googlesource.com/580267 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488380} TBR=wnwen@chromium.org,hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org Change-Id: I3360f01c815fe0674a05ae38622778bd5ed55305 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731159 Reviewed-on: https://chromium-review.googlesource.com/580134 Reviewed-by: Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#488398} [modify] https://crrev.com/f3d8718a33913edc90c47877193f6f3b3455ef9f/build/android/lint/suppressions.xml [modify] https://crrev.com/f3d8718a33913edc90c47877193f6f3b3455ef9f/chrome/android/webapk/shell_apk/BUILD.gn [modify] https://crrev.com/f3d8718a33913edc90c47877193f6f3b3455ef9f/remoting/android/client_java_tmpl.gni [add] https://crrev.com/f3d8718a33913edc90c47877193f6f3b3455ef9f/remoting/android/java/res/layout/account_selected.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f3490755aa9a4f9fc956ed2a5ca694c2a4dbd25 commit 4f3490755aa9a4f9fc956ed2a5ca694c2a4dbd25 Author: Andrew Grieve <agrieve@chromium.org> Date: Fri Jul 21 19:37:17 2017 Reland #2 Android: Turn on UnusedResources lint check This reverts commit f3d8718a33913edc90c47877193f6f3b3455ef9f. Reason for reland: Didn't cause the bot failure. TBR=wnwen@chromium.org,mgersh@chromium.org,hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org Bug: 731159 Change-Id: Idb2140b3c72065778e0d87b96c959eb6f2205543 Reviewed-on: https://chromium-review.googlesource.com/581467 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#488738} [modify] https://crrev.com/4f3490755aa9a4f9fc956ed2a5ca694c2a4dbd25/build/android/lint/suppressions.xml [modify] https://crrev.com/4f3490755aa9a4f9fc956ed2a5ca694c2a4dbd25/chrome/android/webapk/shell_apk/BUILD.gn [modify] https://crrev.com/4f3490755aa9a4f9fc956ed2a5ca694c2a4dbd25/remoting/android/client_java_tmpl.gni [delete] https://crrev.com/4131a1c1ef8bdde8e752353ad6e24771d3b866da/remoting/android/java/res/layout/account_selected.xml [modify] https://crrev.com/4f3490755aa9a4f9fc956ed2a5ca694c2a4dbd25/ui/android/java/res/values-v17/styles.xml [modify] https://crrev.com/4f3490755aa9a4f9fc956ed2a5ca694c2a4dbd25/ui/android/java/res/values-v21/styles.xml
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/3bea86d9ab494f8739072fc445adebe93fd8a94a commit 3bea86d9ab494f8739072fc445adebe93fd8a94a Author: Peter Wen <wnwen@google.com> Date: Wed Aug 09 21:21:28 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/4da7e9c7fcc72bfbf0e81ed8ff006b432841f426 commit 4da7e9c7fcc72bfbf0e81ed8ff006b432841f426 Author: Peter Wen <wnwen@google.com> Date: Thu Aug 10 18:55:12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e9eaa6845ab922bbd6a94accbef6af3e7ea2074 commit 2e9eaa6845ab922bbd6a94accbef6af3e7ea2074 Author: Peter Wen <wnwen@chromium.org> Date: Mon Aug 14 16:11:56 2017 Android: Remove UnusedResource suppressions Most, if not all, of these un-specified suppressions have caused binary size regressions due to resources that are no longer used but still shipped to end-users. They should be removed and replaced with very limited ones added for the ones absolutely necessary. Bug: 731159 Change-Id: I90940fd7fdc596cd43736ece113deee90cd02aa0 Reviewed-on: https://chromium-review.googlesource.com/611091 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#494063} [modify] https://crrev.com/2e9eaa6845ab922bbd6a94accbef6af3e7ea2074/build/android/lint/suppressions.xml [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-hdpi/account_management_no_picture.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-hdpi/fre_placeholder.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-hdpi/ic_folder_white_24dp.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-hdpi/ic_lock.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-hdpi/signin_promo_illustration.png [rename] https://crrev.com/2e9eaa6845ab922bbd6a94accbef6af3e7ea2074/chrome/android/java/res/drawable-hdpi/verify_checkmark.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-mdpi/account_management_no_picture.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-mdpi/fre_placeholder.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-mdpi/ic_folder_white_24dp.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-mdpi/ic_lock.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-mdpi/signin_promo_illustration.png [rename] https://crrev.com/2e9eaa6845ab922bbd6a94accbef6af3e7ea2074/chrome/android/java/res/drawable-mdpi/verify_checkmark.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xhdpi/account_management_no_picture.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xhdpi/fre_placeholder.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xhdpi/ic_folder_white_24dp.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xhdpi/ic_lock.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xhdpi/signin_promo_illustration.png [rename] https://crrev.com/2e9eaa6845ab922bbd6a94accbef6af3e7ea2074/chrome/android/java/res/drawable-xhdpi/verify_checkmark.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xxhdpi/account_management_no_picture.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xxhdpi/fre_placeholder.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xxhdpi/ic_folder_white_24dp.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xxhdpi/ic_lock.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xxhdpi/signin_promo_illustration.png [rename] https://crrev.com/2e9eaa6845ab922bbd6a94accbef6af3e7ea2074/chrome/android/java/res/drawable-xxhdpi/verify_checkmark.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xxxhdpi/account_management_no_picture.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xxxhdpi/ic_folder_white_24dp.png [delete] https://crrev.com/f91afc84abdb4135f2d3ed29d3d57d2fa20c369e/chrome/android/java/res/drawable-xxxhdpi/ic_lock.png [rename] https://crrev.com/2e9eaa6845ab922bbd6a94accbef6af3e7ea2074/chrome/android/java/res/drawable-xxxhdpi/verify_checkmark.png [modify] https://crrev.com/2e9eaa6845ab922bbd6a94accbef6af3e7ea2074/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/2e9eaa6845ab922bbd6a94accbef6af3e7ea2074/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/2e9eaa6845ab922bbd6a94accbef6af3e7ea2074/content/shell/android/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a93afb3bbedab0616e8ecaf06109b169b080be3f commit a93afb3bbedab0616e8ecaf06109b169b080be3f Author: Peter Wen <wnwen@chromium.org> Date: Mon Aug 21 18:11:35 2017 Android: Remove most unused resources suppressions Most, if not all, of these un-specified suppressions have caused binary size regressions due to resources that are no longer used but still shipped to end-users. They should be removed and replaced with very limited ones added for the ones absolutely necessary. Components is a mess right now and will be in a later CL. Bug: 731159 Change-Id: I161adac459f9e3a3be4f3b715b7af2d2997476c8 Reviewed-on: https://chromium-review.googlesource.com/616844 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Ted Choc (OOO 8.21-25) <tedchoc@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#495988} [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/android_webview/BUILD.gn [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/android_webview/tools/automated_ui_tests/BUILD.gn [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/build/android/lint/suppressions.xml [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/components/autofill/android/BUILD.gn [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/components/autofill/android/java/src/org/chromium/components/autofill/AutofillPopup.java [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/components/autofill_strings.grdp [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/content/public/android/java/strings/android_content_strings.grd [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-hdpi/ic_backspace.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-hdpi/ic_cardboard.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-hdpi/ic_voice_input.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-hdpi/ic_zoom_in.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-hdpi/ic_zoom_out.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-mdpi/ic_backspace.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-mdpi/ic_cardboard.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-mdpi/ic_voice_input.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-mdpi/ic_zoom_in.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-mdpi/ic_zoom_out.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xhdpi/ic_backspace.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xhdpi/ic_cardboard.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xhdpi/ic_voice_input.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xhdpi/ic_zoom_in.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xhdpi/ic_zoom_out.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xxhdpi/ic_backspace.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xxhdpi/ic_cardboard.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xxhdpi/ic_voice_input.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xxhdpi/ic_zoom_in.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xxhdpi/ic_zoom_out.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xxxhdpi/ic_backspace.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xxxhdpi/ic_cardboard.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xxxhdpi/ic_voice_input.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xxxhdpi/ic_zoom_in.png [delete] https://crrev.com/c682cae947096fff0bd2543aab031a2296770b2f/remoting/android/java/res/drawable-xxxhdpi/ic_zoom_out.png [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/remoting/android/java/src/org/chromium/chromoting/HostInfo.java [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/remoting/resources/remoting_strings.grd [modify] https://crrev.com/a93afb3bbedab0616e8ecaf06109b169b080be3f/ui/android/java/strings/android_ui_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6207a505a3788afcaedb8d50702123a1a8f9a1b4 commit 6207a505a3788afcaedb8d50702123a1a8f9a1b4 Author: Peter Wen <wnwen@chromium.org> Date: Thu Aug 24 15:19:17 2017 Android: Split up components_strings.grd Chrome on Android needs strings in java libraries to be actually used by that java library target. We make use of android lint to hold the line against unused resources. A follow-up CL will remove the global suppression for components strings as well as its unused strings for android. This is important especially for android since each string generates non-trivial amount of overhead due to the android system, on the order of 3+ kilobytes for each string regardless of length. Individual components should avoid using strings in android java files and opt to use native strings instead, but this CL fixes the two components that do use android-specific strings in their android code. Bug: 731159 Change-Id: I4bfa7e0ba068bd996d710f7b6b8c8f01e0bb773d Reviewed-on: https://chromium-review.googlesource.com/624436 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#497053} [modify] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/android_webview/java/DEPS [modify] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/build/android/lint/suppressions.xml [modify] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/BUILD.gn [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/autofill_strings.grd [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_am.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_ar.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_bg.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_ca.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_cs.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_da.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_de.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_el.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_en-GB.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_es-419.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_es.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_fa.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_fi.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_fil.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_fr.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_hi.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_hr.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_hu.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_id.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_it.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_iw.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_ja.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_ko.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_lt.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_lv.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_nl.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_no.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_pl.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_pt-BR.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_pt-PT.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_ro.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_ru.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_sk.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_sl.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_sr.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_sv.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_sw.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_th.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_tr.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_uk.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_vi.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_zh-CN.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill/android/java/strings/translations/autofill_strings_zh-TW.xtb [modify] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/autofill_strings.grdp [modify] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/components_strings.grd [modify] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/BUILD.gn [modify] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/DEPS [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/DEPS [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-hdpi/bubble.9.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-hdpi/bubble_arrow_up.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-hdpi/color_picker_advanced_select_handle.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-hdpi/ic_warning.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-mdpi/bubble.9.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-mdpi/bubble_arrow_up.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-mdpi/color_picker_advanced_select_handle.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-mdpi/ic_warning.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-xhdpi/bubble.9.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-xhdpi/bubble_arrow_up.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-xhdpi/color_picker_advanced_select_handle.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-xhdpi/ic_warning.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-xxhdpi/ic_warning.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable-xxxhdpi/ic_warning.png [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable/color_button_background.xml [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/drawable/color_picker_border.xml [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/layout/color_picker_advanced_component.xml [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/layout/color_picker_dialog_content.xml [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/layout/color_picker_dialog_title.xml [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/layout/validation_message_bubble.xml [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/values/colors.xml [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/res/values/dimens.xml [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/ColorPickerAdvanced.java [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/ColorPickerAdvancedComponent.java [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/ColorPickerDialog.java [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/ColorPickerMoreButton.java [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/ColorPickerSimple.java [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/ColorSuggestion.java [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/ColorSuggestionListAdapter.java [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/OnColorChangedListener.java [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/ValidationMessageBubble.java [rename] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_am.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_ar.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_bg.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_ca.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_cs.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_da.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_de.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_el.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_en-GB.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_es-419.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_es.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_fa.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_fi.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_fil.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_fr.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_hi.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_hr.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_hu.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_id.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_it.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_iw.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_ja.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_ko.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_lt.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_lv.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_nl.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_no.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_pl.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_pt-BR.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_pt-PT.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_ro.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_ru.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_sk.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_sl.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_sr.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_sv.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_sw.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_th.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_tr.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_uk.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_vi.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_zh-CN.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/translations/web_contents_delegate_android_strings_zh-TW.xtb [add] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/components/web_contents_delegate_android/java/strings/web_contents_delegate_android_strings.grd [delete] https://crrev.com/a2930122081b7bc8d34bfd7fa8020a33857dc9ca/components/web_contents_delegate_android_strings.grdp [modify] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/docs/chromoting_android_hacking.md [modify] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/tools/android/eclipse/.classpath [modify] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/tools/gritsettings/resource_ids [modify] https://crrev.com/6207a505a3788afcaedb8d50702123a1a8f9a1b4/tools/gritsettings/translation_expectations.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a03ea151a1c2441a27f686ccba6ad241b21e4311 commit a03ea151a1c2441a27f686ccba6ad241b21e4311 Author: Peter Wen <wnwen@chromium.org> Date: Thu Aug 24 18:42:39 2017 Android: Remove unused components strings Only removes strings unused by android from being included in the apk. Now that components strings is linted, no more unused strings will be added as future CL owners will be responsible for removing the string from android if they remove the last usage in android code. Bug: 731159 Change-Id: Idd3cef1d13f48fa047b00a5abc5c5c965921dd63 Reviewed-on: https://chromium-review.googlesource.com/628958 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#497139} [modify] https://crrev.com/a03ea151a1c2441a27f686ccba6ad241b21e4311/build/android/lint/suppressions.xml [modify] https://crrev.com/a03ea151a1c2441a27f686ccba6ad241b21e4311/components/autofill_strings.grdp [modify] https://crrev.com/a03ea151a1c2441a27f686ccba6ad241b21e4311/components/new_or_sad_tab_strings.grdp [modify] https://crrev.com/a03ea151a1c2441a27f686ccba6ad241b21e4311/components/payments_strings.grdp
Horray! Now all resources are linted in android. :D
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee188d45c0f62ab089f5e1566986cf413c96aaa9 commit ee188d45c0f62ab089f5e1566986cf413c96aaa9 Author: Peter Wen <wnwen@chromium.org> Date: Thu Aug 31 22:15:44 2017 Android: Explicit ids for remoting strings Using explicit ids prevent the strings from being deleted and resulting in runtime errors that are hard to detect. This way lint is responsible for ensuring that the resources are still there. BUG= 731159 Change-Id: I12dde7b165a34f5a59495ef50c359e6d301e9835 Reviewed-on: https://chromium-review.googlesource.com/642134 Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#499039} [modify] https://crrev.com/ee188d45c0f62ab089f5e1566986cf413c96aaa9/build/android/lint/suppressions.xml [modify] https://crrev.com/ee188d45c0f62ab089f5e1566986cf413c96aaa9/remoting/android/java/src/org/chromium/chromoting/HostInfo.java
Comment 1 by wnwen@chromium.org
, Jun 8 2017