New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 731156 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
No longer actively working on Chrom...
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ManualTextFramerTest.OriginRTLTest fails with iOS 11

Project Member Reported by sdefresne@chromium.org, Jun 8 2017

Issue description

[ RUN      ] ManualTextFramerTest.OriginRTLTest
../../ios/chrome/browser/ui/util/manual_text_framer_unittest.mm:75: Failure
      Expected: framed_range.length
      Which is: 91
To be equal to: text_frame().framedRange.length
      Which is: 69
[  FAILED  ] ManualTextFramerTest.OriginRTLTest (5 ms)

 
Components: -Blink>HTML>Frame Test>iOS
This happens when building with iOS 11 SDK, running in Xcode 9 on iPhone 7 Plus simulator.

Path to SDK from clang command-line:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.0.sdk
Components: -Test>iOS
Cc: kkhorimoto@chromium.org
Components: UI>Browser>Mobile
Owner: lpromero@chromium.org
Status: Assigned (was: Untriaged)
It might be related to the manual text framer changes.
Components: Tests>Fails
Status: Started (was: Assigned)
- ManualTextFramerTest.OriginRTLTest uses an arabic string.
- My change (2657632ce7da) changed the font from Roboto to the system font.
- In iOS 11, Apple changed the system arabic fonts (see #57 at http://ioshacker.com/news/ios-11-features-apple-didnt-announce).

https://screenshot.googleplex.com/vF2x9SLEyrx

I will change the expected frame to accommodate the new font on iOS 11.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec010b6a08e247661e07d9eb883508a74bd60468

commit ec010b6a08e247661e07d9eb883508a74bd60468
Author: lpromero <lpromero@chromium.org>
Date: Thu Jun 15 08:31:38 2017

Fix ManualTextFramerTest.OriginRTLTest on iOS 11

The test uses an arabic text. On iOS 11, Apple updated the Arabic system
font. The new font takes more horizontal space for the same text and
font size. This CL updates the target text frame on iOS 11 and above to
accomodate that.

https://screenshot.googleplex.com/vF2x9SLEyrx

BUG= 731156 
R=kkhorimoto@chromium.org

Review-Url: https://codereview.chromium.org/2935723002
Cr-Commit-Position: refs/heads/master@{#479641}

[modify] https://crrev.com/ec010b6a08e247661e07d9eb883508a74bd60468/ios/chrome/browser/ui/util/manual_text_framer_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment