New issue
Advanced search Search tips

Issue 731138 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-double-free in celt_header

Project Member Reported by ClusterFuzz, Jun 8 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6254616911282176

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-double-free
Crash Address: 0x6060000013a0
Crash State:
  celt_header
  ogg_packet
  ogg_read_packet
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6254616911282176


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: mmoroz@chromium.org xhw...@chromium.org
Cc: ddorwin@chromium.org dalecur...@chromium.org wolenetz@chromium.org
Components: Internals>Media>FFmpeg
Labels: M-60 Pri-1
Owner: jrumm...@chromium.org
Status: Assigned (was: Untriaged)
-> jrummell@ (current ffmpeg roller)

While it doesn't look like the M60 roll is to blame, the bisect in the report looks like it might have timed out or couldn't find a working build for this case. John, please take a closer look. Depending on the problem/fix, this might also need to get merged back (please update the milestone label, accordingly, I've minimally put M-60 for now.)
I am able to reproduce the problem locally. Adding logging in oggparsecelt.c:

Replacing (nil) with 0x605000000160 for idx 2
Replacing 0x605000000160 with 0x605000000200 for idx 2
Replacing 0x605000000160 with 0x6050000007a0 for idx 2
==23856==ERROR: AddressSanitizer: attempting double-free on 0x605000000160 in thread T0:
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 23 2017

jrummell: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 7 2017

jrummell: Uh oh! This issue still open and hasn't been updated in the last 28 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -ddorwin@chromium.org
Project Member

Comment 8 by ClusterFuzz, Jul 28 2017

ClusterFuzz has detected this issue as fixed in range 490022:490184.

Detailed report: https://clusterfuzz.com/testcase?key=6254616911282176

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-double-free
Crash Address: 0x6060000013a0
Crash State:
  celt_header
  ogg_packet
  ogg_read_packet
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=490022:490184

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6254616911282176


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jul 28 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6254616911282176 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 28 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
dalecurtis@, it looks like this was fixed by your cherry-pick in  bug 742380  (https://bugs.chromium.org/p/chromium/issues/detail?id=742380#c10)
Project Member

Comment 12 by sheriffbot@chromium.org, Aug 5 2017

Labels: Merge-Request-61
Project Member

Comment 13 by sheriffbot@chromium.org, Aug 5 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+ awhalley@ (Security TPM) for M61 merge review.
Labels: -Merge-Review-61 Merge-Reject-61
Fix already in 61 per #11
Labels: -M-60 M-61
Labels: Release-0-M61
Project Member

Comment 18 by sheriffbot@chromium.org, Nov 3 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment