New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 731133 link

Starred by 1 user
Status: WontFix
Owner:
sque@chromium.org
Closed: Aug 2017
Cc:
mnissler@chromium.org
█ marc...@chromium.org
Components:
EstimatedDays: 2
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 733846



Sign in to add a comment

Collect display info in debugd

Project Member Reported by sque@chromium.org, Jun 8 2017 
Previously, debugd called xrandr to get display info (see src/log_tool.cc), but that has since been removed.

I plan to write a command line tool called e.g. "display-info" that gets display info from the file  system. It will be built as part of Debugd. It will print out the info for each connector (potentially in JSON format):
name (e.g. eDP-1)
status (connected/disconnected)
Specific EDID fields (for external displays):
- Manufacturer
- Model number
- Serial number (pending privacy review)

Then, I plan to add this tool to the list of logging commands in Debugd's log_tool.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2d87f75d3c5ddf1f06ad32e4cfb2e8b480f1135a

commit 2d87f75d3c5ddf1f06ad32e4cfb2e8b480f1135a
Author: Simon Que <sque@chromium.org>
Date: Mon Jun 12 17:45:48 2017

debugd: Add drm_display_info helper tool

This scans /sys/class/drm (or a custom path) to determine what
displays are connected. For external displays, also gets the
manufacturer and model ID.

Example output (JSON):

{
   "card0": {
      "HDMI-A-1": {
         "is_connected": false
      },
      "eDP-1": {
         "is_connected": true
      }
   },
   "card1": {

   },
   "card2": {
      "DVI-I-1": {
         "is_connected": true,
         "manufacturer": "CMN",
         "model": 4161
      }
   }
}

BUG= chromium:731133 
TEST=Run on CrOS w/ external display, check JSON output
CQ-DEPEND=CL:527559

Change-Id: I6fa1d5454e34693c48307a5654ca76440fe8ff8c
Reviewed-on: https://chromium-review.googlesource.com/527820
Commit-Ready: Simon Que <sque@chromium.org>
Tested-by: Simon Que <sque@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[add] https://crrev.com/2d87f75d3c5ddf1f06ad32e4cfb2e8b480f1135a/debugd/src/helpers/drm_display_info.cc
[modify] https://crrev.com/2d87f75d3c5ddf1f06ad32e4cfb2e8b480f1135a/debugd/debugd.gyp
[add] https://crrev.com/2d87f75d3c5ddf1f06ad32e4cfb2e8b480f1135a/debugd/src/helpers/drm_display_info_reader.cc
[add] https://crrev.com/2d87f75d3c5ddf1f06ad32e4cfb2e8b480f1135a/debugd/src/helpers/drm_display_info_reader.h
[add] https://crrev.com/2d87f75d3c5ddf1f06ad32e4cfb2e8b480f1135a/debugd/src/helpers/drm_display_info_reader_test.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d49ec68d6d41bfc24378164e0549d4b6275e7cdc

commit d49ec68d6d41bfc24378164e0549d4b6275e7cdc
Author: Simon Que <sque@chromium.org>
Date: Mon Jun 12 17:45:48 2017

debugd: Install drm_display_info

BUG= chromium:731133 
TEST=emerge debugd successfully
CQ-DEPEND=CL:527820

Change-Id: I184439b7b8d159445dbe0c287e8bc727ee7833a7
Reviewed-on: https://chromium-review.googlesource.com/527559
Commit-Ready: Simon Que <sque@chromium.org>
Tested-by: Simon Que <sque@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d49ec68d6d41bfc24378164e0549d4b6275e7cdc/chromeos-base/debugd/debugd-9999.ebuild

Comment 3 by marc...@chromium.org, Jun 13 2017

Cc: marc...@chromium.org
The tool already exists and is called "modetest". Let's not implement another copy.

Comment 4 by sque@chromium.org, Jun 15 2017

Blocking: 733846

Comment 6 by sque@chromium.org, Aug 8 2017

Status: WontFix (was: Assigned)
►

Sign in to add a comment