New issue
Advanced search Search tips

Issue 731132 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Oct 18
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

rebase_dump_accessibility_tree_test.py incompatible with polygerrit (404)

Project Member Reported by aleventhal@chromium.org, Jun 8 2017

Issue description

Running tools/accessibility/rebase_dump_accessibility_tree_test.py when the code review tool is configured to be polygerrit leads to a 404:

For example, it attempts to access:
https://codereview.chromium.org/525855

It should access:
https://chromium-review.googlesource.com/c/525855/ 

 
For example, https://chromium-review.googlesource.com/changes/525855/
provides JSON (unfortunately does not appear to be legal JSON as first characters are )]}'\n

Might be complicated, but we can use the JSON results something like:

let messageIndex = data.messages.length,
  currentResults = {};
while (messageIndex -- && !currentResults.complete) {
  let message = data.messages[messageIndex].message;
  if (message.includes('\n\nDry run: Try jobs \n')) {
    if (message.includes('\nDry run: Try jobs failed on the following builders:')) {
      failed(message, currentResults);
    }
    else {
      succeeded(message, currentResults)
    }  
  }
}
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: dmazz...@chromium.org
Status: Assigned (was: Untriaged)
Status: WontFix (was: Assigned)
The script has been updated multiple times since this bug.

Sign in to add a comment